You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "wgtmac (via GitHub)" <gi...@apache.org> on 2026/06/10 03:23:54 UTC

[PR] fix: align rest table update serde with java/spec [iceberg-cpp]

wgtmac opened a new pull request, #716:
URL: https://github.com/apache/iceberg-cpp/pull/716

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] fix: align rest table update serde with java/spec [iceberg-cpp]

Posted by "zhjwpku (via GitHub)" <gi...@apache.org>.
zhjwpku commented on code in PR #716:
URL: https://github.com/apache/iceberg-cpp/pull/716#discussion_r3410561070


##########
src/iceberg/catalog/rest/json_serde.cc:
##########
@@ -903,13 +903,21 @@ Result<CommitTableRequest> CommitTableRequestFromJson(const nlohmann::json& json
 
   ICEBERG_ASSIGN_OR_RAISE(auto requirements_json,

Review Comment:
   I took a look at Java's `UpdateTableRequest.fromJson`. It doesn't appear to error when `REQUIREMENTS` or `UPDATES` is missing from the JSON object. In contrast, we're using `GetJsonValue` here, which would result in a `JsonParseError` under the same conditions. Should we align with the Java(using GetJsonValueOptional)?
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] fix: align rest table update serde with java/spec [iceberg-cpp]

Posted by "wgtmac (via GitHub)" <gi...@apache.org>.
wgtmac merged PR #716:
URL: https://github.com/apache/iceberg-cpp/pull/716


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org