[jira] [Resolved] (SSHD-746) IPv6 addresses are not supported as client sessions connection target

["Goldstein Lyor (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/SSHD-746?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Goldstein Lyor resolved SSHD-746.
---------------------------------
       Resolution: Fixed
    Fix Version/s: 1.7.0

Please close the PR (as I have done the necessary work) and test the code in your system (I have added some {{ClientTest}} unit tests on the localhost, but you should test it on a real *remote* server using IPv6)

> IPv6 addresses are not supported as client sessions connection target
> ---------------------------------------------------------------------
>
>                 Key: SSHD-746
>                 URL: https://issues.apache.org/jira/browse/SSHD-746
>             Project: MINA SSHD
>          Issue Type: New Feature
>    Affects Versions: 1.2.0
>            Reporter: Stephen Connolly
>            Assignee: Goldstein Lyor
>            Priority: Minor
>             Fix For: 1.7.0
>
>
> Seems a lot of the code is not aware of IPv6 patterns
> {code}
> java.lang.IllegalArgumentException: Invalid host pattern char in 0:0:0:0:0:0:0:1
> 	at org.apache.sshd.common.util.ValidateUtils.throwIllegalArgumentException(ValidateUtils.java:138)
> 	at org.apache.sshd.common.util.ValidateUtils.checkTrue(ValidateUtils.java:127)
> 	at org.apache.sshd.client.config.hosts.HostPatternsHolder.toPattern(HostPatternsHolder.java:247)
> 	at org.apache.sshd.client.config.hosts.HostPatternsHolder.parsePatterns(HostPatternsHolder.java:221)
> 	at org.apache.sshd.client.config.hosts.HostConfigEntry.setHost(HostConfigEntry.java:138)
> 	at org.apache.sshd.client.config.hosts.HostConfigEntry.<init>(HostConfigEntry.java:123)
> 	at org.apache.sshd.client.SshClient.connect(SshClient.java:505)
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)