You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by Rohini Palaniswamy <ro...@gmail.com> on 2013/07/23 18:59:30 UTC
Review Request 12866: [OOZIE-1405] Fix flakey SLA tests and confirm against
DB for start and duration miss
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12866/
-----------------------------------------------------------
Review request for oozie.
Bugs: OOZIE-1405
https://issues.apache.org/jira/browse/OOZIE-1405
Repository: oozie
Description
-------
Changes done:
- Confirming against DB for start and duration miss also. This prevents wrong events getting generated when lesser threads are configured. Also will be required in case of HA.
- Still see SLA tests failing sometime. But this has reduced the probability a lot. Will look at completely addressing it in another JIRA.
Diffs
-----
http://svn.apache.org/repos/asf/oozie/trunk/client/src/main/java/org/apache/oozie/client/event/message/SLAMessage.java 1506109
http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/sla/SLACalculator.java 1506109
http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java 1506109
http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/sla/SLAOperations.java 1506109
http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/sla/listener/SLAEmailEventListener.java 1506109
http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/resources/oozie-log4j.properties 1506109
http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/java/org/apache/oozie/service/TestJMSTopicService.java 1506109
http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/java/org/apache/oozie/service/TestPartitionDependencyManagerEhcache.java 1506109
http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/java/org/apache/oozie/sla/TestSLACalculatorMemory.java 1506109
http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/java/org/apache/oozie/sla/TestSLAEmailEventListener.java 1506109
http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/java/org/apache/oozie/sla/TestSLAEventGeneration.java 1506109
http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/java/org/apache/oozie/sla/TestSLAService.java 1506109
http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/resources/wf-job-sla.xml 1506109
http://svn.apache.org/repos/asf/oozie/trunk/docs/src/site/twiki/DG_SLAMonitoring.twiki 1506109
Diff: https://reviews.apache.org/r/12866/diff/
Testing
-------
Unit tests pass
Thanks,
Rohini Palaniswamy
Re: Review Request 12866: [OOZIE-1472] Confirm against database before
generating start and duration miss events
Posted by Rohini Palaniswamy <ro...@gmail.com>.
> On July 24, 2013, 8:33 a.m., Mona Chitnis wrote:
> > http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java, line 766
> > <https://reviews.apache.org/r/12866/diff/1/?file=325542#file325542line766>
> >
> > this block can be combined with the one above nested within the if(ended) block, since it only involves checking eventProc (not getting overwritten above there) and setting status - event status in addition to SLAStatus, and sending out the event
If set there, it will be overwritten by DURATION_MET or MISS status
> On July 24, 2013, 8:33 a.m., Mona Chitnis wrote:
> > http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java, line 779
> > <https://reviews.apache.org/r/12866/diff/1/?file=325542#file325542line779>
> >
> > This else block is not pertaining to Database operations. How exactly is it useful for HA, since the slaCalc object is still passed from in-memory reference of same server?
For cases the job is started but not ended
- Rohini
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12866/#review23743
-----------------------------------------------------------
On July 26, 2013, 9:52 p.m., Rohini Palaniswamy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12866/
> -----------------------------------------------------------
>
> (Updated July 26, 2013, 9:52 p.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-1472
> https://issues.apache.org/jira/browse/OOZIE-1472
>
>
> Repository: oozie
>
>
> Description
> -------
>
> Changes done:
> - Confirming against DB for start and duration miss also. This prevents wrong events getting generated when lesser threads are configured. Also will be required in case of HA.
> - Still see SLA tests failing sometime. But this has reduced the probability a lot. Will look at completely addressing it in another JIRA.
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/oozie/trunk/client/src/main/java/org/apache/oozie/client/event/message/SLAMessage.java 1507430
> http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/service/EventHandlerService.java 1507430
> http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/sla/SLACalculator.java 1507430
> http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java 1507430
> http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/sla/SLAOperations.java 1507430
> http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/sla/listener/SLAEmailEventListener.java 1507430
> http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/resources/oozie-log4j.properties 1507430
> http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/java/org/apache/oozie/service/TestJMSTopicService.java 1507430
> http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/java/org/apache/oozie/service/TestPartitionDependencyManagerEhcache.java 1507430
> http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/java/org/apache/oozie/sla/TestSLACalculatorMemory.java 1507430
> http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/java/org/apache/oozie/sla/TestSLAEmailEventListener.java 1507430
> http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/java/org/apache/oozie/sla/TestSLAEventGeneration.java 1507430
> http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/java/org/apache/oozie/sla/TestSLAService.java 1507430
> http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/resources/wf-job-sla.xml 1507430
> http://svn.apache.org/repos/asf/oozie/trunk/docs/src/site/twiki/DG_SLAMonitoring.twiki 1507430
>
> Diff: https://reviews.apache.org/r/12866/diff/
>
>
> Testing
> -------
>
> Unit tests pass
>
>
> Thanks,
>
> Rohini Palaniswamy
>
>
Re: Review Request 12866: [OOZIE-1405] Fix flakey SLA tests and confirm
against DB for start and duration miss
Posted by Mona Chitnis <mo...@yahoo.in>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12866/#review23743
-----------------------------------------------------------
http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java
<https://reviews.apache.org/r/12866/#comment47616>
this block can be combined with the one above nested within the if(ended) block, since it only involves checking eventProc (not getting overwritten above there) and setting status - event status in addition to SLAStatus, and sending out the event
http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java
<https://reviews.apache.org/r/12866/#comment47617>
This else block is not pertaining to Database operations. How exactly is it useful for HA, since the slaCalc object is still passed from in-memory reference of same server?
- Mona Chitnis
On July 23, 2013, 4:59 p.m., Rohini Palaniswamy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12866/
> -----------------------------------------------------------
>
> (Updated July 23, 2013, 4:59 p.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-1405
> https://issues.apache.org/jira/browse/OOZIE-1405
>
>
> Repository: oozie
>
>
> Description
> -------
>
> Changes done:
> - Confirming against DB for start and duration miss also. This prevents wrong events getting generated when lesser threads are configured. Also will be required in case of HA.
> - Still see SLA tests failing sometime. But this has reduced the probability a lot. Will look at completely addressing it in another JIRA.
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/oozie/trunk/client/src/main/java/org/apache/oozie/client/event/message/SLAMessage.java 1506109
> http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/sla/SLACalculator.java 1506109
> http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java 1506109
> http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/sla/SLAOperations.java 1506109
> http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/sla/listener/SLAEmailEventListener.java 1506109
> http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/resources/oozie-log4j.properties 1506109
> http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/java/org/apache/oozie/service/TestJMSTopicService.java 1506109
> http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/java/org/apache/oozie/service/TestPartitionDependencyManagerEhcache.java 1506109
> http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/java/org/apache/oozie/sla/TestSLACalculatorMemory.java 1506109
> http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/java/org/apache/oozie/sla/TestSLAEmailEventListener.java 1506109
> http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/java/org/apache/oozie/sla/TestSLAEventGeneration.java 1506109
> http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/java/org/apache/oozie/sla/TestSLAService.java 1506109
> http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/resources/wf-job-sla.xml 1506109
> http://svn.apache.org/repos/asf/oozie/trunk/docs/src/site/twiki/DG_SLAMonitoring.twiki 1506109
>
> Diff: https://reviews.apache.org/r/12866/diff/
>
>
> Testing
> -------
>
> Unit tests pass
>
>
> Thanks,
>
> Rohini Palaniswamy
>
>
Re: Review Request 12866: [OOZIE-1472] Confirm against database before
generating start and duration miss events
Posted by Rohini Palaniswamy <ro...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12866/
-----------------------------------------------------------
(Updated July 26, 2013, 11:31 p.m.)
Review request for oozie.
Bugs: OOZIE-1472
https://issues.apache.org/jira/browse/OOZIE-1472
Repository: oozie
Description
-------
Changes done:
- Confirming against DB for start and duration miss also. This prevents wrong events getting generated when lesser threads are configured. Also will be required in case of HA.
- Still see SLA tests failing sometime. But this has reduced the probability a lot. Will look at completely addressing it in another JIRA.
Diffs (updated)
-----
http://svn.apache.org/repos/asf/oozie/trunk/client/src/main/java/org/apache/oozie/client/event/message/SLAMessage.java 1507430
http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/service/EventHandlerService.java 1507430
http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/sla/SLACalculator.java 1507430
http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java 1507430
http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/sla/SLAOperations.java 1507430
http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/sla/listener/SLAEmailEventListener.java 1507430
http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/resources/oozie-log4j.properties 1507430
http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/java/org/apache/oozie/service/TestJMSTopicService.java 1507430
http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/java/org/apache/oozie/service/TestPartitionDependencyManagerEhcache.java 1507430
http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/java/org/apache/oozie/sla/TestSLACalculatorMemory.java 1507430
http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/java/org/apache/oozie/sla/TestSLAEmailEventListener.java 1507430
http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/java/org/apache/oozie/sla/TestSLAEventGeneration.java 1507430
http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/java/org/apache/oozie/sla/TestSLAService.java 1507430
http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/resources/wf-job-sla.xml 1507430
http://svn.apache.org/repos/asf/oozie/trunk/docs/src/site/twiki/DG_SLAMonitoring.twiki 1507430
Diff: https://reviews.apache.org/r/12866/diff/
Testing
-------
Unit tests pass
Thanks,
Rohini Palaniswamy
Re: Review Request 12866: [OOZIE-1472] Confirm against database before
generating start and duration miss events
Posted by Mona Chitnis <mo...@yahoo.in>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12866/#review23984
-----------------------------------------------------------
+1 after minor comments requesting more log statements at couple of places in SLACalculator
http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java
<https://reviews.apache.org/r/12866/#comment47801>
It'll be good to have log statement here indicating 'x' records loaded successfully to map and 'y' to history set
http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java
<https://reviews.apache.org/r/12866/#comment47802>
would be good to have log.debug statement here simply saying 'processing job status event for job-id'. This will give us visibility atleast through logs to see how much time it took from queuing the job event to being picked up for sla processing.
- Mona Chitnis
On July 26, 2013, 9:52 p.m., Rohini Palaniswamy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12866/
> -----------------------------------------------------------
>
> (Updated July 26, 2013, 9:52 p.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-1472
> https://issues.apache.org/jira/browse/OOZIE-1472
>
>
> Repository: oozie
>
>
> Description
> -------
>
> Changes done:
> - Confirming against DB for start and duration miss also. This prevents wrong events getting generated when lesser threads are configured. Also will be required in case of HA.
> - Still see SLA tests failing sometime. But this has reduced the probability a lot. Will look at completely addressing it in another JIRA.
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/oozie/trunk/client/src/main/java/org/apache/oozie/client/event/message/SLAMessage.java 1507430
> http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/service/EventHandlerService.java 1507430
> http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/sla/SLACalculator.java 1507430
> http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java 1507430
> http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/sla/SLAOperations.java 1507430
> http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/sla/listener/SLAEmailEventListener.java 1507430
> http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/resources/oozie-log4j.properties 1507430
> http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/java/org/apache/oozie/service/TestJMSTopicService.java 1507430
> http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/java/org/apache/oozie/service/TestPartitionDependencyManagerEhcache.java 1507430
> http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/java/org/apache/oozie/sla/TestSLACalculatorMemory.java 1507430
> http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/java/org/apache/oozie/sla/TestSLAEmailEventListener.java 1507430
> http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/java/org/apache/oozie/sla/TestSLAEventGeneration.java 1507430
> http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/java/org/apache/oozie/sla/TestSLAService.java 1507430
> http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/resources/wf-job-sla.xml 1507430
> http://svn.apache.org/repos/asf/oozie/trunk/docs/src/site/twiki/DG_SLAMonitoring.twiki 1507430
>
> Diff: https://reviews.apache.org/r/12866/diff/
>
>
> Testing
> -------
>
> Unit tests pass
>
>
> Thanks,
>
> Rohini Palaniswamy
>
>
Re: Review Request 12866: [OOZIE-1472] Confirm against database before
generating start and duration miss events
Posted by Rohini Palaniswamy <ro...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12866/
-----------------------------------------------------------
(Updated July 26, 2013, 9:52 p.m.)
Review request for oozie.
Changes
-------
Added two known issues to documentation and some debug statements
Summary (updated)
-----------------
[OOZIE-1472] Confirm against database before generating start and duration miss events
Bugs: OOZIE-1472
https://issues.apache.org/jira/browse/OOZIE-1472
Repository: oozie
Description
-------
Changes done:
- Confirming against DB for start and duration miss also. This prevents wrong events getting generated when lesser threads are configured. Also will be required in case of HA.
- Still see SLA tests failing sometime. But this has reduced the probability a lot. Will look at completely addressing it in another JIRA.
Diffs (updated)
-----
http://svn.apache.org/repos/asf/oozie/trunk/client/src/main/java/org/apache/oozie/client/event/message/SLAMessage.java 1507430
http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/service/EventHandlerService.java 1507430
http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/sla/SLACalculator.java 1507430
http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java 1507430
http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/sla/SLAOperations.java 1507430
http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/sla/listener/SLAEmailEventListener.java 1507430
http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/resources/oozie-log4j.properties 1507430
http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/java/org/apache/oozie/service/TestJMSTopicService.java 1507430
http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/java/org/apache/oozie/service/TestPartitionDependencyManagerEhcache.java 1507430
http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/java/org/apache/oozie/sla/TestSLACalculatorMemory.java 1507430
http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/java/org/apache/oozie/sla/TestSLAEmailEventListener.java 1507430
http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/java/org/apache/oozie/sla/TestSLAEventGeneration.java 1507430
http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/java/org/apache/oozie/sla/TestSLAService.java 1507430
http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/resources/wf-job-sla.xml 1507430
http://svn.apache.org/repos/asf/oozie/trunk/docs/src/site/twiki/DG_SLAMonitoring.twiki 1507430
Diff: https://reviews.apache.org/r/12866/diff/
Testing
-------
Unit tests pass
Thanks,
Rohini Palaniswamy
Re: Review Request 12866: [OOZIE-1472] Confirm against database before
generating start and duration miss events
Posted by Rohini Palaniswamy <ro...@gmail.com>.
> On July 24, 2013, 8:48 a.m., Mona Chitnis wrote:
> > http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/java/org/apache/oozie/service/TestPartitionDependencyManagerEhcache.java, line 80
> > <https://reviews.apache.org/r/12866/diff/1/?file=325547#file325547line80>
> >
> > Is 100 seconds a reasonable enough buffer to add for this flaky test?
Yes.
- Rohini
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12866/#review23744
-----------------------------------------------------------
On July 26, 2013, 11:31 p.m., Rohini Palaniswamy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12866/
> -----------------------------------------------------------
>
> (Updated July 26, 2013, 11:31 p.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-1472
> https://issues.apache.org/jira/browse/OOZIE-1472
>
>
> Repository: oozie
>
>
> Description
> -------
>
> Changes done:
> - Confirming against DB for start and duration miss also. This prevents wrong events getting generated when lesser threads are configured. Also will be required in case of HA.
> - Still see SLA tests failing sometime. But this has reduced the probability a lot. Will look at completely addressing it in another JIRA.
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/oozie/trunk/client/src/main/java/org/apache/oozie/client/event/message/SLAMessage.java 1507430
> http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/service/EventHandlerService.java 1507430
> http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/sla/SLACalculator.java 1507430
> http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java 1507430
> http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/sla/SLAOperations.java 1507430
> http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/sla/listener/SLAEmailEventListener.java 1507430
> http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/resources/oozie-log4j.properties 1507430
> http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/java/org/apache/oozie/service/TestJMSTopicService.java 1507430
> http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/java/org/apache/oozie/service/TestPartitionDependencyManagerEhcache.java 1507430
> http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/java/org/apache/oozie/sla/TestSLACalculatorMemory.java 1507430
> http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/java/org/apache/oozie/sla/TestSLAEmailEventListener.java 1507430
> http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/java/org/apache/oozie/sla/TestSLAEventGeneration.java 1507430
> http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/java/org/apache/oozie/sla/TestSLAService.java 1507430
> http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/resources/wf-job-sla.xml 1507430
> http://svn.apache.org/repos/asf/oozie/trunk/docs/src/site/twiki/DG_SLAMonitoring.twiki 1507430
>
> Diff: https://reviews.apache.org/r/12866/diff/
>
>
> Testing
> -------
>
> Unit tests pass
>
>
> Thanks,
>
> Rohini Palaniswamy
>
>
Re: Review Request 12866: [OOZIE-1405] Fix flakey SLA tests and confirm
against DB for start and duration miss
Posted by Mona Chitnis <mo...@yahoo.in>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12866/#review23744
-----------------------------------------------------------
http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/java/org/apache/oozie/service/TestPartitionDependencyManagerEhcache.java
<https://reviews.apache.org/r/12866/#comment47618>
Is 100 seconds a reasonable enough buffer to add for this flaky test?
- Mona Chitnis
On July 23, 2013, 4:59 p.m., Rohini Palaniswamy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12866/
> -----------------------------------------------------------
>
> (Updated July 23, 2013, 4:59 p.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-1405
> https://issues.apache.org/jira/browse/OOZIE-1405
>
>
> Repository: oozie
>
>
> Description
> -------
>
> Changes done:
> - Confirming against DB for start and duration miss also. This prevents wrong events getting generated when lesser threads are configured. Also will be required in case of HA.
> - Still see SLA tests failing sometime. But this has reduced the probability a lot. Will look at completely addressing it in another JIRA.
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/oozie/trunk/client/src/main/java/org/apache/oozie/client/event/message/SLAMessage.java 1506109
> http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/sla/SLACalculator.java 1506109
> http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java 1506109
> http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/sla/SLAOperations.java 1506109
> http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/sla/listener/SLAEmailEventListener.java 1506109
> http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/resources/oozie-log4j.properties 1506109
> http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/java/org/apache/oozie/service/TestJMSTopicService.java 1506109
> http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/java/org/apache/oozie/service/TestPartitionDependencyManagerEhcache.java 1506109
> http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/java/org/apache/oozie/sla/TestSLACalculatorMemory.java 1506109
> http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/java/org/apache/oozie/sla/TestSLAEmailEventListener.java 1506109
> http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/java/org/apache/oozie/sla/TestSLAEventGeneration.java 1506109
> http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/java/org/apache/oozie/sla/TestSLAService.java 1506109
> http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/resources/wf-job-sla.xml 1506109
> http://svn.apache.org/repos/asf/oozie/trunk/docs/src/site/twiki/DG_SLAMonitoring.twiki 1506109
>
> Diff: https://reviews.apache.org/r/12866/diff/
>
>
> Testing
> -------
>
> Unit tests pass
>
>
> Thanks,
>
> Rohini Palaniswamy
>
>