[GitHub] rivasj commented on a change in pull request #3329: Fix: Steering Target form doesn't display 'Steering Delivery Service' value

[GitBox <gi...@apache.org>]

rivasj commented on a change in pull request #3329: Fix: Steering Target form doesn't display 'Steering Delivery Service' value
URL: https://github.com/apache/trafficcontrol/pull/3329#discussion_r259659434
 
 

 ##########
 File path: traffic_portal/app/src/common/modules/form/deliveryServiceTarget/form.deliveryServiceTarget.tpl.html
 ##########
 @@ -33,7 +33,7 @@
             <div class="form-group" ng-class="{'has-error': hasError(dsTargetForm.deliveryServiceId), 'has-feedback': hasError(dsTargetForm.deliveryServiceId)}">
                 <label class="control-label col-md-2 col-sm-2 col-xs-12">Steering Delivery Service</label>
                 <div class="col-md-10 col-sm-10 col-xs-12">
-                    <select name="deliveryServiceId" class="form-control" ng-model="target.deliveryServiceId" ng-disabled="true" ng-options="ds.id as ds.xmlId for ds in deliveryServices"></select>
+                    <input name="deliveryServiceId" type="text" class="form-control" ng-model="deliveryService.xmlId" ng-disabled="true">
 
 Review comment:
   that would work for editing an existing target, but `target.deliveryServiceXmlId` doesn't have a value when creating a new target

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services