You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/06/15 16:24:52 UTC
[GitHub] [airflow] potiuk opened a new pull request, #24479: Fix await_container_completion condition (#23883)
potiuk opened a new pull request, #24479:
URL: https://github.com/apache/airflow/pull/24479
(cherry picked from commit 42abbf0d61f94ec50026af0c0f95eb378e403042)
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragement file, named `{pr_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk closed pull request #24479: Fix await_container_completion condition (#23883)
Posted by GitBox <gi...@apache.org>.
potiuk closed pull request #24479: Fix await_container_completion condition (#23883)
URL: https://github.com/apache/airflow/pull/24479
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #24479: Fix await_container_completion condition (#23883)
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #24479:
URL: https://github.com/apache/airflow/pull/24479#issuecomment-1203339675
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham commented on pull request #24479: Fix await_container_completion condition (#23883)
Posted by GitBox <gi...@apache.org>.
jedcunningham commented on PR #24479:
URL: https://github.com/apache/airflow/pull/24479#issuecomment-1156856793
Kinda makes sense since it's fixing a "wait for the container to finish" bug :) Guess some tests are relying on the bug.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #24479: Fix await_container_completion condition (#23883)
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #24479:
URL: https://github.com/apache/airflow/pull/24479#issuecomment-1203757328
not stale
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #24479: Fix await_container_completion condition (#23883)
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #24479:
URL: https://github.com/apache/airflow/pull/24479#issuecomment-1156785848
I tihnk we saved a lot of build-time by reverting this commit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #24479: Fix await_container_completion condition (#23883)
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #24479:
URL: https://github.com/apache/airflow/pull/24479#issuecomment-1156785251
Still running @jedcunningham :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org