You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by "Aggarwal-Raghav (via GitHub)" <gi...@apache.org> on 2025/06/21 12:28:41 UTC
[PR] [WIP] HIVE-29026: Cleanup Log4j properties file to adhere to 2.x changes [hive]
Aggarwal-Raghav opened a new pull request, #5885:
URL: https://github.com/apache/hive/pull/5885
### What changes were proposed in this pull request?
Cleanup log4j 1.x syntax. Majorly the changes are same as of HIVE-28417
### Why are the changes needed?
For log4j 2.24.3, the changes to remove packages attribute due to [LOG4J2-3644](https://issues.apache.org/jira/browse/LOG4J2-3644) was done only in [data/conf/hive-log4j2.properties](https://github.com/apache/hive/pull/5636/files#diff-d003b0ed1a14718be707a0b4e196ca3c2f9dc7adad2ca10d4868946aac53a178).
but
`packaging/target/apache-hive-4.1.0-SNAPSHOT-bin/apache-hive-4.1.0-SNAPSHOT-bin/conf/hive-log4j2.properties.template` is picked from `common/src/main/resources/hive-log4j2.properties` which cause the following WARN message.
```
2025-06-16T20:51:52.848390Z main WARN The use of package scanning to locate Log4j plugins is deprecated.
Please remove the `packages` attribute from your configuration file.
See https://logging.apache.org/log4j/2.x/faq.html#package-scanning for details.
```
### Does this PR introduce _any_ user-facing change?
NO
### How was this patch tested?
Will see CI output
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-29026: Cleanup Log4j properties file to adhere to 2.x changes [hive]
Posted by "okumin (via GitHub)" <gi...@apache.org>.
okumin merged PR #5885:
URL: https://github.com/apache/hive/pull/5885
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-29026: Cleanup Log4j properties file to adhere to 2.x changes [hive]
Posted by "Aggarwal-Raghav (via GitHub)" <gi...@apache.org>.
Aggarwal-Raghav commented on code in PR #5885:
URL: https://github.com/apache/hive/pull/5885#discussion_r2190386049
##########
iceberg/iceberg-handler/src/test/resources/log4j.properties:
##########
@@ -1,24 +0,0 @@
-# Licensed to the Apache Software Foundation (ASF) under one
Review Comment:
Also when I run the UT in iceberg/iceberg-handler the different log4j is picked even without this PR:
<img width="1372" alt="Screenshot 2025-07-07 at 8 46 57 PM" src="https://github.com/user-attachments/assets/916b11e2-d62e-4fff-bf77-71ac6fbcb21c" />
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] [WIP] HIVE-29026: Cleanup Log4j properties file to adhere to 2.x changes [hive]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #5885:
URL: https://github.com/apache/hive/pull/5885#issuecomment-2993617596
## [](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=5885) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=5885&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=5885&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=5885&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=5885&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=5885&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=5885)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-29026: Cleanup Log4j properties file to adhere to 2.x changes [hive]
Posted by "okumin (via GitHub)" <gi...@apache.org>.
okumin commented on code in PR #5885:
URL: https://github.com/apache/hive/pull/5885#discussion_r2188199226
##########
standalone-metastore/metastore-server/pom.xml:
##########
@@ -737,7 +737,7 @@
<configuration>
<api>JDO</api>
<verbose>false</verbose>
- <log4jConfiguration>${basedir}/src/main/resources/datanucleus-log4j.properties
+ <log4jConfiguration>${basedir}/src/main/resources/datanucleus-log4j2.xml
Review Comment:
Just wonder why XML is preferred here
##########
itests/hive-jmh/src/main/resources/log4j2.properties:
##########
@@ -14,7 +14,6 @@
# See the License for the specific language governing permissions and
# limitations under the License.
-status = FATAL
Review Comment:
Thanks. I agree with your decision 👍
##########
standalone-metastore/metastore-server/src/main/resources/datanucleus-log4j2.xml:
##########
@@ -0,0 +1,45 @@
+<?xml version="1.0" encoding="UTF-8"?>
+
+<!--
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+-->
+
+<Configuration status="info" strict="true" name="datanucleus">
+
+ <Properties>
+ <Property name="dnFilename">datanucleus.log</Property>
Review Comment:
Don't we need `target/`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-29026: Cleanup Log4j properties file to adhere to 2.x changes [hive]
Posted by "Aggarwal-Raghav (via GitHub)" <gi...@apache.org>.
Aggarwal-Raghav commented on code in PR #5885:
URL: https://github.com/apache/hive/pull/5885#discussion_r2188456034
##########
standalone-metastore/metastore-server/pom.xml:
##########
@@ -737,7 +737,7 @@
<configuration>
<api>JDO</api>
<verbose>false</verbose>
- <log4jConfiguration>${basedir}/src/main/resources/datanucleus-log4j.properties
+ <log4jConfiguration>${basedir}/src/main/resources/datanucleus-log4j2.xml
Review Comment:
Based on the datanucleus documentation, log4j2 was introduced as part of 6.0 verison https://www.datanucleus.org/products/accessplatform_6_0/logging.html and there are different format for log4j (properties file) vs log4j2 (xml file) provided by them.
older datanucleus-log4j.properties was exact same as mentioned in documentation other than:
log4j.appender.A1.File=datanucleus.log => log4j.appender.A1.File=**target/datanucleus.log**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-29026: Cleanup Log4j properties file to adhere to 2.x changes [hive]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #5885:
URL: https://github.com/apache/hive/pull/5885#issuecomment-3041340790
## [](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=5885) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=5885&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=5885&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=5885&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=5885&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=5885&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=5885)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-29026: Cleanup Log4j properties file to adhere to 2.x changes [hive]
Posted by "okumin (via GitHub)" <gi...@apache.org>.
okumin commented on PR #5885:
URL: https://github.com/apache/hive/pull/5885#issuecomment-3047221200
@Aggarwal-Raghav Merged. Thanks for the nice clean-up 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-29026: Cleanup Log4j properties file to adhere to 2.x changes [hive]
Posted by "okumin (via GitHub)" <gi...@apache.org>.
okumin commented on PR #5885:
URL: https://github.com/apache/hive/pull/5885#issuecomment-3043378865
I checked the CI. [This](https://github.com/apache/hive/commit/ade51d810b383dd68874ecaa275c3a6cc9157884) is the parent commit, and [this](https://ci.hive.apache.org/blue/organizations/jenkins/hive-precommit/detail/master/2597/pipeline) is the result of CI.
[This](https://ci.hive.apache.org/blue/organizations/jenkins/hive-precommit/detail/PR-5885/3/pipeline) is the latest CI of this PR.
| Revision | Skipped | Passed |
|-|-|-|
| ade51d810b383dd68874ecaa275c3a6cc9157884 | 2672 | 107241 |
| This PR | 2672 | 107241 |
Looks identical.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-29026: Cleanup Log4j properties file to adhere to 2.x changes [hive]
Posted by "zhangbutao (via GitHub)" <gi...@apache.org>.
zhangbutao commented on code in PR #5885:
URL: https://github.com/apache/hive/pull/5885#discussion_r2190324345
##########
iceberg/iceberg-handler/src/test/resources/log4j.properties:
##########
@@ -1,24 +0,0 @@
-# Licensed to the Apache Software Foundation (ASF) under one
Review Comment:
Is this a safe deletion?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-29026: Cleanup Log4j properties file to adhere to 2.x changes [hive]
Posted by "Aggarwal-Raghav (via GitHub)" <gi...@apache.org>.
Aggarwal-Raghav commented on code in PR #5885:
URL: https://github.com/apache/hive/pull/5885#discussion_r2160237963
##########
itests/hive-jmh/src/main/resources/log4j2.properties:
##########
@@ -14,7 +14,6 @@
# See the License for the specific language governing permissions and
# limitations under the License.
-status = FATAL
Review Comment:
Thanks for the review @okumin. Very valid question, when I was working on the PR, i also though about it.
Based on the comments https://github.com/apache/logging-log4j2/issues/2794#issuecomment-2267564572
> Status Logger is intended for troubleshooting Log4j itself and its components. I strongly advise you to avoid configuring it unless you are troubleshooting a Log4j issue.
Because of that I went ahead and removed. I don't have any strong opinion on this, If you think its better to keep, then I can update the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-29026: Cleanup Log4j properties file to adhere to 2.x changes [hive]
Posted by "okumin (via GitHub)" <gi...@apache.org>.
okumin commented on code in PR #5885:
URL: https://github.com/apache/hive/pull/5885#discussion_r2160228125
##########
itests/hive-jmh/src/main/resources/log4j2.properties:
##########
@@ -14,7 +14,6 @@
# See the License for the specific language governing permissions and
# limitations under the License.
-status = FATAL
Review Comment:
Although I've not checked how Log4j 2 works, I am feeling that the original intention to see only FATAL will be gone
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] [WIP] HIVE-29026: Cleanup Log4j properties file to adhere to 2.x changes [hive]
Posted by "Aggarwal-Raghav (via GitHub)" <gi...@apache.org>.
Aggarwal-Raghav commented on PR #5885:
URL: https://github.com/apache/hive/pull/5885#issuecomment-2993557406
Have moved datanucleus log4j from 1.x to 2.x based on https://www.datanucleus.org/products/accessplatform_6_0/logging.html
Removed `iceberg/iceberg-handler/src/test/resources/log4j.properties`, as it is says "Configuration for modules which are using log4j v1 (e.g. Hive2, DataNucleus)" If there are any UT failures then will migrate it to 2.x
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-29026: Cleanup Log4j properties file to adhere to 2.x changes [hive]
Posted by "Aggarwal-Raghav (via GitHub)" <gi...@apache.org>.
Aggarwal-Raghav commented on code in PR #5885:
URL: https://github.com/apache/hive/pull/5885#discussion_r2188456394
##########
standalone-metastore/metastore-server/pom.xml:
##########
@@ -737,8 +737,8 @@
<configuration>
<api>JDO</api>
<verbose>false</verbose>
- <log4jConfiguration>${basedir}/src/main/resources/datanucleus-log4j.properties
- </log4jConfiguration>
+ <log4j2Configuration>${basedir}/src/main/resources/datanucleus-log4j2.xml
Review Comment:
Made this change based on https://www.datanucleus.org/products/accessplatform_6_0/jdo/enhancer.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-29026: Cleanup Log4j properties file to adhere to 2.x changes [hive]
Posted by "Aggarwal-Raghav (via GitHub)" <gi...@apache.org>.
Aggarwal-Raghav commented on code in PR #5885:
URL: https://github.com/apache/hive/pull/5885#discussion_r2188453585
##########
standalone-metastore/metastore-server/src/main/resources/datanucleus-log4j2.xml:
##########
@@ -0,0 +1,45 @@
+<?xml version="1.0" encoding="UTF-8"?>
+
+<!--
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+-->
+
+<Configuration status="info" strict="true" name="datanucleus">
+
+ <Properties>
+ <Property name="dnFilename">datanucleus.log</Property>
Review Comment:
Ack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-29026: Cleanup Log4j properties file to adhere to 2.x changes [hive]
Posted by "Aggarwal-Raghav (via GitHub)" <gi...@apache.org>.
Aggarwal-Raghav commented on PR #5885:
URL: https://github.com/apache/hive/pull/5885#issuecomment-3041278967
rebased to resolve merge conflicts
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-29026: Cleanup Log4j properties file to adhere to 2.x changes [hive]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #5885:
URL: https://github.com/apache/hive/pull/5885#issuecomment-3042312778
## [](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=5885) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=5885&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=5885&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=5885&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=5885&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=5885&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=5885)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-29026: Cleanup Log4j properties file to adhere to 2.x changes [hive]
Posted by "Aggarwal-Raghav (via GitHub)" <gi...@apache.org>.
Aggarwal-Raghav commented on code in PR #5885:
URL: https://github.com/apache/hive/pull/5885#discussion_r2190350698
##########
iceberg/iceberg-handler/src/test/resources/log4j.properties:
##########
@@ -1,24 +0,0 @@
-# Licensed to the Apache Software Foundation (ASF) under one
Review Comment:
I believe so. Here is my reasoning:
1. It is not refered in the iceberg module pom or in any other pom as well.
2. Looks like it came as part iceberg mr module (might be even lower iceberg version as well): https://github.com/apache/iceberg/blob/apache-iceberg-1.3.0/mr/src/test/resources/log4j.properties
3. the comment in the log4j.properties file: "# Configuration for modules which are using log4j v1 (e.g. Hive2, DataNucleus)"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org