You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/10/04 11:10:29 UTC
[GitHub] [superset] EBoisseauSierra opened a new issue #16956: I want `superset {im, ex}port` to *fail* if unsuccessful
EBoisseauSierra opened a new issue #16956:
URL: https://github.com/apache/superset/issues/16956
When the import of a dashboard export fails, the logger lists an exception but the Python script exits as successful. This is a bit counter-intuitive as the import/export has actually failed.
#### How to reproduce the bug
1. Import a non-working export ZIP archive,
2. The exception is caught by [that broad `except Exception` catch](https://github.com/apache/superset/blob/master/superset/cli.py#L358-L362).
3. The Python script exits with a `0` exit code.
### Expected results
Because the command has effectively failed to execute, I expect the Python script to exits with a non-0 exit code.
### Actual results
0-exit code.
### Environment
- superset version: `1.3.0`
- python version: `3.8.12`
- any feature flags active: `"VERSION_EXPORT": True`
### Checklist
Make sure to follow these steps before submitting your issue - thank you!
- [x] I have checked the superset logs for python stacktraces and included it here as text if there are any.
- [x] I have reproduced the issue with at least the latest released version of superset.
- [x] I have checked the issue tracker for the same issue and I haven't found one similar.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] EBoisseauSierra commented on issue #16956: I want `superset {im, ex}port` to *fail* if unsuccessful
Posted by GitBox <gi...@apache.org>.
EBoisseauSierra commented on issue #16956:
URL: https://github.com/apache/superset/issues/16956#issuecomment-954613055
Closing as fixed by #16976
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] EBoisseauSierra commented on issue #16956: I want `superset {im, ex}port` to *fail* if unsuccessful
Posted by GitBox <gi...@apache.org>.
EBoisseauSierra commented on issue #16956:
URL: https://github.com/apache/superset/issues/16956#issuecomment-933547243
of course (: ! I should draft something by the end of the week and I'll gladly ping you once the WIP PR is out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] dpgaspar commented on issue #16956: I want `superset {im, ex}port` to *fail* if unsuccessful
Posted by GitBox <gi...@apache.org>.
dpgaspar commented on issue #16956:
URL: https://github.com/apache/superset/issues/16956#issuecomment-933526721
Hi @EBoisseauSierra I agree, are you willing to open a fix PR?
feel free to ping for any help, if needed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] EBoisseauSierra commented on issue #16956: I want `superset {im, ex}port` to *fail* if unsuccessful
Posted by GitBox <gi...@apache.org>.
EBoisseauSierra commented on issue #16956:
URL: https://github.com/apache/superset/issues/16956#issuecomment-933380361
I understand this behaviour is intentional (this happens multiple times, plus `# pylint: disable=broad-except`)… but I'd like to discuss whether a *failing* script wouldn't be more appropriate.
This would surely make my life writing a Puppet manifest easier!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] EBoisseauSierra closed issue #16956: I want `superset {im, ex}port` to *fail* if unsuccessful
Posted by GitBox <gi...@apache.org>.
EBoisseauSierra closed issue #16956:
URL: https://github.com/apache/superset/issues/16956
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org