[GitHub] [calcite] zinking commented on a change in pull request #2014: [CALCITE-4022] Support evaluate SqlInsert SqlBasicCall.toString()

[GitBox <gi...@apache.org>]

zinking commented on a change in pull request #2014:
URL: https://github.com/apache/calcite/pull/2014#discussion_r448358283



##########
File path: core/src/main/java/org/apache/calcite/sql/SqlUtil.java
##########
@@ -261,6 +261,32 @@ public static boolean isLiteralChain(SqlNode node) {
     }
   }
 
+  /**
+   * Unparses a call to an operator which has special syntax.
+   *
+   * @param operator The operator
+   * @param writer   Writer
+   * @param call     List of 0 or more operands
+   */
+  public static void unparseSpecialSyntax(SqlOperator operator,

Review comment:
       this name is really weird. 
   could you find a way to `inline` your implementation in the original place instead of here.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org