You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/09/22 14:18:03 UTC
[GitHub] [shardingsphere-elasticjob] luky116 opened a new pull request #1479: Add EmailJobErrorHandler to support sending email when job error
luky116 opened a new pull request #1479:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1479
Fixes #1440.
Changes proposed in this pull request:
- Add EmailJobErrorHandler to support sending email when job error
-
-
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] luky116 closed pull request #1479: Add EmailJobErrorHandler to support sending email when job error
Posted by GitBox <gi...@apache.org>.
luky116 closed pull request #1479:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1479
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] TeslaCN commented on a change in pull request #1479: Add EmailJobErrorHandler to support sending email when job error
Posted by GitBox <gi...@apache.org>.
TeslaCN commented on a change in pull request #1479:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1479#discussion_r492776479
##########
File path: elasticjob-error-handler/elasticjob-error-handler-email/src/test/resources/error-handler-email.yaml
##########
@@ -0,0 +1,26 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+email:
+ host: test.mail.com
+ port: 123
+ username: username
+ password: password
+ protocol: smtp
+ from: testmail@qiyi.com
+ to: xxx1@ejob.com
+ cc: xxx2@ejob.com
Review comment:
Need a blank line.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] TeslaCN commented on a change in pull request #1479: Add EmailJobErrorHandler to support sending email when job error
Posted by GitBox <gi...@apache.org>.
TeslaCN commented on a change in pull request #1479:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1479#discussion_r492778383
##########
File path: elasticjob-error-handler/elasticjob-error-handler-email/pom.xml
##########
@@ -27,4 +27,41 @@
</parent>
<artifactId>elasticjob-error-handler-email</artifactId>
+
+ <dependencies>
+ <dependency>
+ <groupId>org.apache.shardingsphere.elasticjob</groupId>
+ <artifactId>elasticjob-error-handler-general</artifactId>
+ <version>${project.parent.version}</version>
+ </dependency>
+
+ <dependency>
+ <groupId>org.projectlombok</groupId>
+ <artifactId>lombok</artifactId>
Review comment:
"Provided" scope is recommended.
Refer to: http://projectlombok.org/mavenrepo/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] TeslaCN commented on a change in pull request #1479: Add EmailJobErrorHandler to support sending email when job error
Posted by GitBox <gi...@apache.org>.
TeslaCN commented on a change in pull request #1479:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1479#discussion_r492776479
##########
File path: elasticjob-error-handler/elasticjob-error-handler-email/src/test/resources/error-handler-email.yaml
##########
@@ -0,0 +1,26 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+email:
+ host: test.mail.com
+ port: 123
+ username: username
+ password: password
+ protocol: smtp
+ from: testmail@qiyi.com
+ to: xxx1@ejob.com
+ cc: xxx2@ejob.com
Review comment:
Need a blank line.
##########
File path: elasticjob-error-handler/elasticjob-error-handler-email/pom.xml
##########
@@ -27,4 +27,41 @@
</parent>
<artifactId>elasticjob-error-handler-email</artifactId>
+
+ <dependencies>
+ <dependency>
+ <groupId>org.apache.shardingsphere.elasticjob</groupId>
+ <artifactId>elasticjob-error-handler-general</artifactId>
+ <version>${project.parent.version}</version>
+ </dependency>
+
+ <dependency>
+ <groupId>org.projectlombok</groupId>
+ <artifactId>lombok</artifactId>
Review comment:
"Provided" scope is recommended.
Refer to: http://projectlombok.org/mavenrepo/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] luky116 closed pull request #1479: Add EmailJobErrorHandler to support sending email when job error
Posted by GitBox <gi...@apache.org>.
luky116 closed pull request #1479:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1479
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org