[jira] [Commented] (RATIS-77) "RaftServerProtocolService" and " GRpc.proto" inconsistent

["Tsz Wo Nicholas Sze (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/RATIS-77?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16242621#comment-16242621 ] 

Tsz Wo Nicholas Sze commented on RATIS-77:
------------------------------------------

> //Executes a client-streaming call , return only one response.

This comment is not in GRpc.proto anymore.

Is this still a problem?

> "RaftServerProtocolService" and " GRpc.proto" inconsistent
> ----------------------------------------------------------
>
>                 Key: RATIS-77
>                 URL: https://issues.apache.org/jira/browse/RATIS-77
>             Project: Ratis
>          Issue Type: Bug
>            Reporter: kaiyangzhang
>            Assignee: Jing Zhao
>
> *Maybe a bug, look at the comments in the code and GRpc.proto*
> {code:title=GRpc.proto|borderStyle=solid}
>    ......
>    ......
>    //Executes a client-streaming call , return only one response.
>    rpc installSnapshot(stream ratis.common.InstallSnapshotRequestProto)
>       returns(ratis.common.InstallSnapshotReplyProto) {}
>    .......
>    .......
> {code}
> {code:title=RaftServerProtocolService.java |borderStyle=solid}
>     ........
>     ........
>     @Override
>   public StreamObserver<InstallSnapshotRequestProto> installSnapshot(
>       StreamObserver<InstallSnapshotReplyProto> responseObserver) {
>     return new StreamObserver<InstallSnapshotRequestProto>() {
>       @Override
>       public void onNext(InstallSnapshotRequestProto request) {
>         try {
>           //receive a client-streaming call, return a response stream
>           //code and GRpc.proto inconsistent
>           final InstallSnapshotReplyProto reply = server.installSnapshot(request);
>           responseObserver.onNext(reply);
>         } catch (Throwable e) {
>           LOG.info("{} got exception when handling installSnapshot {}: {}",
>               id, request.getServerRequest(), e);
>           responseObserver.onError(RaftGrpcUtil.wrapException(e));
>         }
>       }
>    ..........
>    ..........
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)