You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ant.apache.org by jaikiran <gi...@git.apache.org> on 2017/05/28 04:25:37 UTC
[GitHub] ant-ivy pull request #34: Fix IVY-1528
GitHub user jaikiran opened a pull request:
https://github.com/apache/ant-ivy/pull/34
Fix IVY-1528
The commit here fixes the issue reported in https://issues.apache.org/jira/browse/IVY-1528 and includes a test case to verify the fix. With this fix, the `classifier` extra attribute is no longer ignored while generating the `pom` file through the `makepom` task.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jaikiran/ant-ivy ivy-1528
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/ant-ivy/pull/34.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #34
----
commit 9fbe0652b74273570f24ba6c3fb20661126ed2fe
Author: Jaikiran Pai <ja...@gmail.com>
Date: 2017-05-28T04:19:27Z
IVY-1528 Don't ignore the "classifier" when creating pom module descriptor from ivy module descriptor, in makepom task
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
[GitHub] ant-ivy issue #34: Fix IVY-1528
Posted by jaikiran <gi...@git.apache.org>.
Github user jaikiran commented on the issue:
https://github.com/apache/ant-ivy/pull/34
>> we dont use @author
Fixed - removed that tag. I will setup my IDE accordingly.
>> TestXmlHelper
-- if xPathExpression would be a String and the method compiles that for itself,
reuse would be easier
Done
>> -- XmlHelper would be a better name, because does not work only on tests.
For now I wanted that class to stay just for the tests usage, since it's currently not used/required in other places. I can move it to the non-test source package if you prefer and rename it to XmlHelper.
>> -- result could be inlined
Done
>> IvyMakePomTest#testClassifier()
-- you dont use expectedPomArtifactIds for assertions. Do you want to check
emptyness after the loop?
Good catch. Fixed.
The PR has been updated with these changes. Let me know if there's any other changes that you recommend.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
[GitHub] ant-ivy issue #34: Fix IVY-1528
Posted by janmaterne <gi...@git.apache.org>.
Github user janmaterne commented on the issue:
https://github.com/apache/ant-ivy/pull/34
Thanks. It was the most common error: the user error :)
Used the GUI "git history" not on the top folder ...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
[GitHub] ant-ivy issue #34: Fix IVY-1528
Posted by janmaterne <gi...@git.apache.org>.
Github user janmaterne commented on the issue:
https://github.com/apache/ant-ivy/pull/34
- we dont use @author
- TestXmlHelper
-- if xPathExpression would be a String and the method compiles that for itself,
reuse would be easier
-- XmlHelper would be a better name, because does not work only on tests.
-- result could be inlined
- IvyMakePomTest#testClassifier()
-- you dont use expectedPomArtifactIds for assertions. Do you want to check
emptyness after the loop?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
[GitHub] ant-ivy issue #34: Fix IVY-1528
Posted by jaikiran <gi...@git.apache.org>.
Github user jaikiran commented on the issue:
https://github.com/apache/ant-ivy/pull/34
I used
>> git fetch github pull/34/head:PR-34
>> git checkout PR-34
>> Some ideas?
What does the output of:
```git status```
and then
```git show```
output locally?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
[GitHub] ant-ivy issue #34: Fix IVY-1528
Posted by janmaterne <gi...@git.apache.org>.
Github user janmaterne commented on the issue:
https://github.com/apache/ant-ivy/pull/34
It's ok. What's not ok is my own environmen: I can see your changes on PomModuleDescriptorWriter.java, but I am missing all new files.
I used
git fetch github pull/34/head:PR-34
git checkout PR-34
Some ideas?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
[GitHub] ant-ivy pull request #34: Fix IVY-1528
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/ant-ivy/pull/34
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org