[GitHub] [iceberg] kbendick commented on pull request #1459: Use gitattributes file to detect archive list automatically and simplify release script

[GitBox <gi...@apache.org>]

kbendick commented on pull request #1459:
URL: https://github.com/apache/iceberg/pull/1459#issuecomment-691923423


   cc @rdblue This PR, and the one that comes before it https://www.github.com/apache/iceberg/pull/1457, are the culmination of my research into simplifying and making the attempt to automatically detect the archive list work from the older PR https://github.com/apache/iceberg/pull/1227, which I was unable to get working without extensive (and arguably hacky) shell scripting.
   
   I feel this solution is ideal as it relies on a built-in git primitive, the `.gitattribute` file, which should be familiar to release managers.
   
   We can also add a comment above the `git archive` line mentioning that the added flag is used to pick up the tagged fies / directories from the .gitattributes file. If we wanted to, we could also still log out a debug log of the excludes (though I don't think that's necessary).
   
   Please let me know if there's any changes you'd like to see before we can merge in https://github.com/apache/iceberg/pull/1457 and then this PR!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org