[GitHub] [hadoop] xiaoyuyao commented on a change in pull request #885: HDDS-1541. Implement addAcl, removeAcl, setAcl, getAcl for Key. Contributed by Ajay Kumat.

[GitBox <gi...@apache.org>]

xiaoyuyao commented on a change in pull request #885: HDDS-1541. Implement addAcl,removeAcl,setAcl,getAcl for Key. Contributed by Ajay Kumat.
URL: https://github.com/apache/hadoop/pull/885#discussion_r289990253
 
 

 ##########
 File path: hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/rpc/RpcClient.java
 ##########
 @@ -437,6 +429,19 @@ public void createBucket(
     ozoneManagerClient.createBucket(builder.build());
   }
 
+  private List<OzoneAcl> getAclList() {
+    List<OzoneAcl> listOfAcls = new ArrayList<>();
+    //User ACL
+    listOfAcls.add(new OzoneAcl(ACLIdentityType.USER,
+        ugi.getUserName(), userRights));
+    //Group ACLs of the User
+    List<String> userGroups = Arrays.asList(UserGroupInformation
 
 Review comment:
   why do we need to recreate a new UGI instead of using ugi.getGroups() here?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org