You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "kou (via GitHub)" <gi...@apache.org> on 2023/02/15 07:45:30 UTC
[GitHub] [arrow] kou opened a new pull request, #34194: GH-34188: [C++][Benchmark] Add missing BENCHMARK_STATIC_DEFINE for bundled gbenchmark
kou opened a new pull request, #34194:
URL: https://github.com/apache/arrow/pull/34194
### Rationale for this change
We need to specify `-DBENCHMARK_STATIC_DEFINE` to use gbenchmark as a static library since gbenchmark 1.6.2.
### What changes are included in this PR?
This change specifies `BENCHMARK_STATIC_DEFINE` for bundled gbenchmark explicitly.
### Are these changes tested?
Yes.
### Are there any user-facing changes?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #34194: GH-34188: [C++][Benchmark] Add missing BENCHMARK_STATIC_DEFINE for bundled gbenchmark
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34194:
URL: https://github.com/apache/arrow/pull/34194#issuecomment-1430888865
* Closes: #34188
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou merged pull request #34194: GH-34188: [C++][Benchmark] Add missing BENCHMARK_STATIC_DEFINE for bundled gbenchmark
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou merged PR #34194:
URL: https://github.com/apache/arrow/pull/34194
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #34194: GH-34188: [C++][Benchmark] Add missing BENCHMARK_STATIC_DEFINE for bundled gbenchmark
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #34194:
URL: https://github.com/apache/arrow/pull/34194#issuecomment-1431928650
['Python', 'R'] benchmarks have high level of regressions.
[test-mac-arm](https://conbench.ursa.dev/compare/runs/a4f80f3b213b4265928d7d36f5bc610f...3330d20fe4544963b6349cb13f1af61b/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #34194: GH-34188: [C++][Benchmark] Add missing BENCHMARK_STATIC_DEFINE for bundled gbenchmark
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34194:
URL: https://github.com/apache/arrow/pull/34194#issuecomment-1430888909
:warning: GitHub issue #34188 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #34194: GH-34188: [C++][Benchmark] Add missing BENCHMARK_STATIC_DEFINE for bundled gbenchmark
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #34194:
URL: https://github.com/apache/arrow/pull/34194#issuecomment-1431186323
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #34194: GH-34188: [C++][Benchmark] Add missing BENCHMARK_STATIC_DEFINE for bundled gbenchmark
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #34194:
URL: https://github.com/apache/arrow/pull/34194#issuecomment-1431924586
Benchmark runs are scheduled for baseline = 13a9ad988e908846aca960515d9ca855c3328e7c and contender = b955da0597d2899f58cfc7b2e842075ecf900b0f. b955da0597d2899f58cfc7b2e842075ecf900b0f is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/501fe0c85c2e48b181e1df8585d4435c...add5b85d3d6444fdb076b555176e1ae5/)
[Failed :arrow_down:0.31% :arrow_up:0.06%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/a4f80f3b213b4265928d7d36f5bc610f...3330d20fe4544963b6349cb13f1af61b/)
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/613529863c544274962b62809ad4ea7f...eb78cfd44ba942e5807f903125d689db/)
[Finished :arrow_down:0.32% :arrow_up:0.03%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/ad8ebbd756504889902a6b66e48e6a84...e086eb1ddd9a464f96bf1208eec4512a/)
Buildkite builds:
[Finished] [`b955da05` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2377)
[Failed] [`b955da05` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2407)
[Finished] [`b955da05` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2375)
[Finished] [`b955da05` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2399)
[Finished] [`13a9ad98` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2376)
[Finished] [`13a9ad98` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2406)
[Finished] [`13a9ad98` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2374)
[Finished] [`13a9ad98` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2398)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org