[GitHub] [jmeter] xuxiao1797 opened a new pull request, #5939: Fix resource not closed issue

["xuxiao1797 (via GitHub)" <gi...@apache.org>]

xuxiao1797 opened a new pull request, #5939:
URL: https://github.com/apache/jmeter/pull/5939

   ## Description
   <!--- Provide a general summary of your changes in the Title above -->
   <!--- Describe your changes in detail here -->
   The OutputStream fos should be closed to prevent resource leak. 
   Use try catch can automatic close resources
   ## Motivation and Context
   <!--- Why is this change required? What problem does it solve? -->
   <!--- If it fixes an open issue, please link to the issue here. -->
   
   ## How Has This Been Tested?
   <!--- Please describe in detail how you tested your changes. -->
   <!--- Include details of your testing environment, tests ran to see how -->
   <!--- your change affects other areas of the code, etc. -->
   
   ## Screenshots (if appropriate):
   
   ## Types of changes
   <!--- What types of changes does your code introduce? Delete as appropriate -->
   - Bug fix (non-breaking change which fixes an issue)
   
   ## Checklist:
   <!--- Go over all the following points, and put an `x` in all the boxes that apply. -->
   <!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->
   - [x] My code follows the [code style][style-guide] of this project.
   - [ ] I have updated the documentation accordingly.
   
   [style-guide]: https://wiki.apache.org/jmeter/CodeStyleGuidelines
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jmeter.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [jmeter] vlsi commented on pull request #5939: Fix resource not closed issue

["vlsi (via GitHub)" <gi...@apache.org>]

vlsi commented on PR #5939:
URL: https://github.com/apache/jmeter/pull/5939#issuecomment-1555914569

   Please clarify what you are trying to achieve.
   Please provide test case to reproduce the issue.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jmeter.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [jmeter] xuxiao1797 closed pull request #5939: Fix resource not closed issue

["xuxiao1797 (via GitHub)" <gi...@apache.org>]

xuxiao1797 closed pull request #5939: Fix resource not closed issue
URL: https://github.com/apache/jmeter/pull/5939


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jmeter.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org