[jira] [Commented] (SUREFIRE-1403) [Jigsaw] [Java 9] add "--add-modules java.se.ee" to forked CLI argument

["Hudson (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SUREFIRE-1403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16325238#comment-16325238 ] 

Hudson commented on SUREFIRE-1403:
----------------------------------

ABORTED: Integrated in Jenkins build maven-surefire-dev #103 (See [https://builds.apache.org/job/maven-surefire-dev/103/])
[SUREFIRE-1403] [Jigsaw] [Java 9] add "--add-modules ALL-SYSTEM" to (tibor17: [http://git-wip-us.apache.org/repos/asf/?p=maven-surefire.git&a=commit&h=578ada73b724151f0cbce3b6ae39e55d242ef430])
* (add) surefire-booter/src/test/resources/jdk/bin/java
* (edit) maven-surefire-common/pom.xml
* (edit) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/booterclient/ForkConfiguration.java
* (edit) maven-failsafe-plugin/src/test/resources/org/apache/maven/plugin/failsafe/failsafe-summary.xml
* (edit) surefire-api/pom.xml
* (add) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/JdkAttributes.java
* (edit) surefire-booter/pom.xml
* (add) surefire-integration-tests/src/test/resources/java9-full-api/pom.xml
* (edit) README.md
* (add) surefire-booter/src/test/resources/jdk8-oracle/release
* (add) surefire-integration-tests/src/test/resources/java9-full-api/src/test/java/J9IT.java
* (delete) maven-failsafe-plugin/src/main/java/org/apache/maven/plugin/failsafe/util/JAXB.java
* (edit) maven-surefire-common/src/test/java/org/apache/maven/plugin/surefire/booterclient/BooterDeserializerStartupConfigurationTest.java
* (add) surefire-booter/src/test/resources/jdk8-IBM/release
* (edit) maven-failsafe-plugin/src/main/java/org/apache/maven/plugin/failsafe/VerifyMojo.java
* (edit) pom.xml
* (add) surefire-booter/src/test/resources/jdk/jre/bin/java
* (edit) maven-surefire-plugin/src/site/site.xml
* (edit) surefire-booter/src/main/java/org/apache/maven/surefire/booter/SystemUtils.java
* (delete) maven-surefire-plugin/src/site/resources/xsd/failsafe-summary.xjb
* (add) surefire-integration-tests/src/test/java/org/apache/maven/surefire/its/Java9FullApiIT.java
* (edit) surefire-integration-tests/src/test/java/org/apache/maven/surefire/its/jiras/Surefire1265Java9IT.java
* (edit) surefire-setup-integration-tests/pom.xml
* (edit) maven-failsafe-plugin/src/test/java/org/apache/maven/plugin/failsafe/MarshallerUnmarshallerTest.java
* (edit) maven-failsafe-plugin/src/main/java/org/apache/maven/plugin/failsafe/util/FailsafeSummaryXmlUtils.java
* (edit) maven-surefire-common/src/test/java/org/apache/maven/plugin/surefire/booterclient/ForkConfigurationTest.java
* (add) surefire-setup-integration-tests/src/main/resources/toolchains.xml
* (add) maven-surefire-plugin/src/site/markdown/java9.md
* (add) surefire-integration-tests/src/test/resources/java9-full-api/src/test/java/J9Test.java
* (edit) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/StatelessXmlReporter.java
* (add) surefire-booter/src/test/resources/jdk9-oracle/release
* (edit) maven-failsafe-plugin/src/main/java/org/apache/maven/plugin/failsafe/IntegrationTestMojo.java
* (edit) maven-surefire-common/src/test/java/org/apache/maven/plugin/surefire/booterclient/BooterDeserializerProviderConfigurationTest.java
* (edit) maven-surefire-plugin/pom.xml
* (edit) surefire-booter/src/test/java/org/apache/maven/surefire/booter/SystemUtilsTest.java
* (edit) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java
* (edit) maven-failsafe-plugin/pom.xml
* (edit) surefire-integration-tests/pom.xml
* (edit) maven-failsafe-plugin/src/test/java/org/apache/maven/plugin/failsafe/RunResultTest.java
* (add) surefire-integration-tests/src/test/java/org/apache/maven/surefire/its/AbstractJigsawIT.java
 [Agreed with Oracle] [SUREFIRE-1403] [Jigsaw] [Java 9] add (tibor17: [http://git-wip-us.apache.org/repos/asf/?p=maven-surefire.git&a=commit&h=0635d25e9d273c48196c1c9cb40eefc38393daba])
* (edit) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/booterclient/ForkConfiguration.java
[Agreed with Oracle] [SUREFIRE-1403] [DOC] [Jigsaw] [Java 9] add (tibor17: [http://git-wip-us.apache.org/repos/asf/?p=maven-surefire.git&a=commit&h=100f696029a53d57dbacd0f3962f3c305891588c])
* (edit) maven-surefire-plugin/src/site/markdown/java9.md


> [Jigsaw] [Java 9] add "--add-modules java.se.ee" to forked CLI argument
> -----------------------------------------------------------------------
>
>                 Key: SUREFIRE-1403
>                 URL: https://issues.apache.org/jira/browse/SUREFIRE-1403
>             Project: Maven Surefire
>          Issue Type: Bug
>          Components: Maven Failsafe Plugin, Maven Surefire Plugin
>            Reporter: Tibor Digana
>            Assignee: Tibor Digana
>             Fix For: 2.20.1
>
>         Attachments: surefire-1403.zip
>
>
> Calling *findClass( cls, "java.se.ee")* in *IsolatedClassLoader* does not help and does not do anything because the module is ignored in Java 9.
> In-plugin provider does not have any problem to load classes from entire JDK.
> Forked JVM would work only after added
> {{<argLine>--add-modules java.se.ee</argLine>}}
> The fix would be to add "--add-modules java.se.ee" if {{--add-modules}} is not specified by user at Java 9+.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)