[GitHub] [lucene] mikemccand commented on pull request #148: Make ConjunctionDISI package-private and add ConjunctionUtils factory class

[GitBox <gi...@apache.org>]

mikemccand commented on pull request #148:
URL: https://github.com/apache/lucene/pull/148#issuecomment-847071325


   +1 to this change -- looks great!  But:
   
   > refactors Spans to use their own copy of ConjunctionDISI
   
   it looks like you didn't have to do this (fork / make a full copy of `ConjunctionDISI` for spans)?  It looks like spans just also use the new (public) `ConjunctionUtils`, which provide (safe) public access to the package-private `ConjunctionDISI`?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org