You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by "rhymf14 (via GitHub)" <gi...@apache.org> on 2025/09/01 19:02:13 UTC
[PR] feat: replace custom LRU cache with otter cache library [cassandra-gocql-driver]
rhymf14 opened a new pull request, #1908:
URL: https://github.com/apache/cassandra-gocql-driver/pull/1908
Replace internal LRU cache implementation for prepared statements and routing key info with the more efficient otter cache library.
🤖 Generated with [Claude Code](https://claude.ai/code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] feat: replace custom LRU cache with otter cache library [cassandra-gocql-driver]
Posted by "joao-r-reis (via GitHub)" <gi...@apache.org>.
joao-r-reis commented on PR #1908:
URL: https://github.com/apache/cassandra-gocql-driver/pull/1908#issuecomment-3555321635
Related: https://github.com/apache/cassandra-gocql-driver/issues/845
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] feat: replace custom LRU cache with otter cache library [cassandra-gocql-driver]
Posted by "joao-r-reis (via GitHub)" <gi...@apache.org>.
joao-r-reis closed pull request #1908: feat: replace custom LRU cache with otter cache library
URL: https://github.com/apache/cassandra-gocql-driver/pull/1908
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] feat: replace custom LRU cache with otter cache library [cassandra-gocql-driver]
Posted by "joao-r-reis (via GitHub)" <gi...@apache.org>.
joao-r-reis commented on PR #1908:
URL: https://github.com/apache/cassandra-gocql-driver/pull/1908#issuecomment-4742123134
We really want to avoid adding 3rd party dependencies unless you can provide benchmark data that shows this would significantly improve the performance of the driver
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] feat: replace custom LRU cache with otter cache library [cassandra-gocql-driver]
Posted by "worryg0d (via GitHub)" <gi...@apache.org>.
worryg0d commented on PR #1908:
URL: https://github.com/apache/cassandra-gocql-driver/pull/1908#issuecomment-3297619857
Hi @rhymf14.
I had a quick look to understand the changes better, and here’s a short breakdown:
1. I see that it replaces gocql’s built-in LRU cache with the external caching library [maypok86/otter](maypok86/otterhttps://github.com/maypok86/otter). The motivation behind this change isn’t entirely clear—could you share the main goal? Adding some benchmarks to compare both implementations would also be good.
2. There’s no GitHub issue or Jira ticket linked. Having one would be great for tracking purposes.
3. This patch bumps the required Go version to 1.24.6, which is a big jump from the current 1.19 used on the trunk branch.
4. It looks like the patch doesn’t include recent changes from trunk, such as CASSGO-1 and CASSGO-22. Since they overlap with this implementation, it may be worth reconciling them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org