You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mynewt.apache.org by Michał Narajowski <mi...@codecoup.pl> on 2017/04/18 10:58:14 UTC
Console improvements - newtmgr and OIC over shell
Hi,
I implemented some console improvements and submitted a pull request
here: https://github.com/apache/incubator-mynewt-core/pull/230
Marko pointed out that it breaks newtmgr and OIC over shell. Should I
fix those issues or can we drop support for that? How many people care
about it?
Best regards,
Michał
Re: Console improvements - newtmgr and OIC over shell
Posted by Jacob Rosenthal <ja...@gmail.com>.
I for one am really looking forward to rtt as I dont have serial on several
off the shelf devices Im working with.
On Wed, Apr 19, 2017 at 1:16 AM, Łukasz Rymanowski <
lukasz.rymanowski@codecoup.pl> wrote:
> I suggest to create feature branch for that work in this case. I believe
> Michal will fix support for newtmgr, but till then some of us could make
> use of RTT and other cool stuff which will go on top (e.g. support for
> btmon).
> What do you think?
>
> On 19 April 2017 at 00:23, marko kiiskila <ma...@runtime.io> wrote:
>
> > Thanks for the input; I think we should keep this functional then.
> >
> > > On Apr 18, 2017, at 12:57 PM, Kevin Townsend <ke...@adafruit.com>
> wrote:
> > >
> > > Shell and newtmgr over serial is a requirement for us with the Mynewt
> > board were are planning to release soon. There is a USB Serial bridge
> chip
> > on there that we use for both the bootloader and newtmgr commands, and
> I'd
> > certainly like to keep shell support.
> > >
> > > K.
> > >
> > >
> > > On 18/04/17 20:54, Vipul Rahane wrote:
> > >> Ok with that as well. However, considering Chris's comments all STM
> > BSPs would need a second UART as it is not created in the BSPs.
> > >>
> > >> Regards,
> > >> Vipul Rahane
> > >>
> > >>> On Apr 18, 2017, at 9:41 AM, Christopher Collins <ch...@runtime.io>
> > wrote:
> > >>>
> > >>> I'm also OK with that.
> > >>>
> > >>> FYI- apps which need to support both the shell and newtmgr over
> serial
> > >>> would need the following modifications:
> > >>> 1. Replace mgmt/newtmgr/transport/nmgr_shell dependency with
> > >>> mgmt/newtmgr/transport/nmgr_uart
> > >>> 2. Enable a second UART in the project's syscfg (this would be a
> BSP
> > >>> setting, likely UART_1). For nRF BSPs, this would be the bit
> > >>> banger UART.
> > >>> 3. Specify the appropriate UART as the value of the NMGR_UART
> syscfg
> > >>> setting. Currently, the console UART is hardcoded per-BSP and
> > >>> not configurable via syscfg, but the newtmgr UART is
> configurable
> > >>> (is there a reason this is hardcoded, or is it just a
> historical
> > >>> thing?).
> > >>>
> > >>> I think that is everything that would need to be done.
> > >>>
> > >>> Chris
> > >>>
> > >>> On Tue, Apr 18, 2017 at 09:31:59AM -0700, marko kiiskila wrote:
> > >>>> +1, I’d be ok dropping that support.
> > >>>>
> > >>>>> On Apr 18, 2017, at 3:58 AM, Michał Narajowski <
> > michal.narajowski@codecoup.pl> wrote:
> > >>>>>
> > >>>>> Hi,
> > >>>>>
> > >>>>> I implemented some console improvements and submitted a pull
> request
> > >>>>> here: https://github.com/apache/incubator-mynewt-core/pull/230
> > >>>>>
> > >>>>> Marko pointed out that it breaks newtmgr and OIC over shell.
> Should I
> > >>>>> fix those issues or can we drop support for that? How many people
> > care
> > >>>>> about it?
> > >>>>>
> > >>>>> Best regards,
> > >>>>> Michał
> > >
> >
> >
>
Re: Console improvements - newtmgr and OIC over shell
Posted by Łukasz Rymanowski <lu...@codecoup.pl>.
I suggest to create feature branch for that work in this case. I believe
Michal will fix support for newtmgr, but till then some of us could make
use of RTT and other cool stuff which will go on top (e.g. support for
btmon).
What do you think?
On 19 April 2017 at 00:23, marko kiiskila <ma...@runtime.io> wrote:
> Thanks for the input; I think we should keep this functional then.
>
> > On Apr 18, 2017, at 12:57 PM, Kevin Townsend <ke...@adafruit.com> wrote:
> >
> > Shell and newtmgr over serial is a requirement for us with the Mynewt
> board were are planning to release soon. There is a USB Serial bridge chip
> on there that we use for both the bootloader and newtmgr commands, and I'd
> certainly like to keep shell support.
> >
> > K.
> >
> >
> > On 18/04/17 20:54, Vipul Rahane wrote:
> >> Ok with that as well. However, considering Chris's comments all STM
> BSPs would need a second UART as it is not created in the BSPs.
> >>
> >> Regards,
> >> Vipul Rahane
> >>
> >>> On Apr 18, 2017, at 9:41 AM, Christopher Collins <ch...@runtime.io>
> wrote:
> >>>
> >>> I'm also OK with that.
> >>>
> >>> FYI- apps which need to support both the shell and newtmgr over serial
> >>> would need the following modifications:
> >>> 1. Replace mgmt/newtmgr/transport/nmgr_shell dependency with
> >>> mgmt/newtmgr/transport/nmgr_uart
> >>> 2. Enable a second UART in the project's syscfg (this would be a BSP
> >>> setting, likely UART_1). For nRF BSPs, this would be the bit
> >>> banger UART.
> >>> 3. Specify the appropriate UART as the value of the NMGR_UART syscfg
> >>> setting. Currently, the console UART is hardcoded per-BSP and
> >>> not configurable via syscfg, but the newtmgr UART is configurable
> >>> (is there a reason this is hardcoded, or is it just a historical
> >>> thing?).
> >>>
> >>> I think that is everything that would need to be done.
> >>>
> >>> Chris
> >>>
> >>> On Tue, Apr 18, 2017 at 09:31:59AM -0700, marko kiiskila wrote:
> >>>> +1, I’d be ok dropping that support.
> >>>>
> >>>>> On Apr 18, 2017, at 3:58 AM, Michał Narajowski <
> michal.narajowski@codecoup.pl> wrote:
> >>>>>
> >>>>> Hi,
> >>>>>
> >>>>> I implemented some console improvements and submitted a pull request
> >>>>> here: https://github.com/apache/incubator-mynewt-core/pull/230
> >>>>>
> >>>>> Marko pointed out that it breaks newtmgr and OIC over shell. Should I
> >>>>> fix those issues or can we drop support for that? How many people
> care
> >>>>> about it?
> >>>>>
> >>>>> Best regards,
> >>>>> Michał
> >
>
>
Re: Console improvements - newtmgr and OIC over shell
Posted by marko kiiskila <ma...@runtime.io>.
Thanks for the input; I think we should keep this functional then.
> On Apr 18, 2017, at 12:57 PM, Kevin Townsend <ke...@adafruit.com> wrote:
>
> Shell and newtmgr over serial is a requirement for us with the Mynewt board were are planning to release soon. There is a USB Serial bridge chip on there that we use for both the bootloader and newtmgr commands, and I'd certainly like to keep shell support.
>
> K.
>
>
> On 18/04/17 20:54, Vipul Rahane wrote:
>> Ok with that as well. However, considering Chris's comments all STM BSPs would need a second UART as it is not created in the BSPs.
>>
>> Regards,
>> Vipul Rahane
>>
>>> On Apr 18, 2017, at 9:41 AM, Christopher Collins <ch...@runtime.io> wrote:
>>>
>>> I'm also OK with that.
>>>
>>> FYI- apps which need to support both the shell and newtmgr over serial
>>> would need the following modifications:
>>> 1. Replace mgmt/newtmgr/transport/nmgr_shell dependency with
>>> mgmt/newtmgr/transport/nmgr_uart
>>> 2. Enable a second UART in the project's syscfg (this would be a BSP
>>> setting, likely UART_1). For nRF BSPs, this would be the bit
>>> banger UART.
>>> 3. Specify the appropriate UART as the value of the NMGR_UART syscfg
>>> setting. Currently, the console UART is hardcoded per-BSP and
>>> not configurable via syscfg, but the newtmgr UART is configurable
>>> (is there a reason this is hardcoded, or is it just a historical
>>> thing?).
>>>
>>> I think that is everything that would need to be done.
>>>
>>> Chris
>>>
>>> On Tue, Apr 18, 2017 at 09:31:59AM -0700, marko kiiskila wrote:
>>>> +1, I’d be ok dropping that support.
>>>>
>>>>> On Apr 18, 2017, at 3:58 AM, Michał Narajowski <mi...@codecoup.pl> wrote:
>>>>>
>>>>> Hi,
>>>>>
>>>>> I implemented some console improvements and submitted a pull request
>>>>> here: https://github.com/apache/incubator-mynewt-core/pull/230
>>>>>
>>>>> Marko pointed out that it breaks newtmgr and OIC over shell. Should I
>>>>> fix those issues or can we drop support for that? How many people care
>>>>> about it?
>>>>>
>>>>> Best regards,
>>>>> Michał
>
Re: Console improvements - newtmgr and OIC over shell
Posted by Kevin Townsend <ke...@adafruit.com>.
Shell and newtmgr over serial is a requirement for us with the Mynewt
board were are planning to release soon. There is a USB Serial bridge
chip on there that we use for both the bootloader and newtmgr commands,
and I'd certainly like to keep shell support.
K.
On 18/04/17 20:54, Vipul Rahane wrote:
> Ok with that as well. However, considering Chris's comments all STM BSPs would need a second UART as it is not created in the BSPs.
>
> Regards,
> Vipul Rahane
>
>> On Apr 18, 2017, at 9:41 AM, Christopher Collins <ch...@runtime.io> wrote:
>>
>> I'm also OK with that.
>>
>> FYI- apps which need to support both the shell and newtmgr over serial
>> would need the following modifications:
>> 1. Replace mgmt/newtmgr/transport/nmgr_shell dependency with
>> mgmt/newtmgr/transport/nmgr_uart
>> 2. Enable a second UART in the project's syscfg (this would be a BSP
>> setting, likely UART_1). For nRF BSPs, this would be the bit
>> banger UART.
>> 3. Specify the appropriate UART as the value of the NMGR_UART syscfg
>> setting. Currently, the console UART is hardcoded per-BSP and
>> not configurable via syscfg, but the newtmgr UART is configurable
>> (is there a reason this is hardcoded, or is it just a historical
>> thing?).
>>
>> I think that is everything that would need to be done.
>>
>> Chris
>>
>> On Tue, Apr 18, 2017 at 09:31:59AM -0700, marko kiiskila wrote:
>>> +1, I\u2019d be ok dropping that support.
>>>
>>>> On Apr 18, 2017, at 3:58 AM, Micha\u0142 Narajowski <mi...@codecoup.pl> wrote:
>>>>
>>>> Hi,
>>>>
>>>> I implemented some console improvements and submitted a pull request
>>>> here: https://github.com/apache/incubator-mynewt-core/pull/230
>>>>
>>>> Marko pointed out that it breaks newtmgr and OIC over shell. Should I
>>>> fix those issues or can we drop support for that? How many people care
>>>> about it?
>>>>
>>>> Best regards,
>>>> Micha\u0142
Re: Console improvements - newtmgr and OIC over shell
Posted by Vipul Rahane <vi...@runtime.io>.
Ok with that as well. However, considering Chris's comments all STM BSPs would need a second UART as it is not created in the BSPs.
Regards,
Vipul Rahane
> On Apr 18, 2017, at 9:41 AM, Christopher Collins <ch...@runtime.io> wrote:
>
> I'm also OK with that.
>
> FYI- apps which need to support both the shell and newtmgr over serial
> would need the following modifications:
> 1. Replace mgmt/newtmgr/transport/nmgr_shell dependency with
> mgmt/newtmgr/transport/nmgr_uart
> 2. Enable a second UART in the project's syscfg (this would be a BSP
> setting, likely UART_1). For nRF BSPs, this would be the bit
> banger UART.
> 3. Specify the appropriate UART as the value of the NMGR_UART syscfg
> setting. Currently, the console UART is hardcoded per-BSP and
> not configurable via syscfg, but the newtmgr UART is configurable
> (is there a reason this is hardcoded, or is it just a historical
> thing?).
>
> I think that is everything that would need to be done.
>
> Chris
>
> On Tue, Apr 18, 2017 at 09:31:59AM -0700, marko kiiskila wrote:
>> +1, I’d be ok dropping that support.
>>
>>> On Apr 18, 2017, at 3:58 AM, Michał Narajowski <mi...@codecoup.pl> wrote:
>>>
>>> Hi,
>>>
>>> I implemented some console improvements and submitted a pull request
>>> here: https://github.com/apache/incubator-mynewt-core/pull/230
>>>
>>> Marko pointed out that it breaks newtmgr and OIC over shell. Should I
>>> fix those issues or can we drop support for that? How many people care
>>> about it?
>>>
>>> Best regards,
>>> Michał
>>
Re: Console improvements - newtmgr and OIC over shell
Posted by Christopher Collins <ch...@runtime.io>.
I'm also OK with that.
FYI- apps which need to support both the shell and newtmgr over serial
would need the following modifications:
1. Replace mgmt/newtmgr/transport/nmgr_shell dependency with
mgmt/newtmgr/transport/nmgr_uart
2. Enable a second UART in the project's syscfg (this would be a BSP
setting, likely UART_1). For nRF BSPs, this would be the bit
banger UART.
3. Specify the appropriate UART as the value of the NMGR_UART syscfg
setting. Currently, the console UART is hardcoded per-BSP and
not configurable via syscfg, but the newtmgr UART is configurable
(is there a reason this is hardcoded, or is it just a historical
thing?).
I think that is everything that would need to be done.
Chris
On Tue, Apr 18, 2017 at 09:31:59AM -0700, marko kiiskila wrote:
> +1, I\u2019d be ok dropping that support.
>
> > On Apr 18, 2017, at 3:58 AM, Micha\u0142 Narajowski <mi...@codecoup.pl> wrote:
> >
> > Hi,
> >
> > I implemented some console improvements and submitted a pull request
> > here: https://github.com/apache/incubator-mynewt-core/pull/230
> >
> > Marko pointed out that it breaks newtmgr and OIC over shell. Should I
> > fix those issues or can we drop support for that? How many people care
> > about it?
> >
> > Best regards,
> > Micha\u0142
>
Re: Console improvements - newtmgr and OIC over shell
Posted by marko kiiskila <ma...@runtime.io>.
+1, I’d be ok dropping that support.
> On Apr 18, 2017, at 3:58 AM, Michał Narajowski <mi...@codecoup.pl> wrote:
>
> Hi,
>
> I implemented some console improvements and submitted a pull request
> here: https://github.com/apache/incubator-mynewt-core/pull/230
>
> Marko pointed out that it breaks newtmgr and OIC over shell. Should I
> fix those issues or can we drop support for that? How many people care
> about it?
>
> Best regards,
> Michał