You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Colm O hEigeartaigh <co...@apache.org> on 2016/04/19 19:26:20 UTC
Review Request 46397: Some junit related improvements
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46397/
-----------------------------------------------------------
Review request for ranger.
Repository: ranger
Description
-------
There are some junit related changes I'd like to make to Ranger:
a) Update to 4.12
b) Make sure junit is defined at test scope in all the modules
c) Remove it from the assembly files, there should be no need to include test dependencies
d) Remove it from a few shims where there are no test classes
Diffs
-----
agents-common/pom.xml 9d0c5f1
agents-cred/pom.xml 673dbc1
credentialbuilder/pom.xml bf34222
hdfs-agent/pom.xml 5918f9f
knox-agent/pom.xml 77e27fb
pom.xml faa3a2e
ranger-examples/conditions-enrichers/pom.xml f5bb5fc
ranger-hdfs-plugin-shim/pom.xml c15dfa7
ranger-hive-plugin-shim/pom.xml 2bd18bd
src/main/assembly/admin-web.xml ca68ac6
src/main/assembly/hbase-agent.xml 3255907
src/main/assembly/hdfs-agent.xml 742ef94
src/main/assembly/hive-agent.xml 9e9df8c
src/main/assembly/kms.xml ec81ed7
src/main/assembly/knox-agent.xml c036187
src/main/assembly/plugin-kafka.xml 1e33e7f
src/main/assembly/plugin-kms.xml 57ab8c3
src/main/assembly/plugin-solr.xml 43ab738
src/main/assembly/plugin-yarn.xml b286a49
src/main/assembly/storm-agent.xml 2813f90
Diff: https://reviews.apache.org/r/46397/diff/
Testing
-------
Thanks,
Colm O hEigeartaigh
Re: Review Request 46397: Some junit related improvements
Posted by Alok Lal <al...@ebay.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46397/#review130119
-----------------------------------------------------------
Ship it!
Ship It!
- Alok Lal
On April 20, 2016, 2:07 a.m., Colm O hEigeartaigh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46397/
> -----------------------------------------------------------
>
> (Updated April 20, 2016, 2:07 a.m.)
>
>
> Review request for ranger.
>
>
> Repository: ranger
>
>
> Description
> -------
>
> There are some junit related changes I'd like to make to Ranger:
>
> a) Update to 4.12
> b) Remove it from the assembly files, there should be no need to include test dependencies
> c) Remove it from a few shims where there are no test classes
> d) Remove the "test" dependency in the submodules as it's already declared in the root pom
>
>
> Diffs
> -----
>
> kms/pom.xml 966b748
> pom.xml faa3a2e
> ranger-hdfs-plugin-shim/pom.xml c15dfa7
> ranger-hive-plugin-shim/pom.xml 2bd18bd
> ranger-plugin-classloader/pom.xml 4d6e2b9
> ranger-tools/pom.xml ec85a5f
> security-admin/pom.xml 2af0cf4
> src/main/assembly/admin-web.xml ca68ac6
> src/main/assembly/hbase-agent.xml 3255907
> src/main/assembly/hdfs-agent.xml 742ef94
> src/main/assembly/hive-agent.xml 9e9df8c
> src/main/assembly/kms.xml ec81ed7
> src/main/assembly/knox-agent.xml c036187
> src/main/assembly/plugin-kafka.xml 1e33e7f
> src/main/assembly/plugin-kms.xml 57ab8c3
> src/main/assembly/plugin-solr.xml 43ab738
> src/main/assembly/plugin-yarn.xml b286a49
> src/main/assembly/storm-agent.xml 2813f90
> tagsync/pom.xml 855be38
> ugsync/pom.xml 1106e30
>
> Diff: https://reviews.apache.org/r/46397/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Colm O hEigeartaigh
>
>
Re: Review Request 46397: Some junit related improvements
Posted by Colm O hEigeartaigh <co...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46397/
-----------------------------------------------------------
(Updated April 20, 2016, 9:07 a.m.)
Review request for ranger.
Repository: ranger
Description (updated)
-------
There are some junit related changes I'd like to make to Ranger:
a) Update to 4.12
b) Remove it from the assembly files, there should be no need to include test dependencies
c) Remove it from a few shims where there are no test classes
d) Remove the "test" dependency in the submodules as it's already declared in the root pom
Diffs (updated)
-----
kms/pom.xml 966b748
pom.xml faa3a2e
ranger-hdfs-plugin-shim/pom.xml c15dfa7
ranger-hive-plugin-shim/pom.xml 2bd18bd
ranger-plugin-classloader/pom.xml 4d6e2b9
ranger-tools/pom.xml ec85a5f
security-admin/pom.xml 2af0cf4
src/main/assembly/admin-web.xml ca68ac6
src/main/assembly/hbase-agent.xml 3255907
src/main/assembly/hdfs-agent.xml 742ef94
src/main/assembly/hive-agent.xml 9e9df8c
src/main/assembly/kms.xml ec81ed7
src/main/assembly/knox-agent.xml c036187
src/main/assembly/plugin-kafka.xml 1e33e7f
src/main/assembly/plugin-kms.xml 57ab8c3
src/main/assembly/plugin-solr.xml 43ab738
src/main/assembly/plugin-yarn.xml b286a49
src/main/assembly/storm-agent.xml 2813f90
tagsync/pom.xml 855be38
ugsync/pom.xml 1106e30
Diff: https://reviews.apache.org/r/46397/diff/
Testing
-------
Thanks,
Colm O hEigeartaigh
Re: Review Request 46397: Some junit related improvements
Posted by Alok Lal <al...@ebay.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46397/#review129606
-----------------------------------------------------------
agents-common/pom.xml (line 57)
<https://reviews.apache.org/r/46397/#comment193043>
These aren't needed -- and should not be added. DepedencyManagement in parent was added for this case.
- Alok Lal
On April 19, 2016, 10:26 a.m., Colm O hEigeartaigh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46397/
> -----------------------------------------------------------
>
> (Updated April 19, 2016, 10:26 a.m.)
>
>
> Review request for ranger.
>
>
> Repository: ranger
>
>
> Description
> -------
>
> There are some junit related changes I'd like to make to Ranger:
>
> a) Update to 4.12
> b) Make sure junit is defined at test scope in all the modules
> c) Remove it from the assembly files, there should be no need to include test dependencies
> d) Remove it from a few shims where there are no test classes
>
>
> Diffs
> -----
>
> agents-common/pom.xml 9d0c5f1
> agents-cred/pom.xml 673dbc1
> credentialbuilder/pom.xml bf34222
> hdfs-agent/pom.xml 5918f9f
> knox-agent/pom.xml 77e27fb
> pom.xml faa3a2e
> ranger-examples/conditions-enrichers/pom.xml f5bb5fc
> ranger-hdfs-plugin-shim/pom.xml c15dfa7
> ranger-hive-plugin-shim/pom.xml 2bd18bd
> src/main/assembly/admin-web.xml ca68ac6
> src/main/assembly/hbase-agent.xml 3255907
> src/main/assembly/hdfs-agent.xml 742ef94
> src/main/assembly/hive-agent.xml 9e9df8c
> src/main/assembly/kms.xml ec81ed7
> src/main/assembly/knox-agent.xml c036187
> src/main/assembly/plugin-kafka.xml 1e33e7f
> src/main/assembly/plugin-kms.xml 57ab8c3
> src/main/assembly/plugin-solr.xml 43ab738
> src/main/assembly/plugin-yarn.xml b286a49
> src/main/assembly/storm-agent.xml 2813f90
>
> Diff: https://reviews.apache.org/r/46397/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Colm O hEigeartaigh
>
>