[GitHub] jeongyooneo commented on a change in pull request #27: [NEMO-49] Replace failed executor with a new executor

[GitBox <gi...@apache.org>]

jeongyooneo commented on a change in pull request #27: [NEMO-49] Replace failed executor with a new executor
URL: https://github.com/apache/incubator-nemo/pull/27#discussion_r192936650
 
 

 ##########
 File path: runtime/master/src/main/java/edu/snu/nemo/runtime/master/resource/ContainerManager.java
 ##########
 @@ -181,6 +190,21 @@ public void onContainerAllocated(final String executorId, final AllocatedEvaluat
     return Optional.of(executorRepresenter);
   }
 
+  /**
+   * @param failedEvaluatorId of the failed evaluator
+   * @return the resource specification of the failed evaluator
+   */
+  public ResourceSpecification onContainerFailed(final String failedEvaluatorId) {
+    final ResourceSpecification resourceSpecification = evaluatorIdToResourceSpec.remove(failedEvaluatorId);
+    if (resourceSpecification == null) {
+      throw new IllegalStateException(failedEvaluatorId + " not in " + evaluatorIdToResourceSpec);
+    }
+
+    // Re-acquire a new container using the failed container's resource spec
 
 Review comment:
   Maybe move this to the function comment?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services