You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by kxepal <gi...@git.apache.org> on 2015/10/07 17:49:11 UTC
[GitHub] couchdb pull request: Fix git VSN on build release
GitHub user kxepal opened a pull request:
https://github.com/apache/couchdb/pull/355
Fix git VSN on build release
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kxepal/couchdb fix-vsn-git
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb/pull/355.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #355
----
commit d12be23d6db83f4454f6d3f7a769d520a04ffe20
Author: Alexander Shorin <kx...@apache.org>
Date: 2015-10-07T15:47:16Z
Fix git VSN on build release
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb pull request: Fix git VSN on build release
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb/pull/355#issuecomment-146270424
Good. Landed. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb pull request: Fix git VSN on build release
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb/pull/355#issuecomment-146262082
@janl @rnewson updated PR with _correct_ vsn fix (:
I don't like `set +e` `set -e` around `grep ... | xargs sed ...`, but didn't found any clever way to not have script fail for apps which already provides not-git vsn. Thoughts?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb pull request: Fix git VSN on build release
Posted by rnewson <gi...@git.apache.org>.
Github user rnewson commented on the pull request:
https://github.com/apache/couchdb/pull/355#issuecomment-146269146
+1, we can always tidy later when inspiration strikes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb pull request: Fix git VSN on build release
Posted by janl <gi...@git.apache.org>.
Github user janl commented on the pull request:
https://github.com/apache/couchdb/pull/355#issuecomment-146241173
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb pull request: Fix git VSN on build release
Posted by rnewson <gi...@git.apache.org>.
Github user rnewson commented on a diff in the pull request:
https://github.com/apache/couchdb/pull/355#discussion_r41409493
--- Diff: build-aux/couchdb-build-release.sh ---
@@ -23,6 +23,7 @@ cd src/
for repo in *; do
cd $repo
+ grep -rl '{vsn, git}' | xargs sed -i "s/{vsn, git}/{vsn, \"${VERSION}-dev\"}/"
--- End diff --
hm, I think just the value of `git describe --always --tags`. the $VERSION value should be in the tarball file name and in the GET / welcome message.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb pull request: Fix git VSN on build release
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on a diff in the pull request:
https://github.com/apache/couchdb/pull/355#discussion_r41410082
--- Diff: build-aux/couchdb-build-release.sh ---
@@ -23,6 +23,7 @@ cd src/
for repo in *; do
cd $repo
+ grep -rl '{vsn, git}' | xargs sed -i "s/{vsn, git}/{vsn, \"${VERSION}-dev\"}/"
--- End diff --
ok
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb pull request: Fix git VSN on build release
Posted by rnewson <gi...@git.apache.org>.
Github user rnewson commented on a diff in the pull request:
https://github.com/apache/couchdb/pull/355#discussion_r41407800
--- Diff: build-aux/couchdb-build-release.sh ---
@@ -23,6 +23,7 @@ cd src/
for repo in *; do
cd $repo
+ grep -rl '{vsn, git}' | xargs sed -i "s/{vsn, git}/{vsn, \"${VERSION}-dev\"}/"
--- End diff --
can we grab the actual value here? For users of couchdb 2.0, 2.1, etc, they won't see or care about these values, but other users, like Cloudant, will make releases that only change some applications, so showing the actual git value will help. Specifically, the output of `git describe --always --tags` within that directory.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb pull request: Fix git VSN on build release
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on a diff in the pull request:
https://github.com/apache/couchdb/pull/355#discussion_r41408292
--- Diff: build-aux/couchdb-build-release.sh ---
@@ -23,6 +23,7 @@ cd src/
for repo in *; do
cd $repo
+ grep -rl '{vsn, git}' | xargs sed -i "s/{vsn, git}/{vsn, \"${VERSION}-dev\"}/"
--- End diff --
Sure. So: ${VERSION}-`git describe --always --tags` ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb pull request: Fix git VSN on build release
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/couchdb/pull/355
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---