You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by ygy <gi...@git.apache.org> on 2015/08/13 15:57:53 UTC

[GitHub] incubator-brooklyn pull request: (BROOKLYN-162) Package rename: so...

GitHub user ygy opened a pull request:

    https://github.com/apache/incubator-brooklyn/pull/821

    (BROOKLYN-162) Package rename: software/messaging

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ygy/incubator-brooklyn refactor/package-rename-messaging

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-brooklyn/pull/821.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #821
    
----
commit e1f661ba79157bebbd4da5796b07d9cb0a789f89
Author: Yavor Yanchev <ya...@yanchev.com>
Date:   2015-08-13T13:54:25Z

    (BROOKLYN-162) Package rename: software/messaging

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: (BROOKLYN-162) Package rename: so...

Posted by CMoH <gi...@git.apache.org>.
Github user CMoH commented on the pull request:

    https://github.com/apache/incubator-brooklyn/pull/821#issuecomment-131031828
  
    Seems we have both performed the rename on the same packages (see PR #820)
    
    From my quick read it seems you have missed some classpath://brooklyn/entity/messaging references within the default configkeys. At the same time, I failed to update the yamls in brooklyn-launcher.
    
    I guess merging both PRs will bring in the good stuff from both.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: (BROOKLYN-162) Package rename: so...

Posted by ygy <gi...@git.apache.org>.
Github user ygy closed the pull request at:

    https://github.com/apache/incubator-brooklyn/pull/821


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: (BROOKLYN-162) Package rename: so...

Posted by ygy <gi...@git.apache.org>.
Github user ygy commented on the pull request:

    https://github.com/apache/incubator-brooklyn/pull/821#issuecomment-131034574
  
    Closing this PR, because 'software/messaging' already renamed in #820 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---