You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bigtop.apache.org by "Rajendra (JIRA)" <ji...@apache.org> on 2015/03/10 22:15:38 UTC
[jira] [Updated] (BIGTOP-1703) Limt override of JAVA_OPTS in
install_solr.sh to cause minimal side-effects
[ https://issues.apache.org/jira/browse/BIGTOP-1703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rajendra updated BIGTOP-1703:
-----------------------------
Attachment: (was: 0001-Fix-install_solr.sh-to-avoid-unnecessary-overrides-t.patch)
> Limt override of JAVA_OPTS in install_solr.sh to cause minimal side-effects
> ---------------------------------------------------------------------------
>
> Key: BIGTOP-1703
> URL: https://issues.apache.org/jira/browse/BIGTOP-1703
> Project: Bigtop
> Issue Type: Bug
> Reporter: Rajendra
> Assignee: Rajendra
>
> The following line in https://github.com/apache/bigtop/blob/master/bigtop-packages/src/common/solr/install_solr.sh#L273
> # FIXME: for some reason catalina doesn't use CATALINA_OPTS for stop action
> # and thus doesn't know the admin port
> export JAVA_OPTS="$CATALINA_OPTS"
> appears to have been added so that "service solr-server stop" would work correctly. I see a couple of problems with this:
> 1. This overwrites JAVA_OPTS even when we are not trying to stop the service (e.g. when we do a (service solr-server start" )
> 2. If JAVA_OPTS is already set to something useful we will be overriding it
> I am proposing that we change it to something like
> if [ "$1" = "stop" ] ; then
> export JAVA_OPTS="$JAVA_OPTS $CATALINA_OPTS"
> fi
> so that we minimize changes to JAVA_OPTS
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)