You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/05/06 20:24:00 UTC

[GitHub] [airflow] mik-laj commented on a change in pull request #8742: Avoid color info in response of /dag_stats & /task_stats

mik-laj commented on a change in pull request #8742:
URL: https://github.com/apache/airflow/pull/8742#discussion_r421069212



##########
File path: airflow/www/views.py
##########
@@ -353,6 +356,7 @@ def get_int_arg(value, default=0):
                                            status=arg_status_filter if arg_status_filter else None),
             num_runs=num_runs,
             tags=tags,
+            state_color=state_color_mapping,

Review comment:
       Hi. Would you like to add a test that will check if the correct value was passed to the template? A method has been added today that makes it easy. I think it's worth gradually extending this idea to other tests to increase the confidence of the Web UI tests.
   https://github.com/apache/airflow/pull/8505




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org