You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@taverna.apache.org by Hiteshgautam01 <gi...@git.apache.org> on 2018/06/15 10:43:46 UTC
[GitHub] incubator-taverna-mobile pull request #86: Added announce. and favWorkflow p...
GitHub user Hiteshgautam01 opened a pull request:
https://github.com/apache/incubator-taverna-mobile/pull/86
Added announce. and favWorkflow presenter Tests and Bug Fixes in Announcements
Please make sure these boxes are checked before submitting your pull request - thanks!
- [ ] Apply the `AndroidStyle.xml` style template to your code in Android Studio.
- [ ] Run the checks with `./gradlew check` to make sure you didn't break anything
- [ ] If you have multiple commits please combine them into one commit by squashing them.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Hiteshgautam01/incubator-taverna-mobile AddAnnouce
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-taverna-mobile/pull/86.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #86
----
commit 5d8a40a5a9c899b2ae0e25076ab56ea5ebb3a061
Author: Hitesh Gautam <ga...@...>
Date: 2018-06-15T10:34:47Z
Added announce. and favWorkflow presenter Tests and Bug Fixes in Announcements
----
---
[GitHub] incubator-taverna-mobile pull request #86: Added announce. and favWorkflow p...
Posted by Hiteshgautam01 <gi...@git.apache.org>.
Github user Hiteshgautam01 commented on a diff in the pull request:
https://github.com/apache/incubator-taverna-mobile/pull/86#discussion_r195900202
--- Diff: app/src/main/java/org/apache/taverna/mobile/ui/anouncements/AnnouncementPresenter.java ---
@@ -62,7 +62,6 @@ public void detachView() {
public void loadAllAnnouncement(int pageNumber) {
checkViewAttached();
- getMvpView().showProgressbar(true);
--- End diff --
While announcements are loading, due to this we can see two progress bar at the same time. You can see in this video:- https://drive.google.com/file/d/1GaAdVFM7PGhusLZizwuAo2rIBD2Zj4ly/view?usp=sharing
So, I removed one progress bar in loadAllAnnouncement.
---
[GitHub] incubator-taverna-mobile pull request #86: Added announce. and favWorkflow p...
Posted by sagar15795 <gi...@git.apache.org>.
Github user sagar15795 commented on a diff in the pull request:
https://github.com/apache/incubator-taverna-mobile/pull/86#discussion_r195907124
--- Diff: app/src/main/java/org/apache/taverna/mobile/ui/anouncements/AnnouncementPresenter.java ---
@@ -62,7 +62,6 @@ public void detachView() {
public void loadAllAnnouncement(int pageNumber) {
checkViewAttached();
- getMvpView().showProgressbar(true);
--- End diff --
Nice!
---
[GitHub] incubator-taverna-mobile pull request #86: Added announce. and favWorkflow p...
Posted by sagar15795 <gi...@git.apache.org>.
Github user sagar15795 commented on a diff in the pull request:
https://github.com/apache/incubator-taverna-mobile/pull/86#discussion_r195899165
--- Diff: app/src/main/java/org/apache/taverna/mobile/ui/anouncements/AnnouncementPresenter.java ---
@@ -62,7 +62,6 @@ public void detachView() {
public void loadAllAnnouncement(int pageNumber) {
checkViewAttached();
- getMvpView().showProgressbar(true);
--- End diff --
why have you removed this line?
---
[GitHub] incubator-taverna-mobile pull request #86: Added announce. and favWorkflow p...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-taverna-mobile/pull/86
---