You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/06/13 01:11:16 UTC

[GitHub] [incubator-mxnet] leezu edited a comment on pull request #18204: Disable -DUSE_TVM_OP on GPU builds

leezu edited a comment on pull request #18204:
URL: https://github.com/apache/incubator-mxnet/pull/18204#issuecomment-643546626


   Thank you @jinboci for fixing the issue! Reverting this PR will indeed re-enable the previous test setup, but there may be some conflicts during the revert due to subsequent changes to the CI. You can try it though. 
   
   Instead of reverting, my recommendation is to take a look at what tests this PR has removed and think about what the best strategy for testing the TVM_OP feature would be. For example, we can consider to test it only on the CentOS system tests or only on the Ubuntu system tests. But maybe this is not ideal. Do you have any recommendation about the best testing strategy?
   
   Sorry for the late response.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org