[jira] [Commented] (HBASE-4326) Tests that use HBaseTestingUtility.startMiniCluster(n) should shutdown with HBaseTestingUtility.shutdownMiniCluster.

["Jonathan Hsieh (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-4326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13095727#comment-13095727 ] 

Jonathan Hsieh commented on HBASE-4326:
---------------------------------------

Tests on 0.90 branch that use the wrong convention:

TestMultiParallel (UTIL.getMiniHBaseCluster().shutdown();)
TestRestartCluster (starts but doesn't close on some tests)
TestHLog (starts but doesn't cleanup)
TestMasterRestartAfterDisablingTable (start but no cleanup)
TestHBaseTestingUtility.testMiniCluster() (doesn't cleanup after itself)
TestImportTsv


> Tests that use HBaseTestingUtility.startMiniCluster(n) should shutdown with HBaseTestingUtility.shutdownMiniCluster.
> --------------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-4326
>                 URL: https://issues.apache.org/jira/browse/HBASE-4326
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.90.4
>            Reporter: Jonathan Hsieh
>
> Most tests that use mini clusters use this pattern
> {code}
>  private final static HBaseTestingUtility UTIL = new HBaseTestingUtility();
>   @BeforeClass
>   public static void beforeClass() throws Exception {
>     UTIL.startMiniCluster(1);
>   }
>   @AfterClass
>   public static void afterClass() throws IOException {
>     UTIL.shutdownMiniCluster();
>   }
> {code}
> Some tests (like hbase-4269)
> {code}
>   @BeforeClass
>   public static void beforeClass() throws Exception {
>     UTIL.startMiniCluster(1);
>   }
>   @AfterClass
>   public static void afterClass() throws IOException {
>     UTIL.getMiniCluster().shutdown();
>     // or UTIL.shutdownMiniHBaseCluster();
>     // and likely others.
>   }
> {code}
> There is a difference between the two shutdown -- the former deletes files created during the tests while the latter does not.  This funny state persisting (zk or hbase/mr data) may be the cause of strange inter-testcase problems when full suites are run.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira