You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by hmcl <gi...@git.apache.org> on 2017/02/22 17:27:26 UTC
[GitHub] storm pull request #1958: STORM-2374: Storm Kafka Client Test Topologies Mus...
GitHub user hmcl opened a pull request:
https://github.com/apache/storm/pull/1958
STORM-2374: Storm Kafka Client Test Topologies Must be Serializable
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hmcl/storm-apache 1.x-branch_STORM-2374_TpSerial
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/1958.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1958
----
commit 07cd90e1e238642e5ebbecad804e6fd655aa5573
Author: Hugo Louro <hm...@gmail.com>
Date: 2017-02-22T16:55:12Z
STORM-2374: Storm Kafka Client Test Topologies Must be Serializable
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #1958: STORM-2374: Storm Kafka Client Test Topologies Mus...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1958#discussion_r102534351
--- Diff: external/storm-kafka-client/src/test/java/org/apache/storm/kafka/spout/test/KafkaSpoutTopologyMainNamedTopics.java ---
@@ -96,13 +98,6 @@ protected StormTopology getTopologyKafkaSpout() {
return tp.createTopology();
}
- public static Func<ConsumerRecord<String, String>, List<Object>> TOPIC_PART_OFF_KEY_VALUE_FUNC = new Func<ConsumerRecord<String, String>, List<Object>>() {
--- End diff --
I am really confused how this could cause serialization problems. If this really is an issue we need to update the docs too.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #1958: STORM-2374: Storm Kafka Client Test Topologies Mus...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/1958
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1958: STORM-2374: Storm Kafka Client Test Topologies Must be Se...
Posted by hmcl <gi...@git.apache.org>.
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/1958
@revans2 done. @ptgoetz this should be ready to merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1958: STORM-2374: Storm Kafka Client Test Topologies Must be Se...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1958
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1958: STORM-2374: Storm Kafka Client Test Topologies Must be Se...
Posted by ptgoetz <gi...@git.apache.org>.
Github user ptgoetz commented on the issue:
https://github.com/apache/storm/pull/1958
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---