[GitHub] [incubator-doris] zhannngchen commented on a diff in pull request #10043: [optimize](compaction) optimize cu compaction policy in pick rowset

[GitBox <gi...@apache.org>]

zhannngchen commented on code in PR #10043:
URL: https://github.com/apache/incubator-doris/pull/10043#discussion_r893442569


##########
be/src/olap/cumulative_compaction_policy.cpp:
##########
@@ -32,10 +32,11 @@ SizeBasedCumulativeCompactionPolicy::SizeBasedCumulativeCompactionPolicy(
           _size_based_promotion_ratio(size_based_promotion_ratio),
           _size_based_promotion_min_size(size_based_promotion_min_size),
           _size_based_compaction_lower_bound_size(size_based_compaction_lower_bound_size) {
-    // init _levels by divide 2 between size_based_promotion_size and size_based_compaction_lower_bound_size
-    int64_t i_size = size_based_promotion_size / 2;
+    // init _levels by divide 2 between size_based_compaction_lower_bound_size and 1K
+    // cu compaction handle file size less then size_based_compaction_lower_bound_size
+    int64_t i_size = size_based_compaction_lower_bound_size / 2;
 
-    while (i_size >= size_based_compaction_lower_bound_size) {
+    while (i_size >= 1024) {

Review Comment:
   This value should be configurable?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org