You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Attila Doroszlai <ad...@hortonworks.com> on 2017/05/16 17:32:50 UTC
Review Request 59315: AMBARI-21035. Integrate ClusterService with
Swagger (adoroszlai)
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59315/
-----------------------------------------------------------
Review request for Ambari, Balázs Bence Sári, Jaimin Jetly, Jayush Luniya, Sumit Mohanty, and Sebastian Toader.
Bugs: AMBARI-21035
https://issues.apache.org/jira/browse/AMBARI-21035
Repository: ambari
Description
-------
* documented API (except subresources)
* renamed some methods to avoid conflict between ClusterService and ServiceService
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterService.java 55776332b4835d81968e5fb875a8d22f13b45605
ambari-server/src/main/java/org/apache/ambari/server/api/services/HostService.java e50d70f728698b2633a6afc2f259ae6eb677bd84
ambari-server/src/main/java/org/apache/ambari/server/api/services/ServiceService.java 27de0b425c9a87eee53c0643fc8f277d232e3629
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 4c8154e82be1296e6c2c0dee7bdb6c44487c4e0b
ambari-server/src/main/java/org/apache/ambari/server/controller/ClusterArtifactRequest.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/controller/ClusterArtifactResponse.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/controller/ClusterRequest.java 4d4fd59515e7f63a9cf201b2cdbeb25197dd0d69
ambari-server/src/main/java/org/apache/ambari/server/controller/ClusterResponse.java b89bd457eeedf0801db6d8f12263ef5688367187
ambari-server/src/main/java/org/apache/ambari/server/controller/ClusterServiceArtifactRequest.java ac37c0f26e32f14faf7a85982a69e04d78241d17
ambari-server/src/main/java/org/apache/ambari/server/controller/ClusterServiceArtifactResponse.java 29b8c94084f49887d5264fb8117e2cf203bba0c4
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ArtifactResourceProvider.java a6a731c2714b3ada1b28031dd4940e49b660f595
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterResourceProvider.java ae17de41f8aafd2a340f824dc2a2cb5f1ab8c8aa
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ProvisionClusterRequest.java 1a14b016c097d9142e9d3bd844c0c01be5dece12
ambari-server/src/test/java/org/apache/ambari/server/api/services/ClusterServiceTest.java cfc43f5d87759d1c90be52c9ced9bfe2d7fb05c0
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java d613a2e5eff053017b407b4f67948fd44e5512fc
ambari-server/src/test/java/org/apache/ambari/server/controller/ClusterRequestTest.java 084e36b8b62f5b6c7302d990e9d21dd55da3cf2d
ambari-server/src/test/java/org/apache/ambari/server/controller/ClusterResponseTest.java cfb2611d98f6b8adb2b1d103bf549258a33c61b4
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterResourceProviderTest.java 49127d82742e59af23c81400010c02be1b179bc3
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ProvisionClusterRequestTest.java 73a80f609575f9c4b5b7f63dffe22afbaf690b9d
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java 345c463cd32a3a6411aae37c3b61aabbb5440384
Diff: https://reviews.apache.org/r/59315/diff/1/
Testing
-------
* verified generated doc
* unit tests pass, except `ServicePropertiesTest`, which fails due to [AMBARI-20443](https://issues.apache.org/jira/browse/AMBARI-20443).
Thanks,
Attila Doroszlai
Re: Review Request 59315: AMBARI-21035. Integrate ClusterService with
Swagger (adoroszlai)
Posted by Jaimin Jetly <ja...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59315/#review175126
-----------------------------------------------------------
Ship it!
Ship It!
- Jaimin Jetly
On May 16, 2017, 5:32 p.m., Attila Doroszlai wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59315/
> -----------------------------------------------------------
>
> (Updated May 16, 2017, 5:32 p.m.)
>
>
> Review request for Ambari, Balázs Bence Sári, Jaimin Jetly, Jayush Luniya, Sumit Mohanty, and Sebastian Toader.
>
>
> Bugs: AMBARI-21035
> https://issues.apache.org/jira/browse/AMBARI-21035
>
>
> Repository: ambari
>
>
> Description
> -------
>
> * documented API (except subresources)
> * renamed some methods to avoid conflict between ClusterService and ServiceService
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterService.java 55776332b4835d81968e5fb875a8d22f13b45605
> ambari-server/src/main/java/org/apache/ambari/server/api/services/HostService.java e50d70f728698b2633a6afc2f259ae6eb677bd84
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ServiceService.java 27de0b425c9a87eee53c0643fc8f277d232e3629
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 4c8154e82be1296e6c2c0dee7bdb6c44487c4e0b
> ambari-server/src/main/java/org/apache/ambari/server/controller/ClusterArtifactRequest.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/controller/ClusterArtifactResponse.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/controller/ClusterRequest.java 4d4fd59515e7f63a9cf201b2cdbeb25197dd0d69
> ambari-server/src/main/java/org/apache/ambari/server/controller/ClusterResponse.java b89bd457eeedf0801db6d8f12263ef5688367187
> ambari-server/src/main/java/org/apache/ambari/server/controller/ClusterServiceArtifactRequest.java ac37c0f26e32f14faf7a85982a69e04d78241d17
> ambari-server/src/main/java/org/apache/ambari/server/controller/ClusterServiceArtifactResponse.java 29b8c94084f49887d5264fb8117e2cf203bba0c4
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ArtifactResourceProvider.java a6a731c2714b3ada1b28031dd4940e49b660f595
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterResourceProvider.java ae17de41f8aafd2a340f824dc2a2cb5f1ab8c8aa
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ProvisionClusterRequest.java 1a14b016c097d9142e9d3bd844c0c01be5dece12
> ambari-server/src/test/java/org/apache/ambari/server/api/services/ClusterServiceTest.java cfc43f5d87759d1c90be52c9ced9bfe2d7fb05c0
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java d613a2e5eff053017b407b4f67948fd44e5512fc
> ambari-server/src/test/java/org/apache/ambari/server/controller/ClusterRequestTest.java 084e36b8b62f5b6c7302d990e9d21dd55da3cf2d
> ambari-server/src/test/java/org/apache/ambari/server/controller/ClusterResponseTest.java cfb2611d98f6b8adb2b1d103bf549258a33c61b4
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterResourceProviderTest.java 49127d82742e59af23c81400010c02be1b179bc3
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ProvisionClusterRequestTest.java 73a80f609575f9c4b5b7f63dffe22afbaf690b9d
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java 345c463cd32a3a6411aae37c3b61aabbb5440384
>
>
> Diff: https://reviews.apache.org/r/59315/diff/1/
>
>
> Testing
> -------
>
> * verified generated doc
> * unit tests pass, except `ServicePropertiesTest`, which fails due to [AMBARI-20443](https://issues.apache.org/jira/browse/AMBARI-20443).
>
>
> Thanks,
>
> Attila Doroszlai
>
>
Re: Review Request 59315: AMBARI-21035. Integrate ClusterService with
Swagger (adoroszlai)
Posted by Sebastian Toader <st...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59315/#review175217
-----------------------------------------------------------
Ship it!
Ship It!
- Sebastian Toader
On May 16, 2017, 7:32 p.m., Attila Doroszlai wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59315/
> -----------------------------------------------------------
>
> (Updated May 16, 2017, 7:32 p.m.)
>
>
> Review request for Ambari, Balázs Bence Sári, Jaimin Jetly, Jayush Luniya, Sumit Mohanty, and Sebastian Toader.
>
>
> Bugs: AMBARI-21035
> https://issues.apache.org/jira/browse/AMBARI-21035
>
>
> Repository: ambari
>
>
> Description
> -------
>
> * documented API (except subresources)
> * renamed some methods to avoid conflict between ClusterService and ServiceService
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterService.java 55776332b4835d81968e5fb875a8d22f13b45605
> ambari-server/src/main/java/org/apache/ambari/server/api/services/HostService.java e50d70f728698b2633a6afc2f259ae6eb677bd84
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ServiceService.java 27de0b425c9a87eee53c0643fc8f277d232e3629
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 4c8154e82be1296e6c2c0dee7bdb6c44487c4e0b
> ambari-server/src/main/java/org/apache/ambari/server/controller/ClusterArtifactRequest.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/controller/ClusterArtifactResponse.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/controller/ClusterRequest.java 4d4fd59515e7f63a9cf201b2cdbeb25197dd0d69
> ambari-server/src/main/java/org/apache/ambari/server/controller/ClusterResponse.java b89bd457eeedf0801db6d8f12263ef5688367187
> ambari-server/src/main/java/org/apache/ambari/server/controller/ClusterServiceArtifactRequest.java ac37c0f26e32f14faf7a85982a69e04d78241d17
> ambari-server/src/main/java/org/apache/ambari/server/controller/ClusterServiceArtifactResponse.java 29b8c94084f49887d5264fb8117e2cf203bba0c4
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ArtifactResourceProvider.java a6a731c2714b3ada1b28031dd4940e49b660f595
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterResourceProvider.java ae17de41f8aafd2a340f824dc2a2cb5f1ab8c8aa
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ProvisionClusterRequest.java 1a14b016c097d9142e9d3bd844c0c01be5dece12
> ambari-server/src/test/java/org/apache/ambari/server/api/services/ClusterServiceTest.java cfc43f5d87759d1c90be52c9ced9bfe2d7fb05c0
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java d613a2e5eff053017b407b4f67948fd44e5512fc
> ambari-server/src/test/java/org/apache/ambari/server/controller/ClusterRequestTest.java 084e36b8b62f5b6c7302d990e9d21dd55da3cf2d
> ambari-server/src/test/java/org/apache/ambari/server/controller/ClusterResponseTest.java cfb2611d98f6b8adb2b1d103bf549258a33c61b4
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterResourceProviderTest.java 49127d82742e59af23c81400010c02be1b179bc3
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ProvisionClusterRequestTest.java 73a80f609575f9c4b5b7f63dffe22afbaf690b9d
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java 345c463cd32a3a6411aae37c3b61aabbb5440384
>
>
> Diff: https://reviews.apache.org/r/59315/diff/1/
>
>
> Testing
> -------
>
> * verified generated doc
> * unit tests pass, except `ServicePropertiesTest`, which fails due to [AMBARI-20443](https://issues.apache.org/jira/browse/AMBARI-20443).
>
>
> Thanks,
>
> Attila Doroszlai
>
>