You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2022/02/08 19:03:20 UTC
[GitHub] [solr] risdenk opened a new pull request #615: SOLR-15992: Globally forbid and exclude known bad dependencies
risdenk opened a new pull request #615:
URL: https://github.com/apache/solr/pull/615
https://issues.apache.org/jira/browse/SOLR-15992
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] dsmiley commented on a change in pull request #615: SOLR-15992: Globally forbid and exclude known bad dependencies
Posted by GitBox <gi...@apache.org>.
dsmiley commented on a change in pull request #615:
URL: https://github.com/apache/solr/pull/615#discussion_r802615281
##########
File path: gradle/hacks/global-exclude-dependencies.gradle
##########
@@ -0,0 +1,34 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+// Globally exclude known bad dependencies to ensure they aren't included in any transitive dependency.
+
+allprojects { prj ->
+ plugins.withType(JavaPlugin) {
+ configurations.all {
Review comment:
I kind of wonder if it's worth the risk. If the outcome is a ClassNotFoundException blahBlah.animalSniffer.Silliness then I think we'd find the issue quickly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] dsmiley commented on a change in pull request #615: SOLR-15992: Globally forbid and exclude known bad dependencies
Posted by GitBox <gi...@apache.org>.
dsmiley commented on a change in pull request #615:
URL: https://github.com/apache/solr/pull/615#discussion_r802615281
##########
File path: gradle/hacks/global-exclude-dependencies.gradle
##########
@@ -0,0 +1,34 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+// Globally exclude known bad dependencies to ensure they aren't included in any transitive dependency.
+
+allprojects { prj ->
+ plugins.withType(JavaPlugin) {
+ configurations.all {
Review comment:
I kind of wonder if it's worth the risk. If the outcome is a ClassNotFoundException blahBlah.animalSnipper.Silliness then I think we'd find the issue quickly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] dweiss commented on a change in pull request #615: SOLR-15992: Globally forbid and exclude known bad dependencies
Posted by GitBox <gi...@apache.org>.
dweiss commented on a change in pull request #615:
URL: https://github.com/apache/solr/pull/615#discussion_r802665266
##########
File path: gradle/hacks/global-exclude-dependencies.gradle
##########
@@ -0,0 +1,34 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+// Globally exclude known bad dependencies to ensure they aren't included in any transitive dependency.
+
+allprojects { prj ->
+ plugins.withType(JavaPlugin) {
+ configurations.all {
Review comment:
> I kind of wonder if it's worth the risk. If the outcome is a ClassNotFoundException blahBlah.animalSniffer.Silliness then I think we'd find the issue quickly.
The outcome is unpredictable. Depends what the configuration you're excluding stuff from is used for. Try afterEvaluate {configurations.all { println it } } and you'll see how many there are in each project.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] risdenk commented on pull request #615: SOLR-15992: Globally forbid and exclude known bad dependencies
Posted by GitBox <gi...@apache.org>.
risdenk commented on pull request #615:
URL: https://github.com/apache/solr/pull/615#issuecomment-1033897609
@dweiss can you take a look at the fix in 10c9a66 - I fixed `jar-checks.gradle` to not override the `excludeRules` but instead to combine them. This looks to work when run through a debugger.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] risdenk commented on pull request #615: SOLR-15992: Globally forbid and exclude known bad dependencies
Posted by GitBox <gi...@apache.org>.
risdenk commented on pull request #615:
URL: https://github.com/apache/solr/pull/615#issuecomment-1034082501
No worries Dawid - Appreciate the help and pointers!
@janhoy / @dsmiley any other comments/concerns/critiques/criticisms?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] risdenk closed pull request #615: SOLR-15992: Globally forbid and exclude known bad dependencies
Posted by GitBox <gi...@apache.org>.
risdenk closed pull request #615:
URL: https://github.com/apache/solr/pull/615
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] risdenk commented on a change in pull request #615: SOLR-15992: Globally forbid and exclude known bad dependencies
Posted by GitBox <gi...@apache.org>.
risdenk commented on a change in pull request #615:
URL: https://github.com/apache/solr/pull/615#discussion_r802643386
##########
File path: gradle/hacks/global-exclude-dependencies.gradle
##########
@@ -0,0 +1,34 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+// Globally exclude known bad dependencies to ensure they aren't included in any transitive dependency.
+
+allprojects { prj ->
+ plugins.withType(JavaPlugin) {
+ configurations.all {
Review comment:
> Don't exclude it from all configurations. Exclude these from only those configurations that are created by the java plugin.
@dweiss so I think that is what is being done here at least that is what was intended. From what I could tell it met that goal, but I could be mistaken.
I found that configurations.all at least inside a project `build.gradle` will only apply to that project and not any others (see some of the `configurations.all` removals in this PR). So I want to make sure it applies to all Java projects.
Is there another way to structure this to meet this intended goal?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] dweiss commented on pull request #615: SOLR-15992: Globally forbid and exclude known bad dependencies
Posted by GitBox <gi...@apache.org>.
dweiss commented on pull request #615:
URL: https://github.com/apache/solr/pull/615#issuecomment-1034081000
I did take a look but it's not really helping me understand why it works or whether it's correct. :( Sorry. I can't even remember where we had exclusions on that custom configuration. If it does work, I'd commit it in.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] risdenk commented on a change in pull request #615: SOLR-15992: Globally forbid and exclude known bad dependencies
Posted by GitBox <gi...@apache.org>.
risdenk commented on a change in pull request #615:
URL: https://github.com/apache/solr/pull/615#discussion_r802643386
##########
File path: gradle/hacks/global-exclude-dependencies.gradle
##########
@@ -0,0 +1,34 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+// Globally exclude known bad dependencies to ensure they aren't included in any transitive dependency.
+
+allprojects { prj ->
+ plugins.withType(JavaPlugin) {
+ configurations.all {
Review comment:
> Don't exclude it from all configurations. Exclude these from only those configurations that are created by the java plugin.
@dweiss so I think that is what is being done here at least that is what was intended. From what I could tell it met that goal, but I could be mistaken.
I found that configurations.all at least inside a project `build.gradle` will only apply to that project and not any others (see some of the `configurations.all` removals in this PR). So I want to make sure it applies to all Java projects.
Is there another way to structure this to meet this intended goal?
-------------------
Edit:
Hm thinking about it more, maybe @dweiss you are being specific about not using all and instead using implementation, testImplementation, runtimeOnly, etc specifically since the plugin could define its own configuration and we shouldn't be messing with that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] risdenk closed pull request #615: SOLR-15992: Globally forbid and exclude known bad dependencies
Posted by GitBox <gi...@apache.org>.
risdenk closed pull request #615:
URL: https://github.com/apache/solr/pull/615
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] janhoy commented on a change in pull request #615: SOLR-15992: Globally forbid and exclude known bad dependencies
Posted by GitBox <gi...@apache.org>.
janhoy commented on a change in pull request #615:
URL: https://github.com/apache/solr/pull/615#discussion_r802629921
##########
File path: gradle/hacks/global-exclude-dependencies.gradle
##########
@@ -0,0 +1,34 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+// Globally exclude known bad dependencies to ensure they aren't included in any transitive dependency.
+
+allprojects { prj ->
+ plugins.withType(JavaPlugin) {
+ configurations.all {
Review comment:
I'm not enough into how Gradle's build-time classpath (plugins etc) is isolated from the compile-time classpath that ends up in our binary distribution. The goal of these exclusions is to stop certain jars from ending up in our distro, so I'm +1 to anything that achieves that goal -- globally, without having to duplicate the exclusions everywhere.
Any updates needed in forbidden-apis?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] risdenk commented on pull request #615: SOLR-15992: Globally forbid and exclude known bad dependencies
Posted by GitBox <gi...@apache.org>.
risdenk commented on pull request #615:
URL: https://github.com/apache/solr/pull/615#issuecomment-1032985789
I'm planning to merge PR #612 first so only the one commit needs to be reviewed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] dweiss commented on a change in pull request #615: SOLR-15992: Globally forbid and exclude known bad dependencies
Posted by GitBox <gi...@apache.org>.
dweiss commented on a change in pull request #615:
URL: https://github.com/apache/solr/pull/615#discussion_r802346111
##########
File path: gradle/hacks/global-exclude-dependencies.gradle
##########
@@ -0,0 +1,34 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+// Globally exclude known bad dependencies to ensure they aren't included in any transitive dependency.
+
+allprojects { prj ->
+ plugins.withType(JavaPlugin) {
+ configurations.all {
Review comment:
Don't exclude it from all configurations. Exclude these from only those configurations that are created by the java plugin. I've talked about it a few times - you have no control over what configurations are defined by plugins; if you exclude arbitrary dependencies from these, you risk hours spending debugging why something in the build doesn't work as expected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] dweiss commented on a change in pull request #615: SOLR-15992: Globally forbid and exclude known bad dependencies
Posted by GitBox <gi...@apache.org>.
dweiss commented on a change in pull request #615:
URL: https://github.com/apache/solr/pull/615#discussion_r802663082
##########
File path: gradle/hacks/global-exclude-dependencies.gradle
##########
@@ -0,0 +1,34 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+// Globally exclude known bad dependencies to ensure they aren't included in any transitive dependency.
+
+allprojects { prj ->
+ plugins.withType(JavaPlugin) {
+ configurations.all {
Review comment:
Correct - don't use .all, use explicit names of configurations which are actually used to declare external dependencies (most of them will come from gradle's java plugin... you can define your own but typically this won't be the case).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] risdenk commented on a change in pull request #615: SOLR-15992: Globally forbid and exclude known bad dependencies
Posted by GitBox <gi...@apache.org>.
risdenk commented on a change in pull request #615:
URL: https://github.com/apache/solr/pull/615#discussion_r802688716
##########
File path: gradle/hacks/global-exclude-dependencies.gradle
##########
@@ -0,0 +1,34 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+// Globally exclude known bad dependencies to ensure they aren't included in any transitive dependency.
+
+allprojects { prj ->
+ plugins.withType(JavaPlugin) {
+ configurations.all {
Review comment:
Ok I see what Dawid meant here. I fixed this up in ca16326ce3188915fef685b0cec57b4ce7562655
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] risdenk commented on pull request #615: SOLR-15992: Globally forbid and exclude known bad dependencies
Posted by GitBox <gi...@apache.org>.
risdenk commented on pull request #615:
URL: https://github.com/apache/solr/pull/615#issuecomment-1034152942
Merged in 4a0854b64a82e29a822b262eab780ff849095392
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org