You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pegasus.apache.org by GitBox <gi...@apache.org> on 2021/07/06 07:05:35 UTC

[GitHub] [incubator-pegasus] hycdong opened a new pull request #777: feat(client): add splitting and disk insuffient error

hycdong opened a new pull request #777:
URL: https://github.com/apache/incubator-pegasus/pull/777


   [rdsn#852](https://github.com/XiaoMi/rdsn/pull/852) adds not-retry logic for c++ client while receive splitting or disk insufficient error. This pull adds those error for client and update split function test.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org


[GitHub] [incubator-pegasus] levy5307 commented on a change in pull request #777: feat(client): add splitting and disk insuffient error

Posted by GitBox <gi...@apache.org>.
levy5307 commented on a change in pull request #777:
URL: https://github.com/apache/incubator-pegasus/pull/777#discussion_r664319561



##########
File path: src/test/function_test/test_split.cpp
##########
@@ -124,12 +124,17 @@ class partition_split_test : public testing::Test
         }
     }
 
+    bool is_valid_ret(int ret)
+    {
+        return (ret == PERR_OK || ret == PERR_TIMEOUT || ret == PERR_APP_SPLITTING);
+    }
+
     void write_data_during_split()
     {
         std::string hash = splitting_hashkey_prefix + std::to_string(count_during_split);
         std::string sort = splitting_sortkey_prefix + std::to_string(count_during_split);
         auto ret = pg_client->set(hash, sort, data_value);
-        ASSERT_TRUE((ret == PERR_OK || ret == PERR_TIMEOUT));
+        ASSERT_TRUE(is_valid_ret(ret));

Review comment:
       is_valid_ret ==> is_valid




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org


[GitHub] [incubator-pegasus] levy5307 commented on a change in pull request #777: feat(client): add splitting and disk insuffient error

Posted by GitBox <gi...@apache.org>.
levy5307 commented on a change in pull request #777:
URL: https://github.com/apache/incubator-pegasus/pull/777#discussion_r664319561



##########
File path: src/test/function_test/test_split.cpp
##########
@@ -124,12 +124,17 @@ class partition_split_test : public testing::Test
         }
     }
 
+    bool is_valid_ret(int ret)
+    {
+        return (ret == PERR_OK || ret == PERR_TIMEOUT || ret == PERR_APP_SPLITTING);
+    }
+
     void write_data_during_split()
     {
         std::string hash = splitting_hashkey_prefix + std::to_string(count_during_split);
         std::string sort = splitting_sortkey_prefix + std::to_string(count_during_split);
         auto ret = pg_client->set(hash, sort, data_value);
-        ASSERT_TRUE((ret == PERR_OK || ret == PERR_TIMEOUT));
+        ASSERT_TRUE(is_valid_ret(ret));

Review comment:
       is_valid_ret ==> is_valid




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org


[GitHub] [incubator-pegasus] hycdong merged pull request #777: feat(client): add splitting and disk insuffient error

Posted by GitBox <gi...@apache.org>.
hycdong merged pull request #777:
URL: https://github.com/apache/incubator-pegasus/pull/777


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org


[GitHub] [incubator-pegasus] hycdong merged pull request #777: feat(client): add splitting and disk insuffient error

Posted by GitBox <gi...@apache.org>.
hycdong merged pull request #777:
URL: https://github.com/apache/incubator-pegasus/pull/777


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org