You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@wicket.apache.org by Martin Grigorov <mg...@apache.org> on 2018/11/25 15:55:08 UTC
Re: wicket git commit: [WICKET-6615] java8 build can be activated
using profile
On Sat, Nov 24, 2018 at 8:01 AM <so...@apache.org> wrote:
> Repository: wicket
> Updated Branches:
> refs/heads/wicket-7.x e944148c5 -> 082b1b329
>
>
> [WICKET-6615] java8 build can be activated using profile
>
>
> Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
> Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/082b1b32
> Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/082b1b32
> Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/082b1b32
>
> Branch: refs/heads/wicket-7.x
> Commit: 082b1b329abb83bad1636580002877ccde81107b
> Parents: e944148
> Author: Maxim Solodovnik <so...@gmail.com>
> Authored: Sat Nov 24 13:01:17 2018 +0700
> Committer: Maxim Solodovnik <so...@gmail.com>
> Committed: Sat Nov 24 13:01:17 2018 +0700
>
> ----------------------------------------------------------------------
> pom.xml | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
> ----------------------------------------------------------------------
>
>
> http://git-wip-us.apache.org/repos/asf/wicket/blob/082b1b32/pom.xml
> ----------------------------------------------------------------------
> diff --git a/pom.xml b/pom.xml
> index 4cd2149..b08be38 100644
> --- a/pom.xml
> +++ b/pom.xml
> @@ -1224,10 +1224,7 @@
> </build>
> </profile>
> <profile>
> - <id>doclint-java8-disable</id>
> - <activation>
> - <jdk>1.8</jdk>
> - </activation>
> + <id>java8</id>
>
This change doesn't make much sense to me.
Which version of Java 7 do you use ?
Is there a new release of JDK 7 that inroduces such breaking behavior as
the one introduced in JDK 8 ?
> <build>
> <pluginManagement>
> <plugins>
>
>
Re: wicket git commit: [WICKET-6615] java8 build can be activated
using profile
Posted by Maxim Solodovnik <so...@gmail.com>.
Hello Martin,
This is not most recent commit
Latest vertions has no "auto activation"
I list my environment it the wicket7 release VOTE
I tripple check everything using ubuntu16 tomorrow
WBR, Maxim
(from mobile, sorry for the typos)
On Sun, Nov 25, 2018, 22:55 Martin Grigorov <mgrigorov@apache.org wrote:
> On Sat, Nov 24, 2018 at 8:01 AM <so...@apache.org> wrote:
>
> > Repository: wicket
> > Updated Branches:
> > refs/heads/wicket-7.x e944148c5 -> 082b1b329
> >
> >
> > [WICKET-6615] java8 build can be activated using profile
> >
> >
> > Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
> > Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/082b1b32
> > Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/082b1b32
> > Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/082b1b32
> >
> > Branch: refs/heads/wicket-7.x
> > Commit: 082b1b329abb83bad1636580002877ccde81107b
> > Parents: e944148
> > Author: Maxim Solodovnik <so...@gmail.com>
> > Authored: Sat Nov 24 13:01:17 2018 +0700
> > Committer: Maxim Solodovnik <so...@gmail.com>
> > Committed: Sat Nov 24 13:01:17 2018 +0700
> >
> > ----------------------------------------------------------------------
> > pom.xml | 5 +----
> > 1 file changed, 1 insertion(+), 4 deletions(-)
> > ----------------------------------------------------------------------
> >
> >
> > http://git-wip-us.apache.org/repos/asf/wicket/blob/082b1b32/pom.xml
> > ----------------------------------------------------------------------
> > diff --git a/pom.xml b/pom.xml
> > index 4cd2149..b08be38 100644
> > --- a/pom.xml
> > +++ b/pom.xml
> > @@ -1224,10 +1224,7 @@
> > </build>
> > </profile>
> > <profile>
> > - <id>doclint-java8-disable</id>
> > - <activation>
> > - <jdk>1.8</jdk>
> > - </activation>
> > + <id>java8</id>
> >
>
> This change doesn't make much sense to me.
>
> Which version of Java 7 do you use ?
> Is there a new release of JDK 7 that inroduces such breaking behavior as
> the one introduced in JDK 8 ?
>
>
> > <build>
> > <pluginManagement>
> > <plugins>
> >
> >
>