You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2023/01/18 13:14:11 UTC

[GitHub] [ignite-3] ibessonov commented on a diff in pull request #1540: IGNITE-18516 "Change closure" semantic fixed when it comes to concurr…

ibessonov commented on code in PR #1540:
URL: https://github.com/apache/ignite-3/pull/1540#discussion_r1073517061


##########
modules/configuration-annotation-processor/src/main/java/org/apache/ignite/internal/configuration/processor/ConfigurationProcessor.java:
##########
@@ -518,6 +518,14 @@ private void createPojoBindings(
             }
 
             changeClsBuilder.addMethod(changeMtdBuilder.build());
+
+            if (valAnnotation == null) {

Review Comment:
   I added tests for it. I'll add a comment.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org