You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by jasper-k <gi...@git.apache.org> on 2017/12/06 20:40:18 UTC
[GitHub] nifi pull request #2326: NIFI-4675 Lifted restriction on demarcator and kafk...
GitHub user jasper-k opened a pull request:
https://github.com/apache/nifi/pull/2326
NIFI-4675 Lifted restriction on demarcator and kafka.key usage together
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
YES, NIFI-4675
- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jasper-k/apache-nifi master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2326.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2326
----
commit 9ab024b8d36b64ac40b8eda6c3e46381d4a2c3cd
Author: jknulst <jk...@hortonworks.com>
Date: 2017-12-06T20:31:57Z
NIFI-4675 Lifted restriction on demarcator and kafka.key usage together
----
---
[GitHub] nifi issue #2326: NIFI-4675 Lifted restriction on demarcator and kafka.key u...
Posted by joewitt <gi...@git.apache.org>.
Github user joewitt commented on the issue:
https://github.com/apache/nifi/pull/2326
Given your description of the user understanding the decision they're making I think I agree with you.
@markap14 what do you think?
@jasper-k we'll want to make sure kafka 10, 11, and 1 are all updated for this but lets see what mark thinks too.
Thanks for contributing and sharing your findings
---
[GitHub] nifi issue #2326: NIFI-4675 Lifted restriction on demarcator and kafka.key u...
Posted by jasper-k <gi...@git.apache.org>.
Github user jasper-k commented on the issue:
https://github.com/apache/nifi/pull/2326
@joewitt It seems to be checkstyle errors, but there is no obvious error. Any tip to setup IntelliJ to use the <checkstyleRules> embedded in the pom.xml?
---
[GitHub] nifi pull request #2326: NIFI-4675 Lifted restriction on demarcator and kafk...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/2326
---
[GitHub] nifi issue #2326: NIFI-4675 Lifted restriction on demarcator and kafka.key u...
Posted by markap14 <gi...@git.apache.org>.
Github user markap14 commented on the issue:
https://github.com/apache/nifi/pull/2326
@jasper-k @joewitt I think I am ok with this change. I do tend to expect Kafka keys to be unique because otherwise Kafka may lose the data. However, I know there are use cases where some users want to use the same key anyway, so given the apt description in the property this is probably a good improvement. Will merge to master.
---
[GitHub] nifi issue #2326: NIFI-4675 Lifted restriction on demarcator and kafka.key u...
Posted by markap14 <gi...@git.apache.org>.
Github user markap14 commented on the issue:
https://github.com/apache/nifi/pull/2326
OK tested locally and all looks good. +1 merged to master. Thanks for contributing the improvement!
---
[GitHub] nifi issue #2326: NIFI-4675 Lifted restriction on demarcator and kafka.key u...
Posted by joewitt <gi...@git.apache.org>.
Github user joewitt commented on the issue:
https://github.com/apache/nifi/pull/2326
@jasper-k the travis-ci builds show there are some contrib-check failures. Make sure you run that locally so you can see them more easily. "mvn clean install -Pcontrib-check" Please rebase to latest master, resolve the contrib-check, and force push.
---