[GitHub] [apisix-dashboard] starsz commented on a change in pull request #1421: CI: test make build

[GitBox <gi...@apache.org>]

starsz commented on a change in pull request #1421:
URL: https://github.com/apache/apisix-dashboard/pull/1421#discussion_r569918038



##########
File path: .github/workflows/make-build.yaml
##########
@@ -0,0 +1,31 @@
+name: make build
+
+on:
+  push:
+    branches:
+      - master
+  pull_request:
+    branches:
+      - master
+
+jobs:
+  web-e2e:
+    name: Frontend e2e test

Review comment:
       Emmm.The name doesn't match the behavior.

##########
File path: .github/workflows/make-build.yaml
##########
@@ -0,0 +1,31 @@
+name: make build
+
+on:
+  push:
+    branches:
+      - master
+  pull_request:
+    branches:
+      - master
+
+jobs:
+  web-e2e:
+    name: Frontend e2e test
+    runs-on: ubuntu-latest
+
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v2
+
+      - name: Setup Node.js environment
+        uses: actions/setup-node@v2.1.4
+        with:
+          node-version: 14.x
+
+      - name: Setup golang environment
+        uses: actions/setup-go@v2.1.3
+        with:
+          go-version: '1.13'
+
+      - name: make build
+        run: make build

Review comment:
       IMO. Can we put this command at the front e2e test?
   Start the manger-api by the binary instead of `go run`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org