[GitHub] [iceberg] samredai commented on a diff in pull request #5690: Python: Add CLI command to list files

[GitBox <gi...@apache.org>]

samredai commented on code in PR #5690:
URL: https://github.com/apache/iceberg/pull/5690#discussion_r961799839


##########
python/pyiceberg/cli/output.py:
##########
@@ -119,25 +124,40 @@ def describe_table(self, table: Table):
         output_table.add_row("Properties", table_properties)
         Console().print(output_table)
 
-    def describe_properties(self, properties: Properties):
+    def files(self, table: Table, io: FileIO) -> None:
+        metadata = table.metadata
+
+        snapshot_tree = Tree(f"Snapshots: {'.'.join(table.identifier)}")
+        for snapshot in metadata.snapshots:

Review Comment:
   Am I reading this correctly that listing files will list all files for all snapshots? Would it be better if it listed the files for the current snapshot only and maybe we can have a flag to include files from all historical snapshots?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org