You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2019/12/11 16:35:19 UTC
[GitHub] [camel-k] nicolaferraro commented on a change in pull request
#1127: Don't write to platform spec to allow upgrades
nicolaferraro commented on a change in pull request #1127: Don't write to platform spec to allow upgrades
URL: https://github.com/apache/camel-k/pull/1127#discussion_r356705521
##########
File path: pkg/cmd/install.go
##########
@@ -269,12 +272,8 @@ func (o *installCmdOptions) install(cobraCmd *cobra.Command, _ []string) error {
kanikoBuildCacheFlag := cobraCmd.Flags().Lookup("kaniko-build-cache")
- defaultKanikoBuildCache := true
-
if kanikoBuildCacheFlag.Changed {
platform.Spec.Build.KanikoBuildCache = &o.kanikoBuildCache
- } else {
- platform.Spec.Build.KanikoBuildCache = &defaultKanikoBuildCache
Review comment:
Yes, I've removed setting the default value in spec, because it's computed later in the platform reconcile cycle and its value is now set into the status.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services