[GitHub] [airflow] kurtqq edited a comment on issue #21252: Distinguish between marking failure/success by user and by task

[GitBox <gi...@apache.org>]

kurtqq edited a comment on issue #21252:
URL: https://github.com/apache/airflow/issues/21252#issuecomment-1031958805


   > There's an enum of task states [here](https://github.com/apache/airflow/blob/1d170f899bcc87110e55192517270ec89d511ca8/airflow/utils/state.py#L26), which we could add to, but that would imply changing the marking mechanism to e.g. `MARKED_SUCCESS` or `MARKED_FAILED` instead of `SUCCESS` or `FAILED`. Which would then break anything that depends on the task instances being one of the latter two states. That sounds like a lot bigger of a change than I am ready for...
   
   The concept of adding explicit status per each possible action is dangerous. When start this you will never hear the end of it.
   To answer of the question who did something should be stored in logs. If needed it should be displayed from the logs.
   When you know who did it you also get the answer about what he did because if a user marked task as failed clearly this is done manually so you get this way more information without adding more statuses.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org