You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/07/26 06:23:09 UTC

[GitHub] [iotdb] ericpai opened a new pull request, #6772: [IOTDB-3958] Add error logging in thread pool

ericpai opened a new pull request, #6772:
URL: https://github.com/apache/iotdb/pull/6772

   See JIRA: https://issues.apache.org/jira/browse/IOTDB-3958 .
   I refactor the WrappedCallable to make sure every task submitted to thread pool will log any uncaught exceptions.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] ericpai commented on pull request #6772: [IOTDB-3958] Add error logging in thread pool

Posted by GitBox <gi...@apache.org>.

ericpai commented on PR #6772:
URL: https://github.com/apache/iotdb/pull/6772#issuecomment-1195061152

   @HTHou @wangchao316 PTAL


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] ericpai merged pull request #6772: [IOTDB-3958] Add error logging in thread pool

Posted by GitBox <gi...@apache.org>.

ericpai merged PR #6772:
URL: https://github.com/apache/iotdb/pull/6772


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] coveralls commented on pull request #6772: [IOTDB-3958] Add error logging in thread pool

Posted by GitBox <gi...@apache.org>.

coveralls commented on PR #6772:
URL: https://github.com/apache/iotdb/pull/6772#issuecomment-1195343690

   
   [![Coverage Status](https://coveralls.io/builds/51159757/badge)](https://coveralls.io/builds/51159757)
   
   Coverage increased (+0.01%) to 43.147% when pulling **d83ae22518ab2dc942c1b40d8c8670b44bda1147 on bugfix/iotdb-3958** into **878de3a2a45421f4b8562219629d144ac3a7ba4d on master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] sonarcloud[bot] commented on pull request #6772: [IOTDB-3958] Add error logging in thread pool

Posted by GitBox <gi...@apache.org>.

sonarcloud[bot] commented on PR #6772:
URL: https://github.com/apache/iotdb/pull/6772#issuecomment-1195320335

   SonarCloud Quality Gate failed.&nbsp; &nbsp; [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate failed')](https://sonarcloud.io/dashboard?id=apache_incubator-iotdb&pullRequest=6772)
   
   [![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=6772&resolved=false&types=BUG) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=6772&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=6772&resolved=false&types=BUG)  
   [![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=6772&resolved=false&types=VULNERABILITY) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=6772&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=6772&resolved=false&types=VULNERABILITY)  
   [![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=6772&resolved=false&types=SECURITY_HOTSPOT) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=6772&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=6772&resolved=false&types=SECURITY_HOTSPOT)  
   [![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=6772&resolved=false&types=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=6772&resolved=false&types=CODE_SMELL) [6 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=6772&resolved=false&types=CODE_SMELL)
   
   [![20.7%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/0-16px.png '20.7%')](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=6772&metric=new_coverage&view=list) [20.7% Coverage](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=6772&metric=new_coverage&view=list)  
   [![27.2%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/20plus-16px.png '27.2%')](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=6772&metric=new_duplicated_lines_density&view=list) [27.2% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=6772&metric=new_duplicated_lines_density&view=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org