You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by wido <gi...@git.apache.org> on 2015/11/10 09:09:17 UTC

[GitHub] cloudstack pull request: CLOUDSTACK-8818: Use MySQL native connect...

GitHub user wido opened a pull request:

    https://github.com/apache/cloudstack/pull/1054

    CLOUDSTACK-8818: Use MySQL native connector with Python

    MySQLdb has been deprecated and is also not supported in Python 3.
    
    mysql.connector is a connector written in Python which talks the
    native MySQL protocol without any external code.
    
    https://dev.mysql.com/doc/connector-python/en/

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/wido/cloudstack CLOUDSTACK-8818

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack/pull/1054.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1054
    
----
commit 4a90b2e1124778c624a71e43bd0c3bc74733d096
Author: Wido den Hollander <wi...@widodh.nl>
Date:   2015-11-10T08:04:48Z

    CLOUDSTACK-8818: Use MySQL native connector with Python
    
    MySQLdb has been deprecated and is also not supported in Python 3.
    
    mysql.connector is a connector written in Python which talks the
    native MySQL protocol without any external code.
    
    https://dev.mysql.com/doc/connector-python/en/

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8818: Use MySQL native connect...

Posted by bhaisaab <gi...@git.apache.org>.
Github user bhaisaab commented on the pull request:

    https://github.com/apache/cloudstack/pull/1054#issuecomment-158874821
  
    LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8818: Use MySQL native connect...

Posted by swill <gi...@git.apache.org>.
Github user swill commented on the pull request:

    https://github.com/apache/cloudstack/pull/1054#issuecomment-216885592
  
    @wido can you rebase for me?  We apparently have merge conflicts now.  Thanks...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8818: Use MySQL native connect...

Posted by swill <gi...@git.apache.org>.
Github user swill commented on the pull request:

    https://github.com/apache/cloudstack/pull/1054#issuecomment-215504839
  
    I see this in the output when Marvin is installed.
    ```
    Requirement already up-to-date: mysql-connector-python>=1.1.6
    ```
    
    If I check the version I have it is: 
    ```
    # pip freeze | grep mysql-connector-python
    mysql-connector-python==1.1.6
    ```
    
    Is that appropriate or should we be updating the Marvin requirements?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8818: Use MySQL native connect...

Posted by swill <gi...@git.apache.org>.
Github user swill commented on the pull request:

    https://github.com/apache/cloudstack/pull/1054#issuecomment-215551291
  
    Running CI now.  Will have results later tonight or tomorrow...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8818: Use MySQL native connect...

Posted by wido <gi...@git.apache.org>.
Github user wido commented on the pull request:

    https://github.com/apache/cloudstack/pull/1054#issuecomment-155353598
  
    Pylint result:
    
    ```
    Global evaluation
    -----------------
    Your code has been rated at 6.48/10 (previous run: 6.48/10, +0.00)
    ```
    
    I also wrote a small test script:
    
    ```
    from db import Database
    
    db = Database(username='root', password='XXXX')
    
    try:
        db.testConnection()
        print("Succes!")
    except:
        raise
    ```
    
    The result:
    
    ```
    wido@wido-laptop:~/repos/cloudstack/python/lib/cloudutils$ python smallthin.py 
    Succes!
    wido@wido-laptop:~/repos/cloudstack/python/lib/cloudutils$
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1054: CLOUDSTACK-8818: Use MySQL native connector with Pyt...

Posted by pdion891 <gi...@git.apache.org>.
Github user pdion891 commented on the issue:

    https://github.com/apache/cloudstack/pull/1054
  
    Could it be possible the file ``debian/control`` should be updated to depend on mysql-connector-python  deb package instead of python-mysql.connector ? 
    
    I have this PR ready for the Debian side: 
    https://github.com/pdion891/cloudstack/blob/b6ca215b17b7d65fd08cf567c8b584cc76aa7e52/debian/control
    
    I'm just not sure if it's wanted to not have Debian updated to use the new driver?
    
    Regards,


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1054: CLOUDSTACK-8818: Use MySQL native connector with Pyt...

Posted by pdion891 <gi...@git.apache.org>.
Github user pdion891 commented on the issue:

    https://github.com/apache/cloudstack/pull/1054
  
    ok, thanks, I will make sure the doc reflect that. 
    
    thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8818: Use MySQL native connect...

Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the pull request:

    https://github.com/apache/cloudstack/pull/1054#issuecomment-216204074
  
    tag:mergeready


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8818: Use MySQL native connect...

Posted by wido <gi...@git.apache.org>.
Github user wido commented on the pull request:

    https://github.com/apache/cloudstack/pull/1054#issuecomment-213701028
  
    Ok, leave this PR open or closed?
    
    Keep in mind, the API of both packages is rather similar. Just the connection creating is different. Atferwards it is getting a cursor and execute.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8818: Use MySQL native connect...

Posted by swill <gi...@git.apache.org>.
Github user swill commented on the pull request:

    https://github.com/apache/cloudstack/pull/1054#issuecomment-213728252
  
    Let's leave this open for now. I want to understand what is needed to fix this project wide. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8818: Use MySQL native connect...

Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on the pull request:

    https://github.com/apache/cloudstack/pull/1054#issuecomment-160930211
  
    code lgtm but i have really no time to test this anytime soon


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1054: CLOUDSTACK-8818: Use MySQL native connector with Pyt...

Posted by wido <gi...@git.apache.org>.
Github user wido commented on the issue:

    https://github.com/apache/cloudstack/pull/1054
  
    The package is called *python-mysql.connector* in Ubuntu and Debian: http://packages.ubuntu.com/xenial/python-mysql.connector
    
    The mysql-connector-python package name is CentOS/RHEL.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8818: Use MySQL native connect...

Posted by wido <gi...@git.apache.org>.
GitHub user wido reopened a pull request:

    https://github.com/apache/cloudstack/pull/1054

    CLOUDSTACK-8818: Use MySQL native connector with Python

    MySQLdb has been deprecated and is also not supported in Python 3.
    
    mysql.connector is a connector written in Python which talks the
    native MySQL protocol without any external code.
    
    https://dev.mysql.com/doc/connector-python/en/

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/wido/cloudstack CLOUDSTACK-8818

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack/pull/1054.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1054
    
----
commit 4a90b2e1124778c624a71e43bd0c3bc74733d096
Author: Wido den Hollander <wi...@widodh.nl>
Date:   2015-11-10T08:04:48Z

    CLOUDSTACK-8818: Use MySQL native connector with Python
    
    MySQLdb has been deprecated and is also not supported in Python 3.
    
    mysql.connector is a connector written in Python which talks the
    native MySQL protocol without any external code.
    
    https://dev.mysql.com/doc/connector-python/en/

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8818: Use MySQL native connect...

Posted by wido <gi...@git.apache.org>.
Github user wido commented on the pull request:

    https://github.com/apache/cloudstack/pull/1054#issuecomment-155444641
  
    "Apache CloudStack Server" has failed says Jenkins. I don't see a failed test though?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8818: Use MySQL native connect...

Posted by bhaisaab <gi...@git.apache.org>.
Github user bhaisaab commented on the pull request:

    https://github.com/apache/cloudstack/pull/1054#issuecomment-213331800
  
    @wido we'll need to fix codebase wide mysqldb usage in python scripts and build both rpms/deb to show installation, setting up of db and setting up mgmt server works out of the box. Other than this, I'll also need to fix a python based migration script used in dynamic roles PR that also uses the current mysqldb. We'll also need to fix travis to install the new dependency and fix marvin's dbclient to use it instead of mysqldb.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8818: Use MySQL native connect...

Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on the pull request:

    https://github.com/apache/cloudstack/pull/1054#issuecomment-155456551
  
    @wido 
    Running org.apache.cloudstack.networkoffering.CreateNetworkOfferingTest
    #
    # A fatal error has been detected by the Java Runtime Environment:
    #
    SUREFIRE-859: #  SIGSEGV (0xb) at pc=0xadc1552c, pid=22362, tid=4136426304
    #
    # JRE version: 7.0_25-b15
    # Java VM: Java HotSpot(TM) Server VM (23.25-b01 mixed mode linux-x86 )
    # Problematic frame:
    # C  [libnet.so+0x352c]  _init+0x620
    #
    SUREFIRE-859: # Failed to write core dump. Core dumps have been disabled. To enable core dumping, try "ulimit -c unlimited" before starting Java again
    #
    # An error report file with more information is saved as:
    # /home/jenkins/jenkins-slave/workspace/cloudstack-pull-analysis/server/hs_err_pid22362.log
    #
    SUREFIRE-859: # If you would like to submit a bug report, please visit:
    #   http://bugreport.sun.com/bugreport/crash.jsp
    # The crash happened outside the Java Virtual Machine in native code.
    # See problematic frame for where to report the bug.
    #
    
    also see INFRA-10703 and vote for it


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1054: CLOUDSTACK-8818: Use MySQL native connector with Pyt...

Posted by wido <gi...@git.apache.org>.
Github user wido commented on the issue:

    https://github.com/apache/cloudstack/pull/1054
  
    No, it isn't indeed.
    
    ``apt-get dist-upgrade``
    
    That will show you that new dependencies are required for install and it will download them. No manual need for downloading a .deb file and installing it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8818: Use MySQL native connect...

Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the pull request:

    https://github.com/apache/cloudstack/pull/1054#issuecomment-216203992
  
    LGTM, let's merge if CI has passed; though we need to check installable packages wrt all sort of scripts using it (like cloud-setup-databases and others etc.)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8818: Use MySQL native connect...

Posted by swill <gi...@git.apache.org>.
Github user swill commented on the pull request:

    https://github.com/apache/cloudstack/pull/1054#issuecomment-215615196
  
    CI has passed.  The only issue we see is a connectivity issue I sometimes see in my environment.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8818: Use MySQL native connect...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/cloudstack/pull/1054


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1054: CLOUDSTACK-8818: Use MySQL native connector with Pyt...

Posted by karuturi <gi...@git.apache.org>.
Github user karuturi commented on the issue:

    https://github.com/apache/cloudstack/pull/1054
  
    what @pdion891 says is correct. I just tried building deb packages on ubuntu 12:04 
    Even after installing http://dev.mysql.com/downloads/connector/python/ its complaining about python mysql connector
    
    > dpkg-buildpackage -uc -us
    > dpkg-buildpackage: export CFLAGS from dpkg-buildflags (origin: vendor): -g -O2 -fstack-protector --param=ssp-buffer-size=4 -Wformat -Wformat-security
    > dpkg-buildpackage: export CPPFLAGS from dpkg-buildflags (origin: vendor): -D_FORTIFY_SOURCE=2
    > dpkg-buildpackage: export CXXFLAGS from dpkg-buildflags (origin: vendor): -g -O2 -fstack-protector --param=ssp-buffer-size=4 -Wformat -Wformat-security
    > dpkg-buildpackage: export FFLAGS from dpkg-buildflags (origin: vendor): -g -O2
    > dpkg-buildpackage: export LDFLAGS from dpkg-buildflags (origin: vendor): -Wl,-Bsymbolic-functions -Wl,-z,relro
    > dpkg-buildpackage: source package cloudstack
    > dpkg-buildpackage: source version 4.10.0-SNAPSHOT
    > dpkg-buildpackage: source changed by the Apache CloudStack project <de...@cloudstack.apache.org>
    > dpkg-buildpackage: host architecture amd64
    >  dpkg-source --before-build cloudstack
    > dpkg-checkbuilddeps: Unmet build dependencies: python-mysql.connector
    > dpkg-buildpackage: warning: Build dependencies/conflicts unsatisfied; aborting.
    > dpkg-buildpackage: warning: (Use -d flag to override.)
    
    after editing debian/control using `:%s/python-mysql.connector/mysql-connector-python/g`, it worked fine


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8818: Use MySQL native connect...

Posted by wido <gi...@git.apache.org>.
Github user wido closed the pull request at:

    https://github.com/apache/cloudstack/pull/1054


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8818: Use MySQL native connect...

Posted by wido <gi...@git.apache.org>.
Github user wido commented on the pull request:

    https://github.com/apache/cloudstack/pull/1054#issuecomment-212789949
  
    Can we already merge this one?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8818: Use MySQL native connect...

Posted by swill <gi...@git.apache.org>.
Github user swill commented on the pull request:

    https://github.com/apache/cloudstack/pull/1054#issuecomment-213413569
  
    @wido I just want to verify that the standard CI run does not have any issues.  However, @bhaisaab does bring up some good points.  We should try to fix this everywhere if we can.  I will try to do some `grep`ing today to see if I can find everywhere this is used.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8818: Use MySQL native connect...

Posted by wido <gi...@git.apache.org>.
Github user wido commented on the pull request:

    https://github.com/apache/cloudstack/pull/1054#issuecomment-160648931
  
    @borisroman @DaanHoogland Anybody else? :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8818: Use MySQL native connect...

Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the pull request:

    https://github.com/apache/cloudstack/pull/1054#issuecomment-215502330
  
    @swill for the CI you can install using pip with: (this is also in tools/travis/install.sh)
    pip install --upgrade --egg http://cdn.mysql.com/Downloads/Connector-Python/mysql-connector-python-2.0.4.zip#md5=3df394d89300db95163f17c843ef49df


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8818: Use MySQL native connect...

Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the pull request:

    https://github.com/apache/cloudstack/pull/1054#issuecomment-215392929
  
    @wido that is true, so will simply fixing the imports and usage work?
    
    I found using `git grep MySQLdb`:
    ```
    client/bindir/cloud-update-xenserver-licenses.in:import MySQLdb
    client/bindir/cloud-update-xenserver-licenses.in:       conn = MySQLdb.connect(host=host,user=username,passwd=password)
    python/lib/cloudutils/db.py:import MySQLdb
    python/lib/cloudutils/db.py:                txn = MySQLdb.Connect(host=self.host, user=self.username,
    python/lib/cloudutils/db.py:                txn = MySQLdb.Connect(host=self.host, user=self.username,
    python/lib/cloudutils/db.py:                db = MySQLdb.Connect(host=self.host, user=self.username,
    python/lib/cloudutils/db.py:                db = MySQLdb.Connect(host=self.host, user=self.username,
    setup/bindir/cloud-migrate-databases.in:import MySQLdb
    setup/bindir/cloud-migrate-databases.in:                self.conn = MySQLdb.connect(host=self.host,
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1054: CLOUDSTACK-8818: Use MySQL native connector with Pyt...

Posted by wido <gi...@git.apache.org>.
Github user wido commented on the issue:

    https://github.com/apache/cloudstack/pull/1054
  
    Why is t hat required? The package is also available for 12.04: http://packages.ubuntu.com/precise/python-mysql.connector


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8818: Use MySQL native connect...

Posted by swill <gi...@git.apache.org>.
Github user swill commented on the pull request:

    https://github.com/apache/cloudstack/pull/1054#issuecomment-212981219
  
    I need one more LGTM for this one and I would like to run CI to make sure nothing breaks.  Otherwise I think this is in a good place.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8818: Use MySQL native connect...

Posted by wido <gi...@git.apache.org>.
Github user wido commented on the pull request:

    https://github.com/apache/cloudstack/pull/1054#issuecomment-156067993
  
    @DaanHoogland Thanks! Now, that failure has nothing to do with this Python code :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1054: CLOUDSTACK-8818: Use MySQL native connector with Pyt...

Posted by pdion891 <gi...@git.apache.org>.
Github user pdion891 commented on the issue:

    https://github.com/apache/cloudstack/pull/1054
  
    Are you saying it's not like CentOS which require to install mysq-connector-python from mysql repo [1], on ubuntu the package would have not been renamed ?
    
    [1] https://github.com/cloudops/cloudstack-docs-rn/blob/4.9/source/upgrade/_mysql_connector.rst



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8818: Use MySQL native connect...

Posted by wido <gi...@git.apache.org>.
Github user wido commented on the pull request:

    https://github.com/apache/cloudstack/pull/1054#issuecomment-217010122
  
    Done @rhtyd !


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8818: Use MySQL native connect...

Posted by wido <gi...@git.apache.org>.
Github user wido commented on the pull request:

    https://github.com/apache/cloudstack/pull/1054#issuecomment-213298570
  
    @swill I don't exactly know how to test this with CI. I verified it with the test script I created.
    
    Don't know how we can automate this in CI.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8818: Use MySQL native connect...

Posted by swill <gi...@git.apache.org>.
Github user swill commented on the pull request:

    https://github.com/apache/cloudstack/pull/1054#issuecomment-215472985
  
    So are we happy with the state of this?  How should I adjust my CI to validate this fix?  
    
    I currently have: 
    ```
    yum -y install maven tomcat mkisofs python-paramiko jakarta-commons-daemon-jsvc jsvc ws-commons-util genisoimage gcc python MySQL-python openssh-clients wget git python-ecdsa bzip2 python-setuptools mariadb-server mariadb python-devel vim nfs-utils screen setroubleshoot openssh-askpass java-1.7.0-openjdk-devel.x86_64 rpm-build rubygems nc
    yum -y install http://mirror.karneval.cz/pub/linux/fedora/epel/epel-release-latest-7.noarch.rpm
    yum --enablerepo=epel -y install sshpass mariadb mysql-connector-python
    ```
    
    and when marvin is installed:
    
    ```
    pip install --upgrade tools/marvin/dist/Marvin-*.tar.gz --allow-external mysql-connector-python
    ```
    
    But `--allow-external` has been deprecated, so I don't actually think that does anything anymore...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8818: Use MySQL native connect...

Posted by wido <gi...@git.apache.org>.
Github user wido commented on the pull request:

    https://github.com/apache/cloudstack/pull/1054#issuecomment-215391701
  
    @swill @rhtyd: I looked through all the code and fixed it. Is was just two more scripts.
    
    <pre>wido@wido-desktop:~/repos/cloudstack$ grep -R "MySQLdb" *
    wido@wido-desktop:~/repos/cloudstack$</pre>
    
    API-wise the syntax is the same between MySQLdb and this native connector.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8818: Use MySQL native connect...

Posted by wido <gi...@git.apache.org>.
Github user wido commented on the pull request:

    https://github.com/apache/cloudstack/pull/1054#issuecomment-215419241
  
    @rhtyd I grepped *after* my modifications :)
    
    Yes, the API between MySQLdb and mysql.connector is the same. The only difference is the import and the connection creation.
    
    Afterwards you can get a cursor and execute queries.
    
    When you do more advanced/complex things there are API differences, but that's not being used by CloudStack.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8818: Use MySQL native connect...

Posted by swill <gi...@git.apache.org>.
Github user swill commented on the pull request:

    https://github.com/apache/cloudstack/pull/1054#issuecomment-215615124
  
    
    
    ### CI RESULTS
    
    ```
    Tests Run: 85
      Skipped: 0
       Failed: 1
       Errors: 0
    ```
    
    **Summary of the problem(s):**
    ```
    FAIL: test_03_vpc_privategw_restart_vpc_cleanup (integration.smoke.test_privategw_acl.TestPrivateGwACL)
    ----------------------------------------------------------------------
    Traceback (most recent call last):
      File "/data/git/cs1/cloudstack/test/integration/smoke/test_privategw_acl.py", line 265, in test_03_vpc_privategw_restart_vpc_cleanup
        self.performVPCTests(vpc_off, True)
      File "/data/git/cs1/cloudstack/test/integration/smoke/test_privategw_acl.py", line 331, in performVPCTests
        self.check_pvt_gw_connectivity(vm1, public_ip_1, vm2.nic[0].ipaddress)
      File "/data/git/cs1/cloudstack/test/integration/smoke/test_privategw_acl.py", line 559, in check_pvt_gw_connectivity
        "Ping to outside world from VM should be successful"
    AssertionError: Ping to outside world from VM should be successful
    ----------------------------------------------------------------------
    Additional details in: /tmp/MarvinLogs/test_network_G9N9AW/results.txt
    ```
    
    
    
    **Associated Uploads**
    
    **`/tmp/MarvinLogs/DeployDataCenter__Apr_28_2016_22_47_49_Z93Y1T:`**
    * [dc_entries.obj](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1054/tmp/MarvinLogs/DeployDataCenter__Apr_28_2016_22_47_49_Z93Y1T/dc_entries.obj)
    * [failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1054/tmp/MarvinLogs/DeployDataCenter__Apr_28_2016_22_47_49_Z93Y1T/failed_plus_exceptions.txt)
    * [runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1054/tmp/MarvinLogs/DeployDataCenter__Apr_28_2016_22_47_49_Z93Y1T/runinfo.txt)
    
    **`/tmp/MarvinLogs/test_network_G9N9AW:`**
    * [failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1054/tmp/MarvinLogs/test_network_G9N9AW/failed_plus_exceptions.txt)
    * [results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1054/tmp/MarvinLogs/test_network_G9N9AW/results.txt)
    * [runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1054/tmp/MarvinLogs/test_network_G9N9AW/runinfo.txt)
    
    **`/tmp/MarvinLogs/test_vpc_routers_V1YYOR:`**
    * [failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1054/tmp/MarvinLogs/test_vpc_routers_V1YYOR/failed_plus_exceptions.txt)
    * [results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1054/tmp/MarvinLogs/test_vpc_routers_V1YYOR/results.txt)
    * [runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1054/tmp/MarvinLogs/test_vpc_routers_V1YYOR/runinfo.txt)
    
    
    Uploads will be available until `2016-06-29 02:00:00 +0200 CEST`
    
    *Comment created by [`upr comment`](https://github.com/cloudops/upr).*



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---