You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@isis.apache.org by ah...@apache.org on 2021/02/03 10:06:55 UTC
[isis] branch master updated: ISIS-2518: fixing Javadoc validation
issues as indicated by the IDE (1)
This is an automated email from the ASF dual-hosted git repository.
ahuber pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/isis.git
The following commit(s) were added to refs/heads/master by this push:
new 31ebf0f ISIS-2518: fixing Javadoc validation issues as indicated by the IDE (1)
31ebf0f is described below
commit 31ebf0fbabda41c2a62afa6bcc5e99225d84cb1a
Author: Andi Huber <ah...@apache.org>
AuthorDate: Wed Feb 3 11:06:39 2021 +0100
ISIS-2518: fixing Javadoc validation issues as indicated by the IDE (1)
---
.../src/main/java/org/apache/isis/applib/Identifier.java | 2 --
.../java/org/apache/isis/applib/annotation/Action.java | 7 ++++---
.../org/apache/isis/applib/annotation/Collection.java | 2 --
.../apache/isis/applib/annotation/PropertyLayout.java | 2 --
.../isis/applib/events/ActionArgumentUsabilityEvent.java | 2 --
.../applib/events/ActionArgumentVisibilityEvent.java | 2 --
.../exceptions/recoverable/InteractionException.java | 6 ------
.../java/org/apache/isis/applib/graph/tree/TreeNode.java | 5 ++---
.../apache/isis/applib/services/bookmark/Bookmark.java | 1 -
.../processor/spi/CommandDtoProcessorService.java | 1 -
.../isis/applib/services/factory/FactoryService.java | 4 ----
.../apache/isis/applib/services/grid/GridService.java | 1 -
.../isis/applib/services/i18n/TranslatableString.java | 1 -
.../isis/applib/services/i18n/TranslationService.java | 2 --
.../isis/applib/services/menu/MenuBarsService.java | 1 -
.../applib/services/repository/RepositoryService.java | 2 --
.../isis/applib/services/wrapper/WrapperFactory.java | 3 ---
.../services/wrapper/events/ActionArgumentEvent.java | 2 --
.../services/wrapper/events/CollectionAddToEvent.java | 2 --
.../services/wrapper/events/CollectionMethodEvent.java | 2 --
.../applib/services/wrapper/events/InteractionEvent.java | 8 --------
.../services/wrapper/events/PropertyModifyEvent.java | 2 --
.../apache/isis/applib/util/ObjectContract_Parser.java | 1 -
.../org/apache/isis/applib/util/ObjectContracts.java | 2 --
.../isis/commons/handler/ChainOfResponsibility.java | 1 -
.../java/org/apache/isis/commons/having/HasUsername.java | 1 -
.../org/apache/isis/commons/internal/base/_Bytes.java | 3 +--
.../org/apache/isis/commons/internal/base/_Casts.java | 1 -
.../org/apache/isis/commons/internal/base/_NullSafe.java | 1 -
.../apache/isis/commons/internal/base/_Reduction.java | 2 --
.../org/apache/isis/commons/internal/base/_Strings.java | 16 ++++++----------
.../isis/commons/internal/collections/_Arrays.java | 4 ----
.../isis/commons/internal/collections/_Collections.java | 1 -
.../apache/isis/commons/internal/collections/_Maps.java | 4 +---
.../isis/commons/internal/collections/_Multimaps.java | 6 ------
.../apache/isis/commons/internal/context/_Context.java | 10 ----------
.../apache/isis/commons/internal/context/_Plugin.java | 2 --
.../isis/commons/internal/functions/_Functions.java | 3 ---
.../apache/isis/commons/internal/ioc/_IocContainer.java | 1 -
.../apache/isis/commons/internal/memento/_Mementos.java | 3 ---
.../isis/commons/internal/reflection/_Reflect.java | 6 ------
.../apache/isis/commons/internal/resources/_Json.java | 8 --------
.../isis/commons/internal/resources/_Resources.java | 1 -
.../apache/isis/commons/internal/resources/_Yaml.java | 4 ----
.../org/apache/isis/core/config/IsisConfiguration.java | 1 -
.../isis/core/config/beans/IsisBeanTypeRegistry.java | 1 -
.../internaltestsupport/jmocking/JUnitRuleMockery2.java | 1 -
.../isis/core/metamodel/commons/StringExtensions.java | 2 --
.../isis/core/metamodel/consent/ConsentAbstract.java | 2 --
.../isis/core/metamodel/consent/InteractionResult.java | 2 --
.../core/metamodel/consent/InteractionResultSet.java | 6 ------
.../org/apache/isis/core/metamodel/facetapi/Facet.java | 2 --
.../facets/all/deficiencies/DeficiencyFacet.java | 1 -
.../metamodel/facets/object/defaults/DefaultedFacet.java | 2 --
.../core/metamodel/facets/object/entity/EntityFacet.java | 1 -
.../facets/object/navparent/NavigableParentFacet.java | 1 -
.../isis/core/metamodel/objectmanager/ObjectManager.java | 3 ---
.../objectmanager/serialize/ObjectSerializer.java | 1 -
.../apache/isis/core/metamodel/spec/ManagedObject.java | 2 --
.../isis/core/metamodel/spec/ObjectSpecification.java | 6 +-----
.../isis/core/metamodel/spec/feature/ObjectAction.java | 4 ----
.../metamodel/spec/feature/ObjectActionParameter.java | 4 ----
.../specloader/specimpl/OneToOneAssociationDefault.java | 1 -
.../specloader/validator/ValidationFailures.java | 1 -
.../isis/core/metamodel/util/pchain/ParentChain.java | 2 --
.../wrapper/handlers/DomainObjectInvocationHandler.java | 2 --
.../_infra/resources/MarkupVariableResolverService.java | 1 -
.../commandlog/impl/jdo/CommandJdoRepository.java | 2 --
.../primary/restapi/CommandRetrievalService.java | 2 --
.../primary/ui/CommandReplayOnPrimaryService.java | 6 ------
.../commandreplay/secondary/fetch/CommandFetcher.java | 3 +--
.../secondary/spi/ReplayCommandExecutionController.java | 1 -
.../javafx/ui/components/UiComponentHandlerFx.java | 1 -
.../isis/extensions/restclient/ResponseDigest.java | 2 --
.../jdo/provider/persistence/HasPersistenceManager.java | 3 ---
.../base/applib/valuetypes/AbstractInterval.java | 7 -------
.../base/applib/valuetypes/LocalDateInterval.java | 7 ++-----
.../apache/isis/extensions/zip/dom/impl/ZipService.java | 1 -
.../apache/isis/testing/fixtures/applib/clock/Clock.java | 2 --
.../fixtures/applib/fixturescripts/FixtureScripts.java | 2 --
.../integtestsupport/applib/ThrowableMatchers.java | 1 -
.../applib/core/jmocking/JUnitRuleMockery2.java | 1 -
.../isis/viewer/common/model/object/ObjectUiModel.java | 2 --
.../viewer/restfulobjects/applib/LinkRepresentation.java | 2 --
.../viewer/restfulobjects/applib/util/MediaTypes.java | 4 +---
.../domaintypes/AbstractTypeMemberReprRenderer.java | 2 --
.../restfulobjects/viewer/context/ResourceContext.java | 1 -
.../viewer/wicket/model/isis/WicketViewerSettings.java | 3 ---
.../isis/viewer/wicket/model/models/ScalarModel.java | 2 --
.../apache/isis/viewer/wicket/ui/ComponentFactory.java | 1 -
90 files changed, 19 insertions(+), 229 deletions(-)
diff --git a/api/applib/src/main/java/org/apache/isis/applib/Identifier.java b/api/applib/src/main/java/org/apache/isis/applib/Identifier.java
index 46e89aa..273e537 100644
--- a/api/applib/src/main/java/org/apache/isis/applib/Identifier.java
+++ b/api/applib/src/main/java/org/apache/isis/applib/Identifier.java
@@ -186,8 +186,6 @@ public class Identifier implements Comparable<Identifier> {
/**
* Convenience method.
- *
- * @return
*/
public boolean isPropertyOrCollection() {
return type == Type.PROPERTY_OR_COLLECTION;
diff --git a/api/applib/src/main/java/org/apache/isis/applib/annotation/Action.java b/api/applib/src/main/java/org/apache/isis/applib/annotation/Action.java
index b604277..93faf34 100644
--- a/api/applib/src/main/java/org/apache/isis/applib/annotation/Action.java
+++ b/api/applib/src/main/java/org/apache/isis/applib/annotation/Action.java
@@ -30,9 +30,11 @@ import org.apache.isis.applib.services.command.Command;
import org.apache.isis.applib.services.commanddto.conmap.ContentMappingServiceForCommandDto;
import org.apache.isis.applib.services.commanddto.conmap.ContentMappingServiceForCommandsDto;
import org.apache.isis.applib.services.commanddto.processor.CommandDtoProcessor;
-import org.apache.isis.applib.services.iactn.Interaction;
+import org.apache.isis.applib.services.iactn.Interaction.Execution;
import org.apache.isis.applib.services.publishing.spi.CommandSubscriber;
import org.apache.isis.applib.services.publishing.spi.ExecutionSubscriber;
+import org.apache.isis.applib.value.Blob;
+import org.apache.isis.applib.value.Clob;
/**
* Domain semantics for domain object collection.
@@ -129,7 +131,7 @@ public @interface Action {
default ActionDomainEvent.Default.class;
/**
- * Whether {@link Interaction.Execution}s (triggered by action invocations), should
+ * Whether {@link Execution}s (triggered by action invocations), should
* be published to {@link ExecutionSubscriber}s.
*/
Publishing executionPublishing()
@@ -171,7 +173,6 @@ public @interface Action {
/**
* The type-of the elements returned by the action.
- * @return
*/
Class<?> typeOf()
default Object.class;
diff --git a/api/applib/src/main/java/org/apache/isis/applib/annotation/Collection.java b/api/applib/src/main/java/org/apache/isis/applib/annotation/Collection.java
index 86cdc89..4272405 100644
--- a/api/applib/src/main/java/org/apache/isis/applib/annotation/Collection.java
+++ b/api/applib/src/main/java/org/apache/isis/applib/annotation/Collection.java
@@ -83,8 +83,6 @@ public @interface Collection {
/**
* The type-of the elements held within the collection.
- *
- * @return
*/
Class<?> typeOf()
default Object.class;
diff --git a/api/applib/src/main/java/org/apache/isis/applib/annotation/PropertyLayout.java b/api/applib/src/main/java/org/apache/isis/applib/annotation/PropertyLayout.java
index 1735571..6917886 100644
--- a/api/applib/src/main/java/org/apache/isis/applib/annotation/PropertyLayout.java
+++ b/api/applib/src/main/java/org/apache/isis/applib/annotation/PropertyLayout.java
@@ -89,8 +89,6 @@ public @interface PropertyLayout {
* <p>
* Only one property can be annotated as such per domain class.
* </p>
- *
- * @return
*/
Navigable navigable()
default Navigable.NOT_SPECIFIED;
diff --git a/api/applib/src/main/java/org/apache/isis/applib/events/ActionArgumentUsabilityEvent.java b/api/applib/src/main/java/org/apache/isis/applib/events/ActionArgumentUsabilityEvent.java
index a96cc76..026f594 100644
--- a/api/applib/src/main/java/org/apache/isis/applib/events/ActionArgumentUsabilityEvent.java
+++ b/api/applib/src/main/java/org/apache/isis/applib/events/ActionArgumentUsabilityEvent.java
@@ -53,8 +53,6 @@ public class ActionArgumentUsabilityEvent extends UsabilityEvent {
/**
* The position (0-based) of the disabled parameter.
- *
- * @return
*/
public int getPosition() {
return position;
diff --git a/api/applib/src/main/java/org/apache/isis/applib/events/ActionArgumentVisibilityEvent.java b/api/applib/src/main/java/org/apache/isis/applib/events/ActionArgumentVisibilityEvent.java
index 240e097..e0f9ac6 100644
--- a/api/applib/src/main/java/org/apache/isis/applib/events/ActionArgumentVisibilityEvent.java
+++ b/api/applib/src/main/java/org/apache/isis/applib/events/ActionArgumentVisibilityEvent.java
@@ -52,8 +52,6 @@ public class ActionArgumentVisibilityEvent extends VisibilityEvent {
/**
* The position (0-based) of the hidden parameter.
- *
- * @return
*/
public int getPosition() {
return position;
diff --git a/api/applib/src/main/java/org/apache/isis/applib/exceptions/recoverable/InteractionException.java b/api/applib/src/main/java/org/apache/isis/applib/exceptions/recoverable/InteractionException.java
index 61ad7bc..12922d5 100644
--- a/api/applib/src/main/java/org/apache/isis/applib/exceptions/recoverable/InteractionException.java
+++ b/api/applib/src/main/java/org/apache/isis/applib/exceptions/recoverable/InteractionException.java
@@ -43,8 +43,6 @@ public abstract class InteractionException extends RecoverableException {
* the appropriate subtype of {@link InteractionEvent}. This would have been
* more obvious to see if {@link InteractionException} was generic, but
* generic subclasses of {@link Throwable} are (apparently) not allowed.
- *
- * @return
*/
protected InteractionEvent getInteractionEvent() {
return interactionEvent;
@@ -54,8 +52,6 @@ public abstract class InteractionException extends RecoverableException {
* Convenience method that returns the
* {@link InteractionEvent#getAdvisorClass() advisor class} of the wrapped
* {@link #getInteractionEvent() interaction event}.
- *
- * @return
*/
public Class<?> getAdvisorClass() {
return interactionEvent.getAdvisorClass();
@@ -65,8 +61,6 @@ public abstract class InteractionException extends RecoverableException {
* Convenience method that returns the
* {@link InteractionEvent#getIdentifier() identifier} of the wrapped
* {@link #getInteractionEvent() interaction event}.
- *
- * @return
*/
public Identifier getIdentifier() {
return interactionEvent.getIdentifier();
diff --git a/api/applib/src/main/java/org/apache/isis/applib/graph/tree/TreeNode.java b/api/applib/src/main/java/org/apache/isis/applib/graph/tree/TreeNode.java
index 9189034..49fe471 100644
--- a/api/applib/src/main/java/org/apache/isis/applib/graph/tree/TreeNode.java
+++ b/api/applib/src/main/java/org/apache/isis/applib/graph/tree/TreeNode.java
@@ -167,10 +167,9 @@ public interface TreeNode<T> extends Vertex<T> {
// -- LAZY NODE ADAPTING
/**
- * @return
+ * @apiNote a class rather than an instance, because otherwise
+ * the adapter would need to be serializable for Wicket's trees to work correctly.
*/
- // [ahuber] Implementation Note: a class rather than an instance, because otherwise
- // the adapter would need to be serializable for Wicket's trees to work correctly.
public Class<? extends TreeAdapter<T>> getTreeAdapterClass();
diff --git a/api/applib/src/main/java/org/apache/isis/applib/services/bookmark/Bookmark.java b/api/applib/src/main/java/org/apache/isis/applib/services/bookmark/Bookmark.java
index 2379c63..c4e93be 100644
--- a/api/applib/src/main/java/org/apache/isis/applib/services/bookmark/Bookmark.java
+++ b/api/applib/src/main/java/org/apache/isis/applib/services/bookmark/Bookmark.java
@@ -67,7 +67,6 @@ public class Bookmark implements Serializable {
/**
* Round-trip with {@link #toString()} representation.
- * @return
*/
public static Optional<Bookmark> parse(@Nullable String str) {
diff --git a/api/applib/src/main/java/org/apache/isis/applib/services/commanddto/processor/spi/CommandDtoProcessorService.java b/api/applib/src/main/java/org/apache/isis/applib/services/commanddto/processor/spi/CommandDtoProcessorService.java
index c118e1d..f24502f 100644
--- a/api/applib/src/main/java/org/apache/isis/applib/services/commanddto/processor/spi/CommandDtoProcessorService.java
+++ b/api/applib/src/main/java/org/apache/isis/applib/services/commanddto/processor/spi/CommandDtoProcessorService.java
@@ -37,7 +37,6 @@ public interface CommandDtoProcessorService {
* {@link CommandDto}.
* @param commandDto - is either <code>null</code>, or is passed from a
* previous implementation for further refinement.
- * @return
*/
CommandDto process(final Object domainObject, @Nullable final CommandDto commandDto);
diff --git a/api/applib/src/main/java/org/apache/isis/applib/services/factory/FactoryService.java b/api/applib/src/main/java/org/apache/isis/applib/services/factory/FactoryService.java
index e9d2f60..47cd730 100644
--- a/api/applib/src/main/java/org/apache/isis/applib/services/factory/FactoryService.java
+++ b/api/applib/src/main/java/org/apache/isis/applib/services/factory/FactoryService.java
@@ -44,7 +44,6 @@ public interface FactoryService {
*
* @param <T>
* @param requiredType
- * @return
* @throws NoSuchElementException if result is empty
* @throws UnrecoverableException if instance creation failed
* @throws IllegalArgumentException if requiredType is not recognized by the meta-model
@@ -78,7 +77,6 @@ public interface FactoryService {
*
* @param <T>
* @param domainClass - only applicable to entity types
- * @return
* @throws IllegalArgumentException if domainClass is not an entity type
* @apiNote forces the domainClass to be added to the meta-model if not already
* @since 2.0
@@ -90,7 +88,6 @@ public interface FactoryService {
*
* @param <T>
* @param entity - most likely just new-ed up, without injection points resolved
- * @return
* @throws IllegalArgumentException if domainClass is not an entity type
* @apiNote forces the domainClass to be added to the meta-model if not already
* @since 2.0
@@ -103,7 +100,6 @@ public interface FactoryService {
* @param <T>
* @param mixinClass
* @param mixedIn
- * @return
* @throws IllegalArgumentException if mixinClass is not a mixin type
* @apiNote forces the mixinClass to be added to the meta-model if not already
*/
diff --git a/api/applib/src/main/java/org/apache/isis/applib/services/grid/GridService.java b/api/applib/src/main/java/org/apache/isis/applib/services/grid/GridService.java
index 8ec3334..aa9ab06 100644
--- a/api/applib/src/main/java/org/apache/isis/applib/services/grid/GridService.java
+++ b/api/applib/src/main/java/org/apache/isis/applib/services/grid/GridService.java
@@ -100,7 +100,6 @@ public interface GridService {
* </p>
*
* @param grid
- * @return
*/
Grid minimal(Grid grid);
diff --git a/api/applib/src/main/java/org/apache/isis/applib/services/i18n/TranslatableString.java b/api/applib/src/main/java/org/apache/isis/applib/services/i18n/TranslatableString.java
index 135fb3f..fdeaa9f 100644
--- a/api/applib/src/main/java/org/apache/isis/applib/services/i18n/TranslatableString.java
+++ b/api/applib/src/main/java/org/apache/isis/applib/services/i18n/TranslatableString.java
@@ -187,7 +187,6 @@ public final class TranslatableString {
* either the single or plural form as per {@link #getPattern()}.
* @param translationService
* @param context
- * @return
*/
public String translate(final TranslationService translationService, final String context) {
diff --git a/api/applib/src/main/java/org/apache/isis/applib/services/i18n/TranslationService.java b/api/applib/src/main/java/org/apache/isis/applib/services/i18n/TranslationService.java
index 7ab0581..6a30d4d 100644
--- a/api/applib/src/main/java/org/apache/isis/applib/services/i18n/TranslationService.java
+++ b/api/applib/src/main/java/org/apache/isis/applib/services/i18n/TranslationService.java
@@ -35,7 +35,6 @@ public interface TranslationService {
*
* @param context
* @param text
- * @return
*/
String translate(
final String context,
@@ -53,7 +52,6 @@ public interface TranslationService {
* @param singularText
* @param pluralText
* @param num - whether to return the translation of the singular (if =1) or of the plural (if != 1)
- * @return
*/
String translate(
final String context,
diff --git a/api/applib/src/main/java/org/apache/isis/applib/services/menu/MenuBarsService.java b/api/applib/src/main/java/org/apache/isis/applib/services/menu/MenuBarsService.java
index 8aaa9ad..b5f3c79 100644
--- a/api/applib/src/main/java/org/apache/isis/applib/services/menu/MenuBarsService.java
+++ b/api/applib/src/main/java/org/apache/isis/applib/services/menu/MenuBarsService.java
@@ -43,7 +43,6 @@ public interface MenuBarsService {
/**
* Returns {@link #menuBars()} with a type of {@link Type#DEFAULT}.
- * @return
*/
default MenuBars menuBars() {
return menuBars(Type.DEFAULT);
diff --git a/api/applib/src/main/java/org/apache/isis/applib/services/repository/RepositoryService.java b/api/applib/src/main/java/org/apache/isis/applib/services/repository/RepositoryService.java
index df2c3c2..d6b256a 100644
--- a/api/applib/src/main/java/org/apache/isis/applib/services/repository/RepositoryService.java
+++ b/api/applib/src/main/java/org/apache/isis/applib/services/repository/RepositoryService.java
@@ -117,7 +117,6 @@ public interface RepositoryService {
* @param start
* @param count
* @param <T>
- * @return
*/
<T> List<T> allInstances(
Class<T> ofType,
@@ -155,7 +154,6 @@ public interface RepositoryService {
* @param start
* @param count
* @param <T>
- * @return
*/
<T> List<T> allMatches(
Class<T> ofType,
diff --git a/api/applib/src/main/java/org/apache/isis/applib/services/wrapper/WrapperFactory.java b/api/applib/src/main/java/org/apache/isis/applib/services/wrapper/WrapperFactory.java
index 8e48d76..c231fda 100644
--- a/api/applib/src/main/java/org/apache/isis/applib/services/wrapper/WrapperFactory.java
+++ b/api/applib/src/main/java/org/apache/isis/applib/services/wrapper/WrapperFactory.java
@@ -136,7 +136,6 @@ public interface WrapperFactory {
* @param <T>
* @param possibleWrappedDomainObject
* - object that might or might not be a wrapper.
- * @return
*/
<T> boolean isWrapper(T possibleWrappedDomainObject);
@@ -200,7 +199,6 @@ public interface WrapperFactory {
* the container to fire the events).
*
* @param listener
- * @return
*/
boolean addInteractionListener(InteractionListener listener);
@@ -215,7 +213,6 @@ public interface WrapperFactory {
* wrappers delegate back to the container to fire the events).
*
* @param listener
- * @return
*/
boolean removeInteractionListener(
InteractionListener listener);
diff --git a/api/applib/src/main/java/org/apache/isis/applib/services/wrapper/events/ActionArgumentEvent.java b/api/applib/src/main/java/org/apache/isis/applib/services/wrapper/events/ActionArgumentEvent.java
index dd9839e..88a61c3 100644
--- a/api/applib/src/main/java/org/apache/isis/applib/services/wrapper/events/ActionArgumentEvent.java
+++ b/api/applib/src/main/java/org/apache/isis/applib/services/wrapper/events/ActionArgumentEvent.java
@@ -53,8 +53,6 @@ public class ActionArgumentEvent extends ValidityEvent {
/**
* The position (0-based) of the invalid argument.
- *
- * @return
*/
public int getPosition() {
return position;
diff --git a/api/applib/src/main/java/org/apache/isis/applib/services/wrapper/events/CollectionAddToEvent.java b/api/applib/src/main/java/org/apache/isis/applib/services/wrapper/events/CollectionAddToEvent.java
index c696f0a..9667bbd 100644
--- a/api/applib/src/main/java/org/apache/isis/applib/services/wrapper/events/CollectionAddToEvent.java
+++ b/api/applib/src/main/java/org/apache/isis/applib/services/wrapper/events/CollectionAddToEvent.java
@@ -44,8 +44,6 @@ public class CollectionAddToEvent extends ValidityEvent {
/**
* The object that is being added.
- *
- * @return
*/
@Override
public Object getProposed() {
diff --git a/api/applib/src/main/java/org/apache/isis/applib/services/wrapper/events/CollectionMethodEvent.java b/api/applib/src/main/java/org/apache/isis/applib/services/wrapper/events/CollectionMethodEvent.java
index f0b76f5..984d957 100644
--- a/api/applib/src/main/java/org/apache/isis/applib/services/wrapper/events/CollectionMethodEvent.java
+++ b/api/applib/src/main/java/org/apache/isis/applib/services/wrapper/events/CollectionMethodEvent.java
@@ -68,8 +68,6 @@ public class CollectionMethodEvent extends AccessEvent {
/**
* The name of the method invoked on this collection, for example
* <tt>isEmpty</tt>.
- *
- * @return
*/
public String getMethodName() {
return methodName;
diff --git a/api/applib/src/main/java/org/apache/isis/applib/services/wrapper/events/InteractionEvent.java b/api/applib/src/main/java/org/apache/isis/applib/services/wrapper/events/InteractionEvent.java
index 3e5a462..3d0dc1d 100644
--- a/api/applib/src/main/java/org/apache/isis/applib/services/wrapper/events/InteractionEvent.java
+++ b/api/applib/src/main/java/org/apache/isis/applib/services/wrapper/events/InteractionEvent.java
@@ -62,8 +62,6 @@ public abstract class InteractionEvent extends EventObjectBase<Object> {
* Will be consistent with the subclass of {@link InteractionEvent}. So for
* example a {@link PropertyModifyEvent} will have an {@link Identifier}
* that identifies the property being modified.
- *
- * @return
*/
public Identifier getIdentifier() {
return identifier;
@@ -126,8 +124,6 @@ public abstract class InteractionEvent extends EventObjectBase<Object> {
* <p>
* Intended to be {@link #setExecuteIn(String) set} as a result of consulting
* one of the facets.
- *
- * @return
*/
public String getReason() {
return reason;
@@ -139,8 +135,6 @@ public abstract class InteractionEvent extends EventObjectBase<Object> {
*
* <p>
* This message should be overridden by subclasses for containing the Reason, the Identifier and any other relevant context information.
- *
- * @return
*/
public String getReasonMessage() {
if (this.getIdentifier() != null) {
@@ -154,8 +148,6 @@ public abstract class InteractionEvent extends EventObjectBase<Object> {
* The class of the (first) advisor, if any, that provided the
* {@link #getReason() reason} that this interaction is {@link #isVeto()
* vetoed}.
- *
- * @return
*/
public Class<?> getAdvisorClass() {
return advisorClass;
diff --git a/api/applib/src/main/java/org/apache/isis/applib/services/wrapper/events/PropertyModifyEvent.java b/api/applib/src/main/java/org/apache/isis/applib/services/wrapper/events/PropertyModifyEvent.java
index 6c3588e..9940587 100644
--- a/api/applib/src/main/java/org/apache/isis/applib/services/wrapper/events/PropertyModifyEvent.java
+++ b/api/applib/src/main/java/org/apache/isis/applib/services/wrapper/events/PropertyModifyEvent.java
@@ -41,8 +41,6 @@ public class PropertyModifyEvent extends ValidityEvent {
/**
* If <tt>null</tt>, then the property was cleared.
- *
- * @return
*/
@Override
public Object getProposed() {
diff --git a/api/applib/src/main/java/org/apache/isis/applib/util/ObjectContract_Parser.java b/api/applib/src/main/java/org/apache/isis/applib/util/ObjectContract_Parser.java
index 9120f11..a788111 100644
--- a/api/applib/src/main/java/org/apache/isis/applib/util/ObjectContract_Parser.java
+++ b/api/applib/src/main/java/org/apache/isis/applib/util/ObjectContract_Parser.java
@@ -49,7 +49,6 @@ class ObjectContract_Parser<T> {
* Parsing stringified property name lists like <pre>"invoice desc, productCode, quantity"</pre>.
* @param cls
* @param propertyNames
- * @return
*/
@SuppressWarnings("unchecked")
public static <T> ObjectContract<T> parse(Class<T> cls, @Nullable final String propertyNames) {
diff --git a/api/applib/src/main/java/org/apache/isis/applib/util/ObjectContracts.java b/api/applib/src/main/java/org/apache/isis/applib/util/ObjectContracts.java
index 622690e..9a71f3f 100644
--- a/api/applib/src/main/java/org/apache/isis/applib/util/ObjectContracts.java
+++ b/api/applib/src/main/java/org/apache/isis/applib/util/ObjectContracts.java
@@ -121,7 +121,6 @@ public final class ObjectContracts {
* @param propertyLabel a label to use for property to string output
* @param getter function extracting the property value of an object
* @param valueComparator
- * @return
*/
public <U> ObjectContract<T> thenUse(
String propertyLabel,
@@ -134,7 +133,6 @@ public final class ObjectContracts {
*
* @param propertyLabel a label to use for property to string output
* @param getter function extracting the property value of an object
- * @return
*/
public default <U extends Comparable<? super U>> ObjectContract<T> thenUse(
String propertyLabel,
diff --git a/commons/src/main/java/org/apache/isis/commons/handler/ChainOfResponsibility.java b/commons/src/main/java/org/apache/isis/commons/handler/ChainOfResponsibility.java
index 120f9c0..7eef722 100644
--- a/commons/src/main/java/org/apache/isis/commons/handler/ChainOfResponsibility.java
+++ b/commons/src/main/java/org/apache/isis/commons/handler/ChainOfResponsibility.java
@@ -61,7 +61,6 @@ public interface ChainOfResponsibility<X, R> {
* @param <X>
* @param <R>
* @param chainOfHandlers
- * @return
*/
static <X, R> ChainOfResponsibility<X, R>
of(
diff --git a/commons/src/main/java/org/apache/isis/commons/having/HasUsername.java b/commons/src/main/java/org/apache/isis/commons/having/HasUsername.java
index 825ee77..5b03ac0 100644
--- a/commons/src/main/java/org/apache/isis/commons/having/HasUsername.java
+++ b/commons/src/main/java/org/apache/isis/commons/having/HasUsername.java
@@ -32,7 +32,6 @@ public interface HasUsername {
/**
* The user that created this object.
- * @return
*/
String getUsername();
diff --git a/commons/src/main/java/org/apache/isis/commons/internal/base/_Bytes.java b/commons/src/main/java/org/apache/isis/commons/internal/base/_Bytes.java
index 3a6e5bf..21e4090 100644
--- a/commons/src/main/java/org/apache/isis/commons/internal/base/_Bytes.java
+++ b/commons/src/main/java/org/apache/isis/commons/internal/base/_Bytes.java
@@ -237,8 +237,7 @@ public final class _Bytes {
}
/**
- * Returns a monadic BytesOperator that allows composition of unary byte[] operators
- * @return
+ * Returns a BytesOperator that allows composition of unary byte[] operators
*/
public static BytesOperator operator() {
return new BytesOperator(UnaryOperator.identity());
diff --git a/commons/src/main/java/org/apache/isis/commons/internal/base/_Casts.java b/commons/src/main/java/org/apache/isis/commons/internal/base/_Casts.java
index cd433c1..457f945 100644
--- a/commons/src/main/java/org/apache/isis/commons/internal/base/_Casts.java
+++ b/commons/src/main/java/org/apache/isis/commons/internal/base/_Casts.java
@@ -96,7 +96,6 @@ public final class _Casts {
* @param onLeftCast
* @param onRightCast
* @param onNonCast
- * @return
*/
public static <T, R, U, V> R castThenApply(
@Nullable U left,
diff --git a/commons/src/main/java/org/apache/isis/commons/internal/base/_NullSafe.java b/commons/src/main/java/org/apache/isis/commons/internal/base/_NullSafe.java
index ec1373e..0690332 100644
--- a/commons/src/main/java/org/apache/isis/commons/internal/base/_NullSafe.java
+++ b/commons/src/main/java/org/apache/isis/commons/internal/base/_NullSafe.java
@@ -321,7 +321,6 @@ public final class _NullSafe {
* @param <K>
* @param <V>
* @param map
- * @return
*/
public static <K, V> Set<Map.Entry<K, V>> entrySet(final @Nullable Map<K, V> map) {
return map==null
diff --git a/commons/src/main/java/org/apache/isis/commons/internal/base/_Reduction.java b/commons/src/main/java/org/apache/isis/commons/internal/base/_Reduction.java
index 8cb2674..1e4389e 100644
--- a/commons/src/main/java/org/apache/isis/commons/internal/base/_Reduction.java
+++ b/commons/src/main/java/org/apache/isis/commons/internal/base/_Reduction.java
@@ -55,7 +55,6 @@ public final class _Reduction<T> implements Consumer<T> {
* Inspired by {@link Stream#reduce(Object, BinaryOperator)}
* @param identity
* @param accumulator
- * @return
*/
public static <T> _Reduction<T> of(@Nullable T identity, BinaryOperator<T> accumulator){
return new _Reduction<T>(identity, accumulator, true);
@@ -64,7 +63,6 @@ public final class _Reduction<T> implements Consumer<T> {
/**
* Inspired by {@link Stream#reduce(BinaryOperator)}
* @param accumulator
- * @return
*/
public static <T> _Reduction<T> of(BinaryOperator<T> accumulator){
return new _Reduction<T>(null, accumulator, false);
diff --git a/commons/src/main/java/org/apache/isis/commons/internal/base/_Strings.java b/commons/src/main/java/org/apache/isis/commons/internal/base/_Strings.java
index 2561b31..ec8c8dd 100644
--- a/commons/src/main/java/org/apache/isis/commons/internal/base/_Strings.java
+++ b/commons/src/main/java/org/apache/isis/commons/internal/base/_Strings.java
@@ -78,7 +78,7 @@ public final class _Strings {
/**
* Convenient e.g. for toArray conversions
- * (a duplicate of in {@link _Constants.emptyStringArray} )
+ * (a duplicate of in {@link _Constants#emptyStringArray} )
*/
public static final String[] emptyArray = new String[0];
@@ -122,7 +122,7 @@ public final class _Strings {
* @param a
* @param b
* @return {@code -1} if {@code a < b}, {@code 1} if {@code a > b} else {@code 0}
- * @see {@link String#compareTo(String)}
+ * @see String#compareTo(String)
*/
public static int compareNullsFirst(final @Nullable String a, final @Nullable String b) {
if(Objects.equals(a, b)) {
@@ -147,7 +147,7 @@ public final class _Strings {
* @param a
* @param b
* @return {@code -1} if {@code a < b}, {@code 1} if {@code a > b} else {@code 0}
- * @see {@link String#compareTo(String)}
+ * @see String#compareTo(String)
*/
public static int compareNullsLast(final @Nullable String a, final @Nullable String b) {
if(Objects.equals(a, b)) {
@@ -375,7 +375,6 @@ public final class _Strings {
* @param str
* @param minLength
* @param c
- * @return
*/
public static String padStart(@Nullable String str, int minLength, char c) {
if(minLength<=0) {
@@ -395,9 +394,8 @@ public final class _Strings {
* Returns a string, of length at least minLength, consisting of string appended with as many copies
* of padChar as are necessary to reach that length.
* @param str
- * @param padTo
+ * @param minLength
* @param c
- * @return
*/
public static String padEnd(@Nullable String str, int minLength, char c) {
if(minLength<=0) {
@@ -428,7 +426,7 @@ public final class _Strings {
* @param input
* @param separator non-empty string
* @return empty stream if {@code input} is null
- * @throws {@link IllegalArgumentException} if {@code separator} is empty
+ * @throws IllegalArgumentException if {@code separator} is empty
*/
public static Stream<String> splitThenStream(@Nullable final String input, final String separator) {
if(isEmpty(separator)) {
@@ -450,7 +448,6 @@ public final class _Strings {
* Creates a stream from the given input sequence around matches of {@code delimiterPattern}.
* @param input
* @param delimiterPattern
- * @return
*/
public static Stream<String> splitThenStream(@Nullable final CharSequence input, Pattern delimiterPattern) {
if(isEmpty(input)) {
@@ -643,8 +640,7 @@ public final class _Strings {
}
/**
- * Returns a monadic StringOperator that allows composition of unary string operators
- * @return
+ * Returns a StringOperator that allows composition of unary string operators
*/
public static StringOperator operator() {
return new StringOperator(UnaryOperator.identity());
diff --git a/commons/src/main/java/org/apache/isis/commons/internal/collections/_Arrays.java b/commons/src/main/java/org/apache/isis/commons/internal/collections/_Arrays.java
index 464e1bb..61a81ce 100644
--- a/commons/src/main/java/org/apache/isis/commons/internal/collections/_Arrays.java
+++ b/commons/src/main/java/org/apache/isis/commons/internal/collections/_Arrays.java
@@ -134,7 +134,6 @@ public final class _Arrays {
* Known-size Collector.
* @param componentType
* @param length
- * @return
*/
public static <T> Collector<T,?,T[]> toArray(final Class<T> componentType, final int length){
_With.requires(componentType, "componentType");
@@ -144,7 +143,6 @@ public final class _Arrays {
/**
* Unknown-size Collector.
* @param componentType
- * @return
*/
public static <T> Collector<T,?,T[]> toArray(final Class<T> componentType){
_With.requires(componentType, "componentType");
@@ -256,7 +254,6 @@ public final class _Arrays {
* @param <T>
* @param array
* @param index
- * @return
*/
public static <T> T[] removeByIndex(T[] array, int index) {
if(array==null || array.length<1) {
@@ -451,7 +448,6 @@ public final class _Arrays {
* to each element of {@code collection}.
* Returns {@code null} if {@code collection} is {@code null};
* @param <T>
- * @param <R>
* @param collection
* @param mapper
* @return nullable
diff --git a/commons/src/main/java/org/apache/isis/commons/internal/collections/_Collections.java b/commons/src/main/java/org/apache/isis/commons/internal/collections/_Collections.java
index d3eec03..eb1194d 100644
--- a/commons/src/main/java/org/apache/isis/commons/internal/collections/_Collections.java
+++ b/commons/src/main/java/org/apache/isis/commons/internal/collections/_Collections.java
@@ -118,7 +118,6 @@ public final class _Collections {
* Same as {@link Collections#unmodifiableList(List)}.
*
* @param list
- * @return
*/
public static <T> List<T> asUnmodifiableList(@Nullable final List<T> list) {
if(list==null) {
diff --git a/commons/src/main/java/org/apache/isis/commons/internal/collections/_Maps.java b/commons/src/main/java/org/apache/isis/commons/internal/collections/_Maps.java
index d352685..6c1eaf8 100644
--- a/commons/src/main/java/org/apache/isis/commons/internal/collections/_Maps.java
+++ b/commons/src/main/java/org/apache/isis/commons/internal/collections/_Maps.java
@@ -77,7 +77,6 @@ public final class _Maps {
* @param key
* @param aliases
* @param value
- * @return
* @throws IllegalArgumentException if there is an alias-key collision
*/
public V put(K key, Can<K> aliases, V value);
@@ -87,7 +86,6 @@ public final class _Maps {
* @param key
* @param aliases
* @param value
- * @return
*/
public V remap(K key, Can<K> aliases, V value);
@@ -166,7 +164,7 @@ public final class _Maps {
* If this is an add operation, then given {@code value} is associated with the {@code key}.
* @param <K>
* @param <V>
- * @param input
+ * @param map
* @param key
* @param value
* @return whether given map contains the {@code key} after the operation
diff --git a/commons/src/main/java/org/apache/isis/commons/internal/collections/_Multimaps.java b/commons/src/main/java/org/apache/isis/commons/internal/collections/_Multimaps.java
index 7dd93a6..b86f097 100644
--- a/commons/src/main/java/org/apache/isis/commons/internal/collections/_Multimaps.java
+++ b/commons/src/main/java/org/apache/isis/commons/internal/collections/_Multimaps.java
@@ -77,7 +77,6 @@ public class _Multimaps {
* or a new List if this map contains no mapping for the key.
* <p> In the latter case the List is also put onto this map.
* @param key
- * @return
*/
public List<V> getOrElseNew(K key);
@@ -86,7 +85,6 @@ public class _Multimaps {
* or an immutable empty List if this map contains no mapping for the key.
* <p> In the latter case the List is not put onto this map.
* @param key
- * @return
*/
default public List<V> getOrElseEmpty(K key) {
return getOrDefault(key, Collections.emptyList());
@@ -118,7 +116,6 @@ public class _Multimaps {
* or a new Set if this map contains no mapping for the key.
* <p> In the latter case the Set is also put onto this map.
* @param key
- * @return
*/
public Set<V> getOrElseNew(K key);
@@ -127,7 +124,6 @@ public class _Multimaps {
* or an immutable empty Set if this map contains no mapping for the key.
* <p> In the latter case the Set is not put onto this map.
* @param key
- * @return
*/
default public Set<V> getOrElseEmpty(K key) {
return getOrDefault(key, Collections.emptySet());
@@ -169,7 +165,6 @@ public class _Multimaps {
* or a new Map if this map contains no mapping for the key.
* <p> In the latter case the Map is also put onto this map.
* @param key
- * @return
*/
public Map<K2, V> getOrElseNew(K1 key);
@@ -178,7 +173,6 @@ public class _Multimaps {
* or an immutable empty Map if this map contains no mapping for the key.
* <p> In the latter case the Map not is put onto this map.
* @param key
- * @return
*/
default public Map<K2, V> getOrElseEmpty(K1 key) {
return getOrDefault(key, Collections.emptyMap());
diff --git a/commons/src/main/java/org/apache/isis/commons/internal/context/_Context.java b/commons/src/main/java/org/apache/isis/commons/internal/context/_Context.java
index 01a0f3e..9a12043 100644
--- a/commons/src/main/java/org/apache/isis/commons/internal/context/_Context.java
+++ b/commons/src/main/java/org/apache/isis/commons/internal/context/_Context.java
@@ -177,7 +177,6 @@ public final class _Context {
* which could be null.
* @param type non-null
* @param fallback non-null
- * @return
*/
public static <T> T getOrElse(Class<? super T> type, Supplier<T> fallback) {
_With.requires(fallback, "fallback");
@@ -189,7 +188,6 @@ public final class _Context {
* otherwise throws the {@code onNotFound}'s result.
* @param type non-null
* @param onNotFound non-null
- * @return
* @throws Exception
*/
public static <T, E extends Exception> T getElseThrow (
@@ -206,7 +204,6 @@ public final class _Context {
* Gets a singleton instance of {@code type} if there is any,
* otherwise throws a NoSuchElementException.
* @param type non-null
- * @return
*/
public static <T> T getElseFail(Class<? super T> type) {
return _With.ifPresentElseThrow(getIfAny(type), ()->
@@ -272,7 +269,6 @@ public final class _Context {
* Looks up current thread's values for any instances that match the given type, as previously stored
* with {@link _Context#threadLocalPut(Class, Object)}.
* @param type - the key into the thread-local store
- * @return
*/
public static <T> Can<T> threadLocalGet(Class<? super T> type) {
return _Context_ThreadLocal.get(type);
@@ -283,7 +279,6 @@ public final class _Context {
* with {@link _Context#threadLocalPut(Class, Object)}.
* @param type - the key into the thread-local store
* @param requiredType - the required type of the elements in the returned bin
- * @return
*/
public static <T> Can<T> threadLocalSelect(Class<? super T> type, Class<? super T> requiredType) {
return _Context_ThreadLocal.select(type, requiredType);
@@ -342,7 +337,6 @@ public final class _Context {
* <b>Initialize</b> the class, that is, all static initializers will be run. <br/>
* (For details on initialize see Section 12.4 of The Java Language Specification)
* @param className
- * @return
* @throws ClassNotFoundException
*/
public static Class<?> loadClassAndInitialize(String className) throws ClassNotFoundException{
@@ -374,8 +368,4 @@ public final class _Context {
}
-
-
-
-
}
diff --git a/commons/src/main/java/org/apache/isis/commons/internal/context/_Plugin.java b/commons/src/main/java/org/apache/isis/commons/internal/context/_Plugin.java
index 33354b7..806f5e1 100644
--- a/commons/src/main/java/org/apache/isis/commons/internal/context/_Plugin.java
+++ b/commons/src/main/java/org/apache/isis/commons/internal/context/_Plugin.java
@@ -82,7 +82,6 @@ public final class _Plugin {
* @param pluginClass
* @param onAmbiguity what to do if more than one matching plugin is found
* @param onNotFound what to do if no matching plugin is found
- * @return
*/
public static <S> S getOrElse(Class<S> pluginClass, Function<Set<S>, S> onAmbiguity, Supplier<S> onNotFound){
@@ -153,7 +152,6 @@ public final class _Plugin {
* @param pluginClass
* @param classPath
* @param pluginFullyQualifiedClassName
- * @return
*/
public static <S> S load(Class<S> pluginInterfaceClass, File classPath, String pluginFullyQualifiedClassName) {
diff --git a/commons/src/main/java/org/apache/isis/commons/internal/functions/_Functions.java b/commons/src/main/java/org/apache/isis/commons/internal/functions/_Functions.java
index 1cc51e8..d8f41a6 100644
--- a/commons/src/main/java/org/apache/isis/commons/internal/functions/_Functions.java
+++ b/commons/src/main/java/org/apache/isis/commons/internal/functions/_Functions.java
@@ -53,7 +53,6 @@ public final class _Functions {
* Converts an IndexAwareFunction into a Function, having its index start at 0,
* and incremented after each function call.
* @param indexAwareFunction
- * @return
*/
public static <T, R> Function<T, R> indexAwareToFunction(IndexAwareFunction<T, R> indexAwareFunction){
return new _Functions_IndexAwareFunctionAdapter<T, R>(indexAwareFunction);
@@ -204,7 +203,5 @@ public final class _Functions {
};
}
- // --
-
}
diff --git a/commons/src/main/java/org/apache/isis/commons/internal/ioc/_IocContainer.java b/commons/src/main/java/org/apache/isis/commons/internal/ioc/_IocContainer.java
index 52e6980..773f91a 100644
--- a/commons/src/main/java/org/apache/isis/commons/internal/ioc/_IocContainer.java
+++ b/commons/src/main/java/org/apache/isis/commons/internal/ioc/_IocContainer.java
@@ -66,7 +66,6 @@ public interface _IocContainer {
* @param <T>
* @param requiredType
* @param qualifiersRequired - if contains annotations, that are not qualifiers, these are just ignored
- * @return
*/
<T> Can<T> select(Class<T> requiredType, Annotation[] qualifiersRequired);
diff --git a/commons/src/main/java/org/apache/isis/commons/internal/memento/_Mementos.java b/commons/src/main/java/org/apache/isis/commons/internal/memento/_Mementos.java
index d2fcb7d..dc3d3d0 100644
--- a/commons/src/main/java/org/apache/isis/commons/internal/memento/_Mementos.java
+++ b/commons/src/main/java/org/apache/isis/commons/internal/memento/_Mementos.java
@@ -66,7 +66,6 @@ public final class _Mementos {
* Returns the Object associated with {@code name}
* @param name
* @param cls the expected type which to cast the retrieved value to (required)
- * @return
*/
public <T> T get(String name, Class<T> cls);
@@ -100,7 +99,6 @@ public final class _Mementos {
* Converts the value into a {@link Serializable} that is write-able to an {@link ObjectOutput}.<br/>
* Note: write and read are complementary operators.
* @param value
- * @return
*/
public Serializable write(Object value);
@@ -110,7 +108,6 @@ public final class _Mementos {
* Note: write and read are complementary operators.
* @param cls the expected type which to cast the {@code value} to (required)
* @param value
- * @return
*/
public <T> T read(Class<T> cls, Serializable value);
}
diff --git a/commons/src/main/java/org/apache/isis/commons/internal/reflection/_Reflect.java b/commons/src/main/java/org/apache/isis/commons/internal/reflection/_Reflect.java
index ff6834c..fc2c175 100644
--- a/commons/src/main/java/org/apache/isis/commons/internal/reflection/_Reflect.java
+++ b/commons/src/main/java/org/apache/isis/commons/internal/reflection/_Reflect.java
@@ -98,7 +98,6 @@ public final class _Reflect {
/**
* Whether member name equals given {@code memberName}
* @param memberName
- * @return
*/
public static <T extends Member> Predicate<T> withName(final String memberName) {
_With.requires(memberName, "memberName");
@@ -108,7 +107,6 @@ public final class _Reflect {
/**
* Whether member name starts with given {@code prefix}
* @param prefix
- * @return
*/
public static <T extends Member> Predicate<T> withPrefix(final String prefix) {
_With.requires(prefix, "prefix");
@@ -118,7 +116,6 @@ public final class _Reflect {
/**
* Whether method parameters count equal to given {@code count}
* @param count
- * @return
*/
public static Predicate<Method> withMethodParametersCount(final int count) {
return (Method m) -> m != null && m.getParameterTypes().length == count;
@@ -127,7 +124,6 @@ public final class _Reflect {
/**
* Whether field type is assignable to given {@code type}
* @param type
- * @return
*/
public static <T> Predicate<Field> withTypeAssignableTo(final Class<T> type) {
_With.requires(type, "type");
@@ -140,7 +136,6 @@ public final class _Reflect {
* Stream fields of given {@code type}
* @param type (nullable)
* @param ignoreAccess - whether to include non-public members
- * @return
*/
public static Stream<Field> streamFields(
@Nullable Class<?> type,
@@ -159,7 +154,6 @@ public final class _Reflect {
* Stream all fields of given {@code type}, up the super class hierarchy.
* @param type (nullable)
* @param ignoreAccess - whether to include non-public members
- * @return
*/
public static Stream<Field> streamAllFields(
@Nullable Class<?> type,
diff --git a/commons/src/main/java/org/apache/isis/commons/internal/resources/_Json.java b/commons/src/main/java/org/apache/isis/commons/internal/resources/_Json.java
index e8d857f..f9cb856 100644
--- a/commons/src/main/java/org/apache/isis/commons/internal/resources/_Json.java
+++ b/commons/src/main/java/org/apache/isis/commons/internal/resources/_Json.java
@@ -60,7 +60,6 @@ public class _Json {
* @param <T>
* @param clazz
* @param content
- * @return
*/
public static <T> Result<T> readJson(final Class<T> clazz, final InputStream content) {
return Result.of(()->_readJson(clazz, content));
@@ -80,7 +79,6 @@ public class _Json {
* @param <T>
* @param elementType
* @param content
- * @return
*/
public static <T> Result<List<T>> readJsonList(final Class<T> clazz, final InputStream content) {
return Result.of(()->_readJsonList(clazz, content));
@@ -101,7 +99,6 @@ public class _Json {
* @param <T>
* @param clazz
* @param content
- * @return
*/
public static <T> Result<T> readJson(final Class<T> clazz, final String content) {
return Result.of(()->_readJson(clazz, content));
@@ -121,7 +118,6 @@ public class _Json {
* @param <T>
* @param elementType
* @param content
- * @return
*/
public static <T> Result<List<T>> readJsonList(final Class<T> clazz, final String content) {
return Result.of(()->_readJsonList(clazz, content));
@@ -142,7 +138,6 @@ public class _Json {
* @param <T>
* @param clazz
* @param content
- * @return
*/
public static <T> Result<T> readJson(final Class<T> clazz, final File content) {
return Result.of(()->_readJson(clazz, content));
@@ -162,7 +157,6 @@ public class _Json {
* @param <T>
* @param elementType
* @param content
- * @return
*/
public static <T> Result<List<T>> readJsonList(final Class<T> clazz, final File content) {
return Result.of(()->_readJsonList(clazz, content));
@@ -182,7 +176,6 @@ public class _Json {
* @param <T>
* @param clazz
* @param content
- * @return
*/
public static <T> Result<T> readJson(final Class<T> clazz, final byte[] content) {
return Result.of(()->_readJson(clazz, content));
@@ -202,7 +195,6 @@ public class _Json {
* @param <T>
* @param elementType
* @param content
- * @return
*/
public static <T> Result<List<T>> readJsonList(final Class<T> clazz, final byte[] content) {
return Result.of(()->_readJsonList(clazz, content));
diff --git a/commons/src/main/java/org/apache/isis/commons/internal/resources/_Resources.java b/commons/src/main/java/org/apache/isis/commons/internal/resources/_Resources.java
index c95d6fa..8129510 100644
--- a/commons/src/main/java/org/apache/isis/commons/internal/resources/_Resources.java
+++ b/commons/src/main/java/org/apache/isis/commons/internal/resources/_Resources.java
@@ -129,7 +129,6 @@ public final class _Resources {
*
* @param extendee
* @param suffix
- * @return
*/
public static String combinePath(@Nullable String extendee, @Nullable String suffix) {
return _Strings.combineWithDelimiter(extendee, suffix, "/");
diff --git a/commons/src/main/java/org/apache/isis/commons/internal/resources/_Yaml.java b/commons/src/main/java/org/apache/isis/commons/internal/resources/_Yaml.java
index 0d4e524..761f280 100644
--- a/commons/src/main/java/org/apache/isis/commons/internal/resources/_Yaml.java
+++ b/commons/src/main/java/org/apache/isis/commons/internal/resources/_Yaml.java
@@ -58,7 +58,6 @@ public class _Yaml {
* @param <T>
* @param clazz
* @param content
- * @return
*/
public static <T> Result<T> readYaml(final Class<T> clazz, InputStream content) {
return Result.of(()->_readYaml(clazz, content));
@@ -77,7 +76,6 @@ public class _Yaml {
* @param <T>
* @param clazz
* @param content
- * @return
*/
public static <T> Result<T> readYaml(final Class<T> clazz, String content) {
return Result.of(()->_readYaml(clazz, content));
@@ -98,7 +96,6 @@ public class _Yaml {
* @param <T>
* @param clazz
* @param content
- * @return
*/
public static <T> Result<T> readYaml(final Class<T> clazz, File content) {
return Result.of(()->_readYaml(clazz, content));
@@ -119,7 +116,6 @@ public class _Yaml {
* @param <T>
* @param clazz
* @param content
- * @return
*/
public static <T> Result<T> readYaml(final Class<T> clazz, byte[] content) {
return Result.of(()->_readYaml(clazz, content));
diff --git a/core/config/src/main/java/org/apache/isis/core/config/IsisConfiguration.java b/core/config/src/main/java/org/apache/isis/core/config/IsisConfiguration.java
index 0caef48..628ede2 100644
--- a/core/config/src/main/java/org/apache/isis/core/config/IsisConfiguration.java
+++ b/core/config/src/main/java/org/apache/isis/core/config/IsisConfiguration.java
@@ -2517,7 +2517,6 @@ public class IsisConfiguration {
/**
* Whether enough information has been defined for the credit to be appear.
- * @return
*/
public boolean isDefined() { return (name != null || image != null) && url != null; }
}
diff --git a/core/config/src/main/java/org/apache/isis/core/config/beans/IsisBeanTypeRegistry.java b/core/config/src/main/java/org/apache/isis/core/config/beans/IsisBeanTypeRegistry.java
index 641b696..858ced9 100644
--- a/core/config/src/main/java/org/apache/isis/core/config/beans/IsisBeanTypeRegistry.java
+++ b/core/config/src/main/java/org/apache/isis/core/config/beans/IsisBeanTypeRegistry.java
@@ -45,7 +45,6 @@ public interface IsisBeanTypeRegistry {
* recognized by the IoC container.
*
* @param type
- * @return
*/
default Optional<String> lookupManagedBeanNameForType(Class<?> type) {
return Optional.ofNullable(getManagedBeansContributing().get(type))
diff --git a/core/internaltestsupport/src/main/java/org/apache/isis/core/internaltestsupport/jmocking/JUnitRuleMockery2.java b/core/internaltestsupport/src/main/java/org/apache/isis/core/internaltestsupport/jmocking/JUnitRuleMockery2.java
index 913622d..0c1a921 100644
--- a/core/internaltestsupport/src/main/java/org/apache/isis/core/internaltestsupport/jmocking/JUnitRuleMockery2.java
+++ b/core/internaltestsupport/src/main/java/org/apache/isis/core/internaltestsupport/jmocking/JUnitRuleMockery2.java
@@ -265,7 +265,6 @@ public class JUnitRuleMockery2 extends JUnit4Mockery implements MethodRule {
/**
* Require one interaction
- * @return
*/
public Object oneOf(final Object mock) {
checking(expectationsWith(exp->exp.oneOf(mock)));
diff --git a/core/metamodel/src/main/java/org/apache/isis/core/metamodel/commons/StringExtensions.java b/core/metamodel/src/main/java/org/apache/isis/core/metamodel/commons/StringExtensions.java
index ee39806..4389e8e 100644
--- a/core/metamodel/src/main/java/org/apache/isis/core/metamodel/commons/StringExtensions.java
+++ b/core/metamodel/src/main/java/org/apache/isis/core/metamodel/commons/StringExtensions.java
@@ -180,7 +180,6 @@ public final class StringExtensions {
* Converts any <tt>\n</tt> to <tt>line.separator</tt>
*
* @param extendee
- * @return
*/
public static String lineSeparated(final String extendee) {
final StringBuilder buf = new StringBuilder();
@@ -240,7 +239,6 @@ public final class StringExtensions {
* Condenses any whitespace to a single character
*
* @param extendee
- * @return
*/
public static String normalized(@javax.annotation.Nullable final String extendee) {
return _Strings.asNormalized.apply(extendee);
diff --git a/core/metamodel/src/main/java/org/apache/isis/core/metamodel/consent/ConsentAbstract.java b/core/metamodel/src/main/java/org/apache/isis/core/metamodel/consent/ConsentAbstract.java
index 995356c..eef4f6b 100644
--- a/core/metamodel/src/main/java/org/apache/isis/core/metamodel/consent/ConsentAbstract.java
+++ b/core/metamodel/src/main/java/org/apache/isis/core/metamodel/consent/ConsentAbstract.java
@@ -143,8 +143,6 @@ public abstract class ConsentAbstract implements Serializable, Consent {
* reason} property with a description of the event. This has now been
* changed so that a non-<tt>null</tt> reason always implies a {@link Veto}.
* This property captures the description.
- *
- * @return
*/
@Override
public String getDescription() {
diff --git a/core/metamodel/src/main/java/org/apache/isis/core/metamodel/consent/InteractionResult.java b/core/metamodel/src/main/java/org/apache/isis/core/metamodel/consent/InteractionResult.java
index a72c0dc..08bf6ce 100644
--- a/core/metamodel/src/main/java/org/apache/isis/core/metamodel/consent/InteractionResult.java
+++ b/core/metamodel/src/main/java/org/apache/isis/core/metamodel/consent/InteractionResult.java
@@ -60,8 +60,6 @@ public class InteractionResult {
* That is, if still {@link State#ADVISING advising}, then copies over the
* details from this result into the contained {@link InteractionEvent}, and
* flips into {@link State#ADVISED advised (done)}.
- *
- * @return
*/
public InteractionEvent getInteractionEvent() {
if (state == State.ADVISING) {
diff --git a/core/metamodel/src/main/java/org/apache/isis/core/metamodel/consent/InteractionResultSet.java b/core/metamodel/src/main/java/org/apache/isis/core/metamodel/consent/InteractionResultSet.java
index bc35ff0..e25bf4e 100644
--- a/core/metamodel/src/main/java/org/apache/isis/core/metamodel/consent/InteractionResultSet.java
+++ b/core/metamodel/src/main/java/org/apache/isis/core/metamodel/consent/InteractionResultSet.java
@@ -52,8 +52,6 @@ public class InteractionResultSet {
* Vetoed if any of the {@link #add(InteractionResult) contained}
* {@link InteractionResult}s are also {@link InteractionResult#isVetoing()
* not empty}.
- *
- * @return
*/
public boolean isVetoed() {
for (final InteractionResult result : results) {
@@ -68,8 +66,6 @@ public class InteractionResultSet {
* Returns the {@link Consent} corresponding to
* {@link #getInteractionResult()}, or an {@link Allow} if there have been
* no {@link InteractionResult}s {@link #add(InteractionResult) added}.
- *
- * @return
*/
public Consent createConsent() {
final InteractionResult interactionResult = getInteractionResult();
@@ -86,8 +82,6 @@ public class InteractionResultSet {
* This will be the first {@link InteractionResult} that has vetoed the
* interaction, or the first {@link InteractionResult}
* {@link #add(InteractionResult) added} if none have vetoed.
- *
- * @return
*/
public InteractionResult getInteractionResult() {
for (final InteractionResult result : results) {
diff --git a/core/metamodel/src/main/java/org/apache/isis/core/metamodel/facetapi/Facet.java b/core/metamodel/src/main/java/org/apache/isis/core/metamodel/facetapi/Facet.java
index 34cd243..cd6855a 100644
--- a/core/metamodel/src/main/java/org/apache/isis/core/metamodel/facetapi/Facet.java
+++ b/core/metamodel/src/main/java/org/apache/isis/core/metamodel/facetapi/Facet.java
@@ -27,8 +27,6 @@ public interface Facet extends FacetWithAttributes {
/**
* The {@link FacetHolder holder} of this facet.
- *
- * @return
*/
FacetHolder getFacetHolder();
diff --git a/core/metamodel/src/main/java/org/apache/isis/core/metamodel/facets/all/deficiencies/DeficiencyFacet.java b/core/metamodel/src/main/java/org/apache/isis/core/metamodel/facets/all/deficiencies/DeficiencyFacet.java
index 5c28eaa..a9ccafc 100644
--- a/core/metamodel/src/main/java/org/apache/isis/core/metamodel/facets/all/deficiencies/DeficiencyFacet.java
+++ b/core/metamodel/src/main/java/org/apache/isis/core/metamodel/facets/all/deficiencies/DeficiencyFacet.java
@@ -59,7 +59,6 @@ public final class DeficiencyFacet implements Facet {
* @param facetHolder
* @param deficiencyOrigin
* @param deficiencyMessage
- * @return
*/
public static DeficiencyFacet appendTo(
@NonNull FacetHolder facetHolder,
diff --git a/core/metamodel/src/main/java/org/apache/isis/core/metamodel/facets/object/defaults/DefaultedFacet.java b/core/metamodel/src/main/java/org/apache/isis/core/metamodel/facets/object/defaults/DefaultedFacet.java
index 1ff4722..28d1613 100644
--- a/core/metamodel/src/main/java/org/apache/isis/core/metamodel/facets/object/defaults/DefaultedFacet.java
+++ b/core/metamodel/src/main/java/org/apache/isis/core/metamodel/facets/object/defaults/DefaultedFacet.java
@@ -40,8 +40,6 @@ public interface DefaultedFacet extends Facet {
/**
* The default (as a pojo, not a {@link ManagedObject}).
- *
- * @return
*/
Object getDefault();
}
diff --git a/core/metamodel/src/main/java/org/apache/isis/core/metamodel/facets/object/entity/EntityFacet.java b/core/metamodel/src/main/java/org/apache/isis/core/metamodel/facets/object/entity/EntityFacet.java
index 78517ac..28b7f6e 100644
--- a/core/metamodel/src/main/java/org/apache/isis/core/metamodel/facets/object/entity/EntityFacet.java
+++ b/core/metamodel/src/main/java/org/apache/isis/core/metamodel/facets/object/entity/EntityFacet.java
@@ -50,7 +50,6 @@ public interface EntityFacet extends Facet {
/**
* Whether given method originates from byte code mangling.
* @param method
- * @return
*/
boolean isProxyEnhancement(Method method);
diff --git a/core/metamodel/src/main/java/org/apache/isis/core/metamodel/facets/object/navparent/NavigableParentFacet.java b/core/metamodel/src/main/java/org/apache/isis/core/metamodel/facets/object/navparent/NavigableParentFacet.java
index 52dae07..99d6f95 100644
--- a/core/metamodel/src/main/java/org/apache/isis/core/metamodel/facets/object/navparent/NavigableParentFacet.java
+++ b/core/metamodel/src/main/java/org/apache/isis/core/metamodel/facets/object/navparent/NavigableParentFacet.java
@@ -36,7 +36,6 @@ public interface NavigableParentFacet extends Facet {
* Returns the navigable parent (a domain-object or a domain-view-model) for the target object
* or null if there is no parent.
* @param object
- * @return
*/
Object navigableParent(final Object object);
diff --git a/core/metamodel/src/main/java/org/apache/isis/core/metamodel/objectmanager/ObjectManager.java b/core/metamodel/src/main/java/org/apache/isis/core/metamodel/objectmanager/ObjectManager.java
index e76cf5b..36e544d 100644
--- a/core/metamodel/src/main/java/org/apache/isis/core/metamodel/objectmanager/ObjectManager.java
+++ b/core/metamodel/src/main/java/org/apache/isis/core/metamodel/objectmanager/ObjectManager.java
@@ -61,7 +61,6 @@ public interface ObjectManager {
/**
* Creates and initializes an instance conforming to given request parameters.
* @param objectCreateRequest
- * @return
*/
public default ManagedObject createObject(ObjectCreator.Request objectCreateRequest) {
return getObjectCreator().createObject(objectCreateRequest);
@@ -70,7 +69,6 @@ public interface ObjectManager {
/**
* Loads an instance identified with given request parameters.
* @param objectLoadRequest
- * @return
*/
public default ManagedObject loadObject(ObjectLoader.Request objectLoadRequest) {
return getObjectLoader().loadObject(objectLoadRequest);
@@ -83,7 +81,6 @@ public interface ObjectManager {
/**
* Returns an object identifier for the instance.
* @param managedObject
- * @return
*/
public default RootOid identifyObject(ManagedObject managedObject) {
return getObjectIdentifier().identifyObject(managedObject);
diff --git a/core/metamodel/src/main/java/org/apache/isis/core/metamodel/objectmanager/serialize/ObjectSerializer.java b/core/metamodel/src/main/java/org/apache/isis/core/metamodel/objectmanager/serialize/ObjectSerializer.java
index 712d313..137d70e 100644
--- a/core/metamodel/src/main/java/org/apache/isis/core/metamodel/objectmanager/serialize/ObjectSerializer.java
+++ b/core/metamodel/src/main/java/org/apache/isis/core/metamodel/objectmanager/serialize/ObjectSerializer.java
@@ -37,7 +37,6 @@ public interface ObjectSerializer {
* @apiNote Rather use the more convenient specialized variants
* {@link #serialize(ManagedObject)} and {@link #deserialize(ObjectSpecification, byte[])}
* @param request
- * @return
*/
BiForm serializeObject(BiForm request);
diff --git a/core/metamodel/src/main/java/org/apache/isis/core/metamodel/spec/ManagedObject.java b/core/metamodel/src/main/java/org/apache/isis/core/metamodel/spec/ManagedObject.java
index 4a340a5..098c8bd 100644
--- a/core/metamodel/src/main/java/org/apache/isis/core/metamodel/spec/ManagedObject.java
+++ b/core/metamodel/src/main/java/org/apache/isis/core/metamodel/spec/ManagedObject.java
@@ -110,7 +110,6 @@ public interface ManagedObject {
* Optimized for cases, when the pojo's specification is already available.
* @param specification
* @param pojo - might also be a collection of pojos
- * @return
*/
public static ManagedObject of(
@NonNull ObjectSpecification specification,
@@ -160,7 +159,6 @@ public interface ManagedObject {
* For cases, when the pojo's specification is not available and needs to be looked up.
* @param specLoader
* @param pojo
- * @return
*/
public static ManagedObject of(
Function<Class<?>, ObjectSpecification> specLoader,
diff --git a/core/metamodel/src/main/java/org/apache/isis/core/metamodel/spec/ObjectSpecification.java b/core/metamodel/src/main/java/org/apache/isis/core/metamodel/spec/ObjectSpecification.java
index 6e23417..a492f44 100644
--- a/core/metamodel/src/main/java/org/apache/isis/core/metamodel/spec/ObjectSpecification.java
+++ b/core/metamodel/src/main/java/org/apache/isis/core/metamodel/spec/ObjectSpecification.java
@@ -129,7 +129,6 @@ extends
/**
* @param onType
- * @return
* @since 2.0
*/
public default Optional<MixedInMember> getMixedInMember(ObjectSpecification onType) {
@@ -141,7 +140,7 @@ extends
}
/**
- * @return
+ * @return Java class this specification is associated with
*/
Class<?> getCorrespondingClass();
@@ -234,7 +233,6 @@ extends
/**
* Returns this object's navigable parent, if any.
* @param object
- * @return
* @since 2.0
*/
Object getNavigableParent(Object object);
@@ -399,7 +397,6 @@ extends
* If this specification represents a bean, that is a managed bean, then
* returns the bean's name/id as recognized by the IoC container.
* <p>Otherwise returns {@code null}.
- * @return
*/
String getManagedBeanName();
@@ -467,7 +464,6 @@ extends
/**
* Introspecting up to the level required.
- * @return whether it's necessary to re-run validations.
* @since 2.0
*/
void introspectUpTo(IntrospectionState upTo);
diff --git a/core/metamodel/src/main/java/org/apache/isis/core/metamodel/spec/feature/ObjectAction.java b/core/metamodel/src/main/java/org/apache/isis/core/metamodel/spec/feature/ObjectAction.java
index 38bcdb0..c4febfa 100644
--- a/core/metamodel/src/main/java/org/apache/isis/core/metamodel/spec/feature/ObjectAction.java
+++ b/core/metamodel/src/main/java/org/apache/isis/core/metamodel/spec/feature/ObjectAction.java
@@ -203,8 +203,6 @@ public interface ObjectAction extends ObjectMember {
*
* <p>
* Implementations may build this array lazily or eagerly as required.
- *
- * @return
*/
Can<ObjectActionParameter> getParameters();
@@ -215,8 +213,6 @@ public interface ObjectAction extends ObjectMember {
/**
* Returns set of parameter information matching the supplied filter.
- *
- * @return
*/
Can<ObjectActionParameter> getParameters(Predicate<ObjectActionParameter> predicate);
diff --git a/core/metamodel/src/main/java/org/apache/isis/core/metamodel/spec/feature/ObjectActionParameter.java b/core/metamodel/src/main/java/org/apache/isis/core/metamodel/spec/feature/ObjectActionParameter.java
index 7c79f47..7b54257 100644
--- a/core/metamodel/src/main/java/org/apache/isis/core/metamodel/spec/feature/ObjectActionParameter.java
+++ b/core/metamodel/src/main/java/org/apache/isis/core/metamodel/spec/feature/ObjectActionParameter.java
@@ -142,7 +142,6 @@ public interface ObjectActionParameter extends ObjectFeature, CurrentHolder {
* @param head
* @param pendingArgs
* @param interactionInitiatedBy
- * @return
*/
Consent isVisible(
InteractionHead head,
@@ -154,7 +153,6 @@ public interface ObjectActionParameter extends ObjectFeature, CurrentHolder {
* @param head
* @param pendingArgs
* @param interactionInitiatedBy
- * @return
*/
Consent isUsable(
InteractionHead head,
@@ -167,7 +165,6 @@ public interface ObjectActionParameter extends ObjectFeature, CurrentHolder {
* @param head
* @param pendingArgs
* @param interactionInitiatedBy
- * @return
*/
Consent isValid(
InteractionHead head,
@@ -180,7 +177,6 @@ public interface ObjectActionParameter extends ObjectFeature, CurrentHolder {
* @param adapter
* @param proposedValue
* @param interactionInitiatedBy
- * @return
* @deprecated use variant with all pendingArgs instead
*/
@Deprecated
diff --git a/core/metamodel/src/main/java/org/apache/isis/core/metamodel/specloader/specimpl/OneToOneAssociationDefault.java b/core/metamodel/src/main/java/org/apache/isis/core/metamodel/specloader/specimpl/OneToOneAssociationDefault.java
index d6f2a6a..11f744a 100644
--- a/core/metamodel/src/main/java/org/apache/isis/core/metamodel/specloader/specimpl/OneToOneAssociationDefault.java
+++ b/core/metamodel/src/main/java/org/apache/isis/core/metamodel/specloader/specimpl/OneToOneAssociationDefault.java
@@ -164,7 +164,6 @@ implements OneToOneAssociation {
/**
* Sets up the {@link Command}, then delegates to the appropriate facet
* ({@link PropertySetterFacet} or {@link PropertyClearFacet}).
- * @return
*/
@Override
public ManagedObject set(
diff --git a/core/metamodel/src/main/java/org/apache/isis/core/metamodel/specloader/validator/ValidationFailures.java b/core/metamodel/src/main/java/org/apache/isis/core/metamodel/specloader/validator/ValidationFailures.java
index b520e62..b2c5943 100644
--- a/core/metamodel/src/main/java/org/apache/isis/core/metamodel/specloader/validator/ValidationFailures.java
+++ b/core/metamodel/src/main/java/org/apache/isis/core/metamodel/specloader/validator/ValidationFailures.java
@@ -64,7 +64,6 @@ public final class ValidationFailures implements Iterable<ValidationFailure> {
/**
* @param messageFormat to include {@code %d} for the message-index and {@code %s} for the message-string
- * @return
*/
public ArrayList<String> getMessages(String messageFormat) { // <-- ensure serializable result
val messages = _Lists.<String>newArrayList();
diff --git a/core/metamodel/src/main/java/org/apache/isis/core/metamodel/util/pchain/ParentChain.java b/core/metamodel/src/main/java/org/apache/isis/core/metamodel/util/pchain/ParentChain.java
index 5172650..4613d49 100644
--- a/core/metamodel/src/main/java/org/apache/isis/core/metamodel/util/pchain/ParentChain.java
+++ b/core/metamodel/src/main/java/org/apache/isis/core/metamodel/util/pchain/ParentChain.java
@@ -46,7 +46,6 @@ public interface ParentChain {
/**
* Returns the parent node of this {@code node} or {@code null} if {@code node} has no parent.
* @param node
- * @return
*/
public Object parentOf(Object node);
@@ -59,7 +58,6 @@ public interface ParentChain {
*
* @param startNode
* @param maxChainLength maximum length of the chain returned
- * @return
*/
public default Stream<Object> streamParentChainOf(Object startNode, int maxChainLength){
final Set<Object> chain = new LinkedHashSet<>();
diff --git a/core/runtimeservices/src/main/java/org/apache/isis/core/runtimeservices/wrapper/handlers/DomainObjectInvocationHandler.java b/core/runtimeservices/src/main/java/org/apache/isis/core/runtimeservices/wrapper/handlers/DomainObjectInvocationHandler.java
index ca4c6a1..74c5375 100644
--- a/core/runtimeservices/src/main/java/org/apache/isis/core/runtimeservices/wrapper/handlers/DomainObjectInvocationHandler.java
+++ b/core/runtimeservices/src/main/java/org/apache/isis/core/runtimeservices/wrapper/handlers/DomainObjectInvocationHandler.java
@@ -133,8 +133,6 @@ extends DelegatingInvocationHandlerDefault<T> {
* @param proxyObjectUnused - not used.
* @param method - the method invoked on the proxy
* @param args - the args to the method invoked on the proxy
- *
- * @return
* @throws Throwable
*/
@Override
diff --git a/examples/demo/domain/src/main/java/demoapp/dom/_infra/resources/MarkupVariableResolverService.java b/examples/demo/domain/src/main/java/demoapp/dom/_infra/resources/MarkupVariableResolverService.java
index 5ee382d..c3b628a 100644
--- a/examples/demo/domain/src/main/java/demoapp/dom/_infra/resources/MarkupVariableResolverService.java
+++ b/examples/demo/domain/src/main/java/demoapp/dom/_infra/resources/MarkupVariableResolverService.java
@@ -44,7 +44,6 @@ public class MarkupVariableResolverService {
/**
* For the given {@code input} replaces '${var-name}' with the variable's value.
* @param input
- * @return
*/
public String resolveVariables(String input) {
val stringRef = _Refs.objectRef(input);
diff --git a/extensions/core/command-log/impl/src/main/java/org/apache/isis/extensions/commandlog/impl/jdo/CommandJdoRepository.java b/extensions/core/command-log/impl/src/main/java/org/apache/isis/extensions/commandlog/impl/jdo/CommandJdoRepository.java
index d737427..8928ef1 100644
--- a/extensions/core/command-log/impl/src/main/java/org/apache/isis/extensions/commandlog/impl/jdo/CommandJdoRepository.java
+++ b/extensions/core/command-log/impl/src/main/java/org/apache/isis/extensions/commandlog/impl/jdo/CommandJdoRepository.java
@@ -213,8 +213,6 @@ public class CommandJdoRepository {
* secondary), or null if no HWM was found there.
* @param batchSize - to restrict the number returned (so that replay
* commands can be batched).
- *
- * @return
*/
public List<CommandJdo> findSince(final UUID uniqueId, final Integer batchSize) {
if(uniqueId == null) {
diff --git a/extensions/core/command-replay/primary/src/main/java/org/apache/isis/extensions/commandreplay/primary/restapi/CommandRetrievalService.java b/extensions/core/command-replay/primary/src/main/java/org/apache/isis/extensions/commandreplay/primary/restapi/CommandRetrievalService.java
index f92de9f..c1c8525 100644
--- a/extensions/core/command-replay/primary/src/main/java/org/apache/isis/extensions/commandreplay/primary/restapi/CommandRetrievalService.java
+++ b/extensions/core/command-replay/primary/src/main/java/org/apache/isis/extensions/commandreplay/primary/restapi/CommandRetrievalService.java
@@ -72,8 +72,6 @@ public class CommandRetrievalService {
*
* @param uniqueId - to search from. This transactionId will <i>not</i> be included in the response.
* @param batchSize - the maximum number of commands to return. If not specified, all found will be returned.
- *
- * @return
* @throws NotFoundException - if the command with specified transaction cannot be found.
*/
@Action(domainEvent = FindCommandsOnPrimaryFromDomainEvent.class, semantics = SemanticsOf.SAFE)
diff --git a/extensions/core/command-replay/primary/src/main/java/org/apache/isis/extensions/commandreplay/primary/ui/CommandReplayOnPrimaryService.java b/extensions/core/command-replay/primary/src/main/java/org/apache/isis/extensions/commandreplay/primary/ui/CommandReplayOnPrimaryService.java
index 54ef737..54dbd6a 100644
--- a/extensions/core/command-replay/primary/src/main/java/org/apache/isis/extensions/commandreplay/primary/ui/CommandReplayOnPrimaryService.java
+++ b/extensions/core/command-replay/primary/src/main/java/org/apache/isis/extensions/commandreplay/primary/ui/CommandReplayOnPrimaryService.java
@@ -95,8 +95,6 @@ public class CommandReplayOnPrimaryService {
*
* @param uniqueId - to search from. This transactionId will <i>not</i> be included in the response.
* @param batchSize - the maximum number of commands to return. If not specified, all found will be returned.
- *
- * @return
* @throws NotFoundException - if the command with specified transaction cannot be found.
*/
@Action(domainEvent = FindCommandsDomainEvent.class, semantics = SemanticsOf.SAFE)
@@ -125,8 +123,6 @@ public class CommandReplayOnPrimaryService {
*
* @param uniqueId - to search from. This transactionId will <i>not</i> be included in the response.
* @param batchSize - the maximum number of commands to return. If not specified, all found will be returned.
- *
- * @return
* @throws NotFoundException - if the command with specified transaction cannot be found.
*/
@Action(domainEvent = DownloadCommandsDomainEvent.class, semantics = SemanticsOf.SAFE)
@@ -167,8 +163,6 @@ public class CommandReplayOnPrimaryService {
* <code>application/xml;profile="urn:org.restfulobjects:repr-types/action-result";x-ro-domain-type="org.apache.isis.schema.cmd.v1.CommandDto"</code>
*
* @param uniqueId - to download.
- *
- * @return
* @throws NotFoundException - if the command with specified transaction cannot be found.
*/
@Action(domainEvent = DownloadCommandByIdDomainEvent.class, semantics = SemanticsOf.SAFE)
diff --git a/extensions/core/command-replay/secondary/src/main/java/org/apache/isis/extensions/commandreplay/secondary/fetch/CommandFetcher.java b/extensions/core/command-replay/secondary/src/main/java/org/apache/isis/extensions/commandreplay/secondary/fetch/CommandFetcher.java
index c1daa70..a6c7d95 100644
--- a/extensions/core/command-replay/secondary/src/main/java/org/apache/isis/extensions/commandreplay/secondary/fetch/CommandFetcher.java
+++ b/extensions/core/command-replay/secondary/src/main/java/org/apache/isis/extensions/commandreplay/secondary/fetch/CommandFetcher.java
@@ -64,7 +64,6 @@ public class CommandFetcher {
* Replicates a single command.
*
* @param previousHwmIfAny
- * @return
* @throws StatusException
*/
public List<CommandDto> fetchCommand(
@@ -81,8 +80,8 @@ public class CommandFetcher {
/**
* @return - the commands, or <tt>null</tt> if none were found
- * @throws StatusException
* @param previousHwmIfAny
+ * @throws StatusException
*/
private CommandsDto fetchCommands(final CommandJdo previousHwmIfAny)
throws StatusException {
diff --git a/extensions/core/command-replay/secondary/src/main/java/org/apache/isis/extensions/commandreplay/secondary/spi/ReplayCommandExecutionController.java b/extensions/core/command-replay/secondary/src/main/java/org/apache/isis/extensions/commandreplay/secondary/spi/ReplayCommandExecutionController.java
index f8bf43d..9b9d6e4 100644
--- a/extensions/core/command-replay/secondary/src/main/java/org/apache/isis/extensions/commandreplay/secondary/spi/ReplayCommandExecutionController.java
+++ b/extensions/core/command-replay/secondary/src/main/java/org/apache/isis/extensions/commandreplay/secondary/spi/ReplayCommandExecutionController.java
@@ -38,7 +38,6 @@ public interface ReplayCommandExecutionController {
/**
* The current state, or <tt>null</tt> if the service implementing this SPI has not yet been initialized.
- * @return
*/
State getState();
diff --git a/incubator/viewers/javafx/ui/src/main/java/org/apache/isis/incubator/viewer/javafx/ui/components/UiComponentHandlerFx.java b/incubator/viewers/javafx/ui/src/main/java/org/apache/isis/incubator/viewer/javafx/ui/components/UiComponentHandlerFx.java
index 38e279c..253be00 100644
--- a/incubator/viewers/javafx/ui/src/main/java/org/apache/isis/incubator/viewer/javafx/ui/components/UiComponentHandlerFx.java
+++ b/incubator/viewers/javafx/ui/src/main/java/org/apache/isis/incubator/viewer/javafx/ui/components/UiComponentHandlerFx.java
@@ -32,7 +32,6 @@ extends UiComponentFactory.Handler<Node> {
* Converts given {@code bindingConverter} to {@link StringConverter} from JavaFX Universe
* @param <T>
* @param bindingConverter
- * @return
*/
default <T> StringConverter<T> toJavaFxStringConverter(
final @NonNull BindingConverter<T> bindingConverter) {
diff --git a/mappings/restclient/applib/src/main/java/org/apache/isis/extensions/restclient/ResponseDigest.java b/mappings/restclient/applib/src/main/java/org/apache/isis/extensions/restclient/ResponseDigest.java
index a881f87..8792c30 100644
--- a/mappings/restclient/applib/src/main/java/org/apache/isis/extensions/restclient/ResponseDigest.java
+++ b/mappings/restclient/applib/src/main/java/org/apache/isis/extensions/restclient/ResponseDigest.java
@@ -59,7 +59,6 @@ public class ResponseDigest<T> {
* @param <T>
* @param response
* @param entityType
- * @return
*/
public static <T> ResponseDigest<T> of(
@NonNull final Response response,
@@ -74,7 +73,6 @@ public class ResponseDigest<T> {
* @param response
* @param entityType
* @param genericType
- * @return
*/
public static <T> ResponseDigest<T> ofList(
@NonNull final Response response,
diff --git a/persistence/jdo/provider/src/main/java/org/apache/isis/persistence/jdo/provider/persistence/HasPersistenceManager.java b/persistence/jdo/provider/src/main/java/org/apache/isis/persistence/jdo/provider/persistence/HasPersistenceManager.java
index a9b6646..dc07ca5 100644
--- a/persistence/jdo/provider/src/main/java/org/apache/isis/persistence/jdo/provider/persistence/HasPersistenceManager.java
+++ b/persistence/jdo/provider/src/main/java/org/apache/isis/persistence/jdo/provider/persistence/HasPersistenceManager.java
@@ -31,7 +31,6 @@ public interface HasPersistenceManager {
* Not type safe. For type-safe queries use <br/><br/> {@code pm().newNamedQuery(cls, queryName)}
* @param cls
* @param queryName
- * @return
*/
default <T> javax.jdo.Query<T> newJdoNamedQuery(Class<T> cls, String queryName){
return getPersistenceManager().newNamedQuery(cls, queryName);
@@ -40,7 +39,6 @@ public interface HasPersistenceManager {
/**
* Not type safe. For type-safe queries use <br/><br/> {@code pm().newQuery(cls, queryName)}
* @param cls
- * @return
*/
default <T> javax.jdo.Query<T> newJdoQuery(Class<T> cls){
return getPersistenceManager().newQuery(cls);
@@ -50,7 +48,6 @@ public interface HasPersistenceManager {
* Not type safe. For type-safe queries use <br/><br/> {@code pm().newQuery(cls, filter)}
* @param cls
* @param filter
- * @return
*/
default <T> javax.jdo.Query<T> newJdoQuery(Class<T> cls, String filter){
return getPersistenceManager().newQuery(cls, filter);
diff --git a/subdomains/base/applib/src/main/java/org/apache/isis/subdomains/base/applib/valuetypes/AbstractInterval.java b/subdomains/base/applib/src/main/java/org/apache/isis/subdomains/base/applib/valuetypes/AbstractInterval.java
index 9374522..c9d61f9 100644
--- a/subdomains/base/applib/src/main/java/org/apache/isis/subdomains/base/applib/valuetypes/AbstractInterval.java
+++ b/subdomains/base/applib/src/main/java/org/apache/isis/subdomains/base/applib/valuetypes/AbstractInterval.java
@@ -104,7 +104,6 @@ public abstract class AbstractInterval<T extends AbstractInterval<T>> {
* Does this date contain the specified time interval.
*
* @param date
- * @return
*/
public boolean contains(final LocalDate date) {
if (date == null){
@@ -126,7 +125,6 @@ public abstract class AbstractInterval<T extends AbstractInterval<T>> {
* Does this time interval contain the specified time interval.
*
* @param localDateInterval
- * @return
*/
public boolean contains(final T localDateInterval) {
return asInterval().contains(localDateInterval.asInterval());
@@ -134,8 +132,6 @@ public abstract class AbstractInterval<T extends AbstractInterval<T>> {
/**
* The duration in days
- *
- * @return
*/
public int days() {
if (isInfinite()) {
@@ -187,7 +183,6 @@ public abstract class AbstractInterval<T extends AbstractInterval<T>> {
* Gets the overlap between this interval and another interval.
*
* @param otherInterval
- * @return
*/
@SuppressWarnings("unchecked")
public T overlap(final T otherInterval) {
@@ -220,7 +215,6 @@ public abstract class AbstractInterval<T extends AbstractInterval<T>> {
* Does this time interval contain the specified time interval.
*
* @param interval
- * @return
*/
public boolean overlaps(final T interval) {
return asInterval().overlaps(interval.asInterval());
@@ -237,7 +231,6 @@ public abstract class AbstractInterval<T extends AbstractInterval<T>> {
* Does this interval is within the specified interval
*
* @param interval
- * @return
*/
public boolean within(final T interval) {
return interval.asInterval().contains(asInterval());
diff --git a/subdomains/base/applib/src/main/java/org/apache/isis/subdomains/base/applib/valuetypes/LocalDateInterval.java b/subdomains/base/applib/src/main/java/org/apache/isis/subdomains/base/applib/valuetypes/LocalDateInterval.java
index 8a1c2fb..44a468d 100644
--- a/subdomains/base/applib/src/main/java/org/apache/isis/subdomains/base/applib/valuetypes/LocalDateInterval.java
+++ b/subdomains/base/applib/src/main/java/org/apache/isis/subdomains/base/applib/valuetypes/LocalDateInterval.java
@@ -109,8 +109,7 @@ public class LocalDateInterval extends AbstractInterval<LocalDateInterval>{
*
* Since this method is only used for testing it's not heavily guarded against illegal arguments
*
- * @param input a string with format yyyy-mm-dd/yyyy-mm-dd, end date is excluding
- * @return
+ * @param input a string with format {@literal yyyy-mm-dd/yyyy-mm-dd}, end date is excluding
*/
public static LocalDateInterval parseString(final String input) {
String[] values = input.split("/");
@@ -125,7 +124,6 @@ public class LocalDateInterval extends AbstractInterval<LocalDateInterval>{
* Parse a string to a LocalDate
*
* @param input a string representing a parsable LocalDate, "*" or "----------" returns null
- * @return
*/
private static LocalDate parseLocalDate(final String input) {
if (input.contains("--") || input.contains("*")) {
@@ -136,10 +134,9 @@ public class LocalDateInterval extends AbstractInterval<LocalDateInterval>{
/**
- * Returns an end date given the start date of the next adjoining interverval
+ * Returns an end date given the start date of the next adjoining interval
*
* @param date
- * @return
*/
public static LocalDate endDateFromStartDate(LocalDate date) {
return new LocalDateInterval(date, null).endDateFromStartDate();
diff --git a/subdomains/zip/applib/src/main/java/org/apache/isis/extensions/zip/dom/impl/ZipService.java b/subdomains/zip/applib/src/main/java/org/apache/isis/extensions/zip/dom/impl/ZipService.java
index e885241..c5b0879 100644
--- a/subdomains/zip/applib/src/main/java/org/apache/isis/extensions/zip/dom/impl/ZipService.java
+++ b/subdomains/zip/applib/src/main/java/org/apache/isis/extensions/zip/dom/impl/ZipService.java
@@ -90,7 +90,6 @@ public class ZipService {
* Similar to {@link #zipNamedFiles(List)}, but uses simple byte[] as the input, rather than files.
*
* @param bytesAndNameList
- * @return
*/
public byte[] zipNamedBytes(final List<BytesAndName> bytesAndNameList) {
diff --git a/testing/fixtures/applib/src/main/java/org/apache/isis/testing/fixtures/applib/clock/Clock.java b/testing/fixtures/applib/src/main/java/org/apache/isis/testing/fixtures/applib/clock/Clock.java
index ac9d5ad..22b7d49 100644
--- a/testing/fixtures/applib/src/main/java/org/apache/isis/testing/fixtures/applib/clock/Clock.java
+++ b/testing/fixtures/applib/src/main/java/org/apache/isis/testing/fixtures/applib/clock/Clock.java
@@ -57,8 +57,6 @@ public abstract class Clock {
* Unless it has been otherwise created, will lazily instantiate an
* implementation that just delegate to the computer's own system clock (as
* per {@link System#currentTimeMillis()}.
- *
- * @return
*/
public static final Clock getInstance() {
if (!isInitialized()) {
diff --git a/testing/fixtures/applib/src/main/java/org/apache/isis/testing/fixtures/applib/fixturescripts/FixtureScripts.java b/testing/fixtures/applib/src/main/java/org/apache/isis/testing/fixtures/applib/fixturescripts/FixtureScripts.java
index b6dbf01..c45f88a 100644
--- a/testing/fixtures/applib/src/main/java/org/apache/isis/testing/fixtures/applib/fixturescripts/FixtureScripts.java
+++ b/testing/fixtures/applib/src/main/java/org/apache/isis/testing/fixtures/applib/fixturescripts/FixtureScripts.java
@@ -380,7 +380,6 @@ public class FixtureScripts {
* Runs the builderScript within its own transactional boundary.
* @param <T>
* @param builderScript
- * @return
*/
@Programmatic
public <T> T runBuilder(final BuilderScriptAbstract<T> builderScript) {
@@ -398,7 +397,6 @@ public class FixtureScripts {
* The caller is responsible to provide a transactional context/boundary.
* @param <T>
* @param builderScript
- * @return
*/
@Programmatic
public <T> T runBuilderScriptNonTransactional(final BuilderScriptAbstract<T> builderScript) {
diff --git a/testing/integtestsupport/applib/src/main/java/org/apache/isis/testing/integtestsupport/applib/ThrowableMatchers.java b/testing/integtestsupport/applib/src/main/java/org/apache/isis/testing/integtestsupport/applib/ThrowableMatchers.java
index fe79078..c71c3a3 100644
--- a/testing/integtestsupport/applib/src/main/java/org/apache/isis/testing/integtestsupport/applib/ThrowableMatchers.java
+++ b/testing/integtestsupport/applib/src/main/java/org/apache/isis/testing/integtestsupport/applib/ThrowableMatchers.java
@@ -35,7 +35,6 @@ public class ThrowableMatchers {
/**
* Matches when the exception's causal chain contains the given {@code type}
* @param type
- * @return
*/
public static TypeSafeMatcher<Throwable> causedBy(final Class<? extends Throwable> type) {
return new TypeSafeMatcher<Throwable>() {
diff --git a/testing/unittestsupport/applib/src/main/java/org/apache/isis/testing/unittestsupport/applib/core/jmocking/JUnitRuleMockery2.java b/testing/unittestsupport/applib/src/main/java/org/apache/isis/testing/unittestsupport/applib/core/jmocking/JUnitRuleMockery2.java
index 4347610..620e8dd 100644
--- a/testing/unittestsupport/applib/src/main/java/org/apache/isis/testing/unittestsupport/applib/core/jmocking/JUnitRuleMockery2.java
+++ b/testing/unittestsupport/applib/src/main/java/org/apache/isis/testing/unittestsupport/applib/core/jmocking/JUnitRuleMockery2.java
@@ -260,7 +260,6 @@ public class JUnitRuleMockery2 extends JUnit4Mockery implements MethodRule {
/**
* Require one interaction
- * @return
*/
public Object oneOf(final Object mock) {
checking(expectationsWith(exp->exp.oneOf(mock)));
diff --git a/viewers/common/src/main/java/org/apache/isis/viewer/common/model/object/ObjectUiModel.java b/viewers/common/src/main/java/org/apache/isis/viewer/common/model/object/ObjectUiModel.java
index 712925e..3fdf28e 100644
--- a/viewers/common/src/main/java/org/apache/isis/viewer/common/model/object/ObjectUiModel.java
+++ b/viewers/common/src/main/java/org/apache/isis/viewer/common/model/object/ObjectUiModel.java
@@ -93,8 +93,6 @@ public interface ObjectUiModel {
* Similar to {@link #mustBeEditable()}, though not called from the same locations.
*
* My suspicion is that it amounts to more or less the same set of conditions.
- *
- * @return
*/
boolean isInlinePrompt();
diff --git a/viewers/restfulobjects/applib/src/main/java/org/apache/isis/viewer/restfulobjects/applib/LinkRepresentation.java b/viewers/restfulobjects/applib/src/main/java/org/apache/isis/viewer/restfulobjects/applib/LinkRepresentation.java
index d712591..4f43e76 100644
--- a/viewers/restfulobjects/applib/src/main/java/org/apache/isis/viewer/restfulobjects/applib/LinkRepresentation.java
+++ b/viewers/restfulobjects/applib/src/main/java/org/apache/isis/viewer/restfulobjects/applib/LinkRepresentation.java
@@ -98,8 +98,6 @@ public final class LinkRepresentation extends JsonRepresentation {
* <p>
* If there is no "arguments" node, then as a convenience will
* return an empty map.
- *
- * @return
*/
public JsonRepresentation getArguments() {
final JsonNode arguments = asObjectNode().get("arguments");
diff --git a/viewers/restfulobjects/applib/src/main/java/org/apache/isis/viewer/restfulobjects/applib/util/MediaTypes.java b/viewers/restfulobjects/applib/src/main/java/org/apache/isis/viewer/restfulobjects/applib/util/MediaTypes.java
index f1566a9..b6bfa2f 100644
--- a/viewers/restfulobjects/applib/src/main/java/org/apache/isis/viewer/restfulobjects/applib/util/MediaTypes.java
+++ b/viewers/restfulobjects/applib/src/main/java/org/apache/isis/viewer/restfulobjects/applib/util/MediaTypes.java
@@ -34,12 +34,10 @@ public class MediaTypes {
/**
* Same as {@code MediaType.valueOf(type)}, but with fallback in case {@code MediaType.valueOf(type)}
* throws an IllegalArgumentException.
- * <br/><br/>
- *
+ * <p>
* The fallback is to retry with some special characters replaces in String {@code type}.
*
* @param type
- * @return
*/
public static MediaType parse(String type) {
diff --git a/viewers/restfulobjects/rendering/src/main/java/org/apache/isis/viewer/restfulobjects/rendering/domaintypes/AbstractTypeMemberReprRenderer.java b/viewers/restfulobjects/rendering/src/main/java/org/apache/isis/viewer/restfulobjects/rendering/domaintypes/AbstractTypeMemberReprRenderer.java
index 824b4fd..b9a583a 100644
--- a/viewers/restfulobjects/rendering/src/main/java/org/apache/isis/viewer/restfulobjects/rendering/domaintypes/AbstractTypeMemberReprRenderer.java
+++ b/viewers/restfulobjects/rendering/src/main/java/org/apache/isis/viewer/restfulobjects/rendering/domaintypes/AbstractTypeMemberReprRenderer.java
@@ -38,8 +38,6 @@ public abstract class AbstractTypeMemberReprRenderer<R extends ReprRendererAbstr
/**
* null if the feature is an object action param.
- *
- * @return
*/
public MemberType getMemberType() {
return memberType;
diff --git a/viewers/restfulobjects/viewer/src/main/java/org/apache/isis/viewer/restfulobjects/viewer/context/ResourceContext.java b/viewers/restfulobjects/viewer/src/main/java/org/apache/isis/viewer/restfulobjects/viewer/context/ResourceContext.java
index 9e2e305..e3f54f8 100644
--- a/viewers/restfulobjects/viewer/src/main/java/org/apache/isis/viewer/restfulobjects/viewer/context/ResourceContext.java
+++ b/viewers/restfulobjects/viewer/src/main/java/org/apache/isis/viewer/restfulobjects/viewer/context/ResourceContext.java
@@ -206,7 +206,6 @@ implements IResourceContext {
/**
* Only applies to rendering of objects
- * @return
*/
@Override
public RepresentationService.Intent getIntent() {
diff --git a/viewers/wicket/model/src/main/java/org/apache/isis/viewer/wicket/model/isis/WicketViewerSettings.java b/viewers/wicket/model/src/main/java/org/apache/isis/viewer/wicket/model/isis/WicketViewerSettings.java
index e27cc82..97f6284 100644
--- a/viewers/wicket/model/src/main/java/org/apache/isis/viewer/wicket/model/isis/WicketViewerSettings.java
+++ b/viewers/wicket/model/src/main/java/org/apache/isis/viewer/wicket/model/isis/WicketViewerSettings.java
@@ -33,19 +33,16 @@ public interface WicketViewerSettings extends Serializable {
/**
* as per {@link IsisConfiguration.Viewer.Wicket#setMaxTitleLengthInParentedTables(int)}
- * @return
*/
int getMaxTitleLengthInParentedTables();
/**
* As per {@link IsisConfiguration.Viewer.Wicket#setDatePattern(String)}
- * @return
*/
String getDatePattern();
/**
* As per {@link IsisConfiguration.Viewer.Wicket#setDateTimePattern(String)}
- * @return
*/
String getDateTimePattern();
diff --git a/viewers/wicket/model/src/main/java/org/apache/isis/viewer/wicket/model/models/ScalarModel.java b/viewers/wicket/model/src/main/java/org/apache/isis/viewer/wicket/model/models/ScalarModel.java
index 4c864bf..bc8b7c0 100644
--- a/viewers/wicket/model/src/main/java/org/apache/isis/viewer/wicket/model/models/ScalarModel.java
+++ b/viewers/wicket/model/src/main/java/org/apache/isis/viewer/wicket/model/models/ScalarModel.java
@@ -330,8 +330,6 @@ implements HasRenderingHints, ScalarUiModel, LinksProvider, FormExecutorContext
* Similar to {@link #mustBeEditable()}, though not called from the same locations.
*
* My suspicion is that it amounts to more or less the same set of conditions.
- *
- * @return
*/
@Override
public boolean isInlinePrompt() {
diff --git a/viewers/wicket/ui/src/main/java/org/apache/isis/viewer/wicket/ui/ComponentFactory.java b/viewers/wicket/ui/src/main/java/org/apache/isis/viewer/wicket/ui/ComponentFactory.java
index f812d14..b65fe43 100644
--- a/viewers/wicket/ui/src/main/java/org/apache/isis/viewer/wicket/ui/ComponentFactory.java
+++ b/viewers/wicket/ui/src/main/java/org/apache/isis/viewer/wicket/ui/ComponentFactory.java
@@ -91,7 +91,6 @@ public interface ComponentFactory extends Serializable {
* {@link #getComponentType() component type} for this factory.
*
* @param model
- * @return
*/
Component createComponent(IModel<?> model);