You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@turbine.apache.org by "Brekke, Jeff" <Je...@qg.com> on 2001/03/28 21:56:25 UTC
Patch: BasePeer.java
In testing some stuff I noticed there were a bunch of System.out.println()
statements in BasePeer.java, so I've removed the static accessor and changed
the lines to Log.debug() statements. This way we don't have to build the
turbine jar with the DEBUG member to true to get the debugging lines, but
instead set the appropriate logging level in tr.props. Patch is below and
also uploaded to http://sites.netscape.net/ekkerbj/patches
jb
Index: BasePeer.java
===================================================================
RCS file:
/home/cvspublic/jakarta-turbine/src/java/org/apache/turbine/om/peer/BasePeer
.java,v
retrieving revision 1.45
diff -u -r1.45 BasePeer.java
--- BasePeer.java 2001/03/14 00:05:51 1.45
+++ BasePeer.java 2001/03/28 19:53:16
@@ -100,9 +100,6 @@
/** Classes that implement this class should override this value. */
public static final String TABLE_NAME = "TABLE_NAME";
- /** Are we in DEBUG mode? */
- private static final boolean DEBUG = false;
-
/** The Turbine default MapBuilder. */
public static final String DEFAULT_MAP_BUILDER =
"org.apache.turbine.util.db.map.TurbineMapBuilder";
@@ -558,9 +555,7 @@
try
{
tds = new TableDataSet(connection, tables.get(i), kd );
- if (DEBUG)
- System.out.println("BasePeer.doDelete whereClause = " +
- whereClause.toString(" AND ") );
+ Log.debug("BasePeer.doDelete whereClause = " +
whereClause.toString(" AND ") );
tds.where( whereClause.toString(" AND ") );
tds.fetchRecords();
if ( tds.size() > 1 && criteria.isSingleRecord() )
@@ -1060,9 +1055,7 @@
if (limitString != null) querySql.setLimit(limitString);
- if (DEBUG) Log.info("BasePeer.querySql= "+ querySql.toString());
- if (DEBUG) System.out.println("BasePeer.querySql= "+
- querySql.toString());
+ Log.debug("BasePeer.querySql= "+ querySql.toString());
return querySql.toString();
}
@@ -1633,7 +1626,7 @@
// Get affected records.
tds = new TableDataSet(connection, tables.get(i), kd );
tds.where( whereClause.toString(" AND " ) );
- if (DEBUG) System.out.println("Update (select)
whereClause=" + whereClause.toString(" AND ") );
+ Log.debug("Update (select) whereClause=" +
whereClause.toString(" AND ") );
tds.fetchRecords();
if ( tds.size() > 1 && selectCriteria.isSingleRecord() )
-----------------------------------------------------------------
Jeffrey D. Brekke Information Systems
Jeff.Brekke@qg.com Quad/Graphics
http://www.qg.com 555 South 108th Street
414-566-3302 West Allis, WI 53214-1145 USA
-----------------------------------------------------------------
-----------------------------------------------------------------------
This message has been scanned for viruses with Trend Micro's Interscan VirusWall.
---------------------------------------------------------------------
To unsubscribe, e-mail: turbine-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: turbine-dev-help@jakarta.apache.org