[GitHub] [daffodil-vscode] Shanedell commented on a diff in pull request #582: omega-edit client get specified port from launch.json

["Shanedell (via GitHub)" <gi...@apache.org>]

Shanedell commented on code in PR #582:
URL: https://github.com/apache/daffodil-vscode/pull/582#discussion_r1170072089


##########
src/dataEdit/client.ts:
##########
@@ -80,9 +80,29 @@ function getPidFile(serverPort: number) {
 
 async function getOmegaEditPort() {
   if (omegaEditPort === 0) {
-    omegaEditPort = vscode.workspace
-      .getConfiguration('dataEditor')
-      .get<number>('omegaEditPort', DEFAULT_OMEGA_EDIT_PORT)
+    /**

Review Comment:
   @arosien The current code does work. The reason
   
   ```ts
       omegaEditPort = vscode.workspace
         .getConfiguration('dataEditor')
         .get<number>('omegaEditPort', DEFAULT_OMEGA_EDIT_PORT)
   ```
   
   didn't work is because it gets the default config setup in the `package.json` unless in debug mode. In debug mode it actually worked perfectly fine. The current update makes it work by looking at configs inside of `.vscode/launch.json`. The name of the variable wasn't the issue it was that the config desired wasn't being parsed yet.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org