You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@arrow.apache.org by dh...@apache.org on 2023/11/18 10:01:50 UTC
(arrow-datafusion) branch main updated: Minor: clean up the code based on Clippy (#8257)
This is an automated email from the ASF dual-hosted git repository.
dheres pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/arrow-datafusion.git
The following commit(s) were added to refs/heads/main by this push:
new 2e3f4344be Minor: clean up the code based on Clippy (#8257)
2e3f4344be is described below
commit 2e3f4344be4b520a1c58ab82b4171303b6826b65
Author: Alex Huang <hu...@gmail.com>
AuthorDate: Sat Nov 18 11:01:42 2023 +0100
Minor: clean up the code based on Clippy (#8257)
---
datafusion/physical-expr/src/array_expressions.rs | 4 ++--
datafusion/physical-plan/src/filter.rs | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/datafusion/physical-expr/src/array_expressions.rs b/datafusion/physical-expr/src/array_expressions.rs
index 8bb70c3168..e2d22a0d33 100644
--- a/datafusion/physical-expr/src/array_expressions.rs
+++ b/datafusion/physical-expr/src/array_expressions.rs
@@ -582,14 +582,14 @@ pub fn array_except(args: &[ArrayRef]) -> Result<ArrayRef> {
match (array1.data_type(), array2.data_type()) {
(DataType::Null, _) | (_, DataType::Null) => Ok(array1.to_owned()),
(DataType::List(field), DataType::List(_)) => {
- check_datatypes("array_except", &[&array1, &array2])?;
+ check_datatypes("array_except", &[array1, array2])?;
let list1 = array1.as_list::<i32>();
let list2 = array2.as_list::<i32>();
let result = general_except::<i32>(list1, list2, field)?;
Ok(Arc::new(result))
}
(DataType::LargeList(field), DataType::LargeList(_)) => {
- check_datatypes("array_except", &[&array1, &array2])?;
+ check_datatypes("array_except", &[array1, array2])?;
let list1 = array1.as_list::<i64>();
let list2 = array2.as_list::<i64>();
let result = general_except::<i64>(list1, list2, field)?;
diff --git a/datafusion/physical-plan/src/filter.rs b/datafusion/physical-plan/src/filter.rs
index 107c95eff7..b6cd9fe79c 100644
--- a/datafusion/physical-plan/src/filter.rs
+++ b/datafusion/physical-plan/src/filter.rs
@@ -201,7 +201,7 @@ impl ExecutionPlan for FilterExec {
// tracking issue for making this configurable:
// https://github.com/apache/arrow-datafusion/issues/8133
let selectivity = 0.2_f64;
- let mut stats = input_stats.clone().into_inexact();
+ let mut stats = input_stats.into_inexact();
stats.num_rows = stats.num_rows.with_estimated_selectivity(selectivity);
stats.total_byte_size = stats
.total_byte_size