You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@calcite.apache.org by "Julian Hyde (Jira)" <ji...@apache.org> on 2023/03/12 05:42:00 UTC

[jira] [Commented] (CALCITE-5574) Break MockCatalogReaderSimple#init into smaller methods

    [ https://issues.apache.org/jira/browse/CALCITE-5574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17699306#comment-17699306 ] 

Julian Hyde commented on CALCITE-5574:
--------------------------------------

If it's reasonably straightforward to retain history (that is, keep most of the lines unchanged so we can see which change caused them to be added), that would be useful.

> Break MockCatalogReaderSimple#init into smaller methods
> -------------------------------------------------------
>
>                 Key: CALCITE-5574
>                 URL: https://issues.apache.org/jira/browse/CALCITE-5574
>             Project: Calcite
>          Issue Type: Improvement
>          Components: tests
>            Reporter: Benchao Li
>            Priority: Minor
>
> In the [discussion|https://github.com/apache/calcite/pull/3092#discussion_r1131364712] of https://github.com/apache/calcite/pull/3092, {{MockCatalogReaderSimple#init}} is too long to add new code, we should break it into smaller ones. One possible way is to move each table registration to a separate one method.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)