[jira] [Comment Edited] (TUBEMQ-166) Hide `bdbStore` configs in master.ini

["Guocheng Zhang (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TUBEMQ-166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17120456#comment-17120456 ] 

Guocheng Zhang edited comment on TUBEMQ-166 at 5/31/20, 9:14 AM:
-----------------------------------------------------------------

I think these need to be changed like this:
bdbLocalSync            --> [replication].metaLocalSyncPolicy
bdbReplicaSync          --> [replication].metaReplicaSyncPolicy
bdbReplicaAck           --> [replication].repReplicaAckPolicy

Reason: bdbLocalSync sets the storage strategy of this node, but this node is not necessarily the master node; bdbLocalSync and bdbReplicaSync are both replication-related content, and the placement of the location together will make it easier for latercomers to understand; bdbReplicaAck manages the replication node response strategy, such as the above two parameters will be more clear after adding hints.

And, also need to add to modify the name of the corresponding fields in the configuration description document.


was (Author: gosonzhang):
I think these need to be changed like this:
bdbLocalSync            --> [replication].metaLocalSyncPolicy
bdbReplicaSync          --> [replication].metaReplicaSyncPolicy
bdbReplicaAck           --> [replication].repReplicaAckPolicy

Reason: bdbLocalSync sets the storage strategy of this node, but this node is not necessarily the master node; bdbLocalSync and bdbReplicaSync are both replication-related content, and the placement of the location together will make it easier for latercomers to understand; bdbReplicaAck manages the replication node response strategy, such as the above two parameters will be more clear after adding hints.

And, also need to add to modify the name of the corresponding field in the configuration description document.

> Hide `bdbStore` configs in master.ini
> -------------------------------------
>
>                 Key: TUBEMQ-166
>                 URL: https://issues.apache.org/jira/browse/TUBEMQ-166
>             Project: Apache TubeMQ
>          Issue Type: Improvement
>            Reporter: Ping Yu
>            Assignee: Ping Yu
>            Priority: Major
>             Fix For: 0.5.0
>
>
> I was quit confused when I saw the `[bdbStore]` section in `master.ini`.
> After read some codes and intro of "Oracle Berkeley DB Java Edition", I realized that `bdbStore` is the embedded database, used for meta data storage, and replication between masters. (Am I right ?)
> I suggest that hiding `bdbStore` configs in `master.ini`, as `bdb` is an implementation detail, better not to bother users.
> Necessary configs for `bdbStore` can be renamed to another ones, to be more reasonable.
> E.g. `bdbNodePort` rename to `replicationPort` in `[master]` section.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)