[GitHub] [trafficcontrol] ocket8888 opened a new pull request #4822: Rewrote ToAutorenewCerts 'check' to Python3

[GitBox <gi...@apache.org>]

ocket8888 opened a new pull request #4822:
URL: https://github.com/apache/trafficcontrol/pull/4822


   ## What does this PR (Pull Request) do?
   - [x] This PR is not related to any Issue - but it _is_ related to #4010 .
   
   This rewrites a single "check" script from Perl to Python3. It doesn't _replace_ the old script - yet - just provides an alternative.
   
   The script in question is `ToAutorenewCerts.pl`, and it has several external dependencies that would not be dependencies of a Go-only Traffic Ops deployment. The Python version has no dependencies outside of the Python3 standard library.
   
   A possible alternative to this is given in #4010 . The motivation for doing this "again" is threefold:
   
   - #4010 has had conflicts for a long time, and may not be updated by the author
   - #4010 appears to pull in another external dependency: "rlog"
   - #4010 also rewrites _all other_ "checks" and is thus harder to review at once
   
   ## Which Traffic Control components are affected by this PR?
   - Traffic Ops
   
   ## What is the best way to verify this PR?
   There are some very sparing unit tests that can be run with `python3 -m doctest path/to/ToAutorenewCerts.py`, but the best way to test it is to simply run the script (`-h`/`--help` for usage - but it should be perfectly able to run using existing commands by just replacing `ToAutorenewCerts.pl` with `ToAutorenewCerts.py` because it supports the exact same command line arguments) and verify that it properly renews expired certificates by calling the appropriate API endpoints. Which is all it really does, to be honest.
   
   ## The following criteria are ALL met by this PR
   - [x] This PR includes tests
   - [x] This PR includes docstrings
   - [x] This PR includes an update to CHANGELOG.md
   - [x] This PR includes any and all required license headers
   - [x] This PR does not include a database migration
   - [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY**


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org