[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #36728: [SPARK-39341][K8S] KubernetesExecutorBackend should allow IPv6 pod IP

[GitBox <gi...@apache.org>]

dongjoon-hyun commented on code in PR #36728:
URL: https://github.com/apache/spark/pull/36728#discussion_r894137234


##########
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/KubernetesExecutorBackend.scala:
##########
@@ -66,7 +66,8 @@ private[spark] object KubernetesExecutorBackend extends Logging {
 
     SparkHadoopUtil.get.runAsSparkUser { () =>
       // Debug code
-      Utils.checkHost(arguments.hostname)
+      assert(arguments.hostname != null &&
+          (arguments.hostname.indexOf(':') == -1 || arguments.hostname.split(":").length > 2))

Review Comment:
   The original code of `Utils.checkHost` is made in YARN age.
   And, that is a valid check in YARN environment's URL.
   Please see the link in the PR description.
   
   <img width="460" alt="Screen Shot 2022-06-09 at 9 11 24 PM" src="https://user-images.githubusercontent.com/9700541/172988832-03ccea4e-0f12-4093-a59c-045eec86292c.png">
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org